LinuxQuestions.org
Visit Jeremy's Blog.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 07-26-2021, 12:12 PM   #1
ctrondheim
Member
 
Registered: Nov 2017
Posts: 32

Rep: Reputation: Disabled
xv on -current


I have the very latest Slackware-current fully installed on test machine and all is ok.

xv is currently in the extra section of -current. I.ve assumed that packages in extra are being built along with the rest of the packages as -current moves along. I've tried to build xv from current/extra and it fails with:

Code:
cc -O -DDOPNG -I/usr/include -I/usr/include -DDOJPEG -I/usr/include -DDOTIFF -DUSE_TILED_TIFF_BOTLEFT_FIX -I/usr/include -DDOPDS -DDOJP2K -I/usr/include  -DMGCSFXDIR=\"/usr/lib64/xv\"      -DLINUX -L/usr/X11R6/lib64    -DDOCDIR=\"/usr/share/doc/xv\" -DSYSCONFDIR=\"/etc\" -DXVEXECPATH=\"/usr/lib64/xv\" -c xvjp2k.c
xvjp2k.c:79:5: error: conflicting types for ‘jas_memdump’
   79 | int jas_memdump(FILE *fp,void *data,size_t len) {return 0;}
      |     ^~~~~~~~~~~
In file included from /usr/include/jasper/jasper.h:82,
                 from xvjp2k.c:53:
/usr/include/jasper/jas_debug.h:107:19: note: previous declaration of ‘jas_memdump’ was here
  107 | JAS_DLLEXPORT int jas_memdump(FILE *out, const void *data, size_t len);
      |                   ^~~~~~~~~~~
make: *** [Makefile.std:362: xvjp2k.o] Error 1
Should I assume stuff in extra is not maintained? However the binary package works just fine. Its date is 2018-04-13 18:00.

Has anyone built xv on a recent current?
 
Old 07-26-2021, 05:33 PM   #2
rkelsen
Senior Member
 
Registered: Sep 2004
Distribution: slackware
Posts: 4,461
Blog Entries: 7

Rep: Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561
Yeah, I get the same error here.

I'd say that if the binary works for you, use it.
Quote:
Originally Posted by ctrondheim
Should I assume stuff in extra is not maintained?
No.
 
Old 07-26-2021, 07:49 PM   #3
pisti
Member
 
Registered: Jul 2006
Location: Montréal, Canada
Distribution: Slackware
Posts: 258

Rep: Reputation: 33
i would be very happy if xv continued to work also in the future on newer slackware installations and versions. it's a very handy little tool - like it was already discussed here at LQ some months ago...
 
Old 07-27-2021, 01:52 AM   #4
ponce
LQ Guru
 
Registered: Aug 2004
Location: Pisa, Italy
Distribution: Slackware
Posts: 7,104

Rep: Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178Reputation: 4178
unfortunately xv (to which I'm pretty fond too being the image viewer I used a lot when I started with Slackware) has been dropped upstream since some years and, looking around, doesn't seem to be maintained anymore...

to fix this error should be relatively easy, you can patch the SlackBuild like this
Code:
--- ./xv.SlackBuild.orig	2018-04-23 19:20:59.038170130 +0200
+++ ./xv.SlackBuild	2021-07-27 08:46:37.228125000 +0200
@@ -65,6 +65,10 @@
 fi
 zcat $CWD/C.gz | patch -p1 --verbose --backup --suffix=.orig || exit 1
 zcat $CWD/xv-libpng-1.5.patch.gz | patch -p0 --verbose --backup --suffix=.orig || exit 1
+
+# fix for the newer jasper
+sed -i "s|fp\,void\ |fp,const void |" xvjp2k.c
+
 make -f Makefile.std || exit 1
 strip --strip-unneeded bggen vdcomp xcmap xv xvpictoppm
 mkdir -p $PKG/usr/bin
or, in alternative, apply another patch (with -p1) after the others in the SlackBuild
Code:
--- ./xvjp2k.c.orig	2021-07-27 08:55:22.186125000 +0200
+++ ./xvjp2k.c	2021-07-27 08:56:30.079125000 +0200
@@ -76,7 +76,7 @@
 */
 int jas_getdbglevel(void) {return 0;}
 int jas_setdbglevel(int n) {return 0;}
-int jas_memdump(FILE *fp,void *data,size_t len) {return 0;}
+int jas_memdump(FILE *fp,const void *data,size_t len) {return 0;}
 
 int jas_eprintf(const char *fmt,...)         /* Handle JasPer Library message */
 {
or integrate the xv.jasper.diff.

but who knows which kind of disruptive changes will be in the future in the libraries xv uses...

Last edited by ponce; 07-27-2021 at 02:02 AM.
 
4 members found this post helpful.
Old 07-27-2021, 03:24 AM   #5
rkelsen
Senior Member
 
Registered: Sep 2004
Distribution: slackware
Posts: 4,461
Blog Entries: 7

Rep: Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561Reputation: 2561
That fixes it for me. Thanks Mr. Ponce.
 
Old 07-27-2021, 05:27 AM   #6
ctrondheim
Member
 
Registered: Nov 2017
Posts: 32

Original Poster
Rep: Reputation: Disabled
It fixes it for me too! Thanks very much Mr. Ponce.
 
  


Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
DISCUSSION: Upgrade to Slackware -current without a -current CD truthfatal LinuxAnswers Discussion 0 09-19-2006 01:42 PM
cvs diff the most current and second last current version powah Linux - Software 1 03-30-2006 01:02 PM
slack-current of dropline ? Hi all :-) slack-current of dropline ? frochet Slackware 2 06-11-2004 11:57 AM
current Slack-Current giving troubles? r_jensen11 Slackware 5 02-02-2004 05:08 PM
Staying Current (with current) hjles Slackware 1 01-21-2003 07:03 PM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 07:39 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration