|
Shfit in xpdf
I wanted to add a keyboard shortcut so that shift-space would scroll up in xpdf.
I found that any shortcuts that I created that involved shift did not work.
Has anybody else noticed this issue? Since I had already compiled xpdf anyway (this was on my office machine, which did not come with xpdf or slacware for that matter), I figured there would probably be a simple fix in the code. I found that I needed to make the change below. Is there a good reason for not having shift work with characters with hex value < 32? Can this patch be added to the xpdf package?
--- ./xpdf-3.03/xpdf/GlobalParams.cc 2011-08-15 17:08:53.000000000 -0400
+++ ../xpdf-3.03/xpdf/GlobalParams.cc 2013-04-26 10:41:00.000000000 -0400
@@ -2624,7 +2624,7 @@
lockGlobalParams;
cmds = NULL;
// for ASCII chars, ignore the shift modifier
- modMask = code <= 0xff ? ~xpdfKeyModShift : ~0;
+ modMask = ((code <= 0xff)&&(code >32)) ? ~xpdfKeyModShift : ~0;
for (i = 0; i < keyBindings->getLength(); ++i) {
binding = (KeyBinding *)keyBindings->get(i);
if (binding->code == code &&
|
