[SOLVED] pkgtools' directories migration results in unnecessary metadata loss

opty · 05-09-2022, 08:54 AM

In pkgtools' doinst.sh, why do we use

Code:

mkdir -p var/lib/pkgtools/$directory
mv var/log/$directory/* var/lib/pkgtools/$directory 2> /dev/null
rm -rf var/log/$directory

which results in unnecessary metadata loss (at least directory's birth and its files ctime), instead of just

Code:

mv var/log/$directory/ var/log/pkgtools/ 2> /dev/null

?

If I migrated "manually" before the pkgtools upgrade (14.2 to 15.0), would it work?

bassmadrigal · 05-09-2022, 10:20 AM

Quote:

Originally Posted by opty

which results in unnecessary metadata loss (at least directory's birth and its files ctime)

This doesn't cause the loss of the package or scripts logs ctime.

The directories were already created in the SlackBuild and are part of the package when you install it. The code to create /var/lib/pkgtools/{packages,scripts} in the doinst.sh is redundant.

Code:

mkdir -p $PKG/var/lib/pkgtools/{packages,scripts,douninst.sh}

opty · 05-10-2022, 01:42 AM

It does:

Code:

opty@kiwi:~/tmp$ mkdir -pv dir1/ && touch dir1/file && stat dir1/file && mkdir -pv dir2/ && echo sleep 10 && sleep 10 && mv -v dir1/file dir2/ && stat dir2/file
mkdir: created directory 'dir1/'
  File: dir1/file
  Size: 0               Blocks: 1          IO Block: 131072 regular empty file
Device: c000a1h/12583073d       Inode: 998066      Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1001/    opty)   Gid: ( 1001/    opty)
Access: 2022-05-10 08:34:55.912716481 +0200
Modify: 2022-05-10 08:34:55.912716481 +0200
Change: 2022-05-10 08:34:55.912716481 +0200
 Birth: 2022-05-10 08:34:55.911716454 +0200
mkdir: created directory 'dir2/'
sleep 10
renamed 'dir1/file' -> 'dir2/file'
  File: dir2/file
  Size: 0               Blocks: 1          IO Block: 131072 regular empty file
Device: c000a1h/12583073d       Inode: 998066      Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1001/    opty)   Gid: ( 1001/    opty)
Access: 2022-05-10 08:34:55.912716481 +0200
Modify: 2022-05-10 08:34:55.912716481 +0200
Change: 2022-05-10 08:35:05.921984544 +0200
 Birth: 2022-05-10 08:34:55.911716454 +0200

opty · 05-10-2022, 08:52 AM

I created a script which basically

Code:

mkdir -p /var/log/pkgtools/
for directory in removed_{packages,scripts}; do
    mv /var/log/$directory/ /var/log/pkgtools/
    
    (cd /var/log/; ln -s pkgtools/$directory/ .)
done

mkdir -p /var/lib/pkgtools/
for directory in packages scripts setup; do
    mv /var/log/$directory/ /var/lib/pkgtools/
    
    (cd /var/log/; ln -s ../lib/pkgtools/$directory/ .)
done

That should end up with a migration according to my liking.

bassmadrigal · 05-10-2022, 10:28 AM

Quote:

Originally Posted by opty

It does:

Code:

opty@kiwi:~/tmp$ mkdir -pv dir1/ && touch dir1/file && stat dir1/file && mkdir -pv dir2/ && echo sleep 10 && sleep 10 && mv -v dir1/file dir2/ && stat dir2/file
mkdir: created directory 'dir1/'
  File: dir1/file
  Size: 0               Blocks: 1          IO Block: 131072 regular empty file
Device: c000a1h/12583073d       Inode: 998066      Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1001/    opty)   Gid: ( 1001/    opty)
Access: 2022-05-10 08:34:55.912716481 +0200
Modify: 2022-05-10 08:34:55.912716481 +0200
Change: 2022-05-10 08:34:55.912716481 +0200
 Birth: 2022-05-10 08:34:55.911716454 +0200
mkdir: created directory 'dir2/'
sleep 10
renamed 'dir1/file' -> 'dir2/file'
  File: dir2/file
  Size: 0               Blocks: 1          IO Block: 131072 regular empty file
Device: c000a1h/12583073d       Inode: 998066      Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1001/    opty)   Gid: ( 1001/    opty)
Access: 2022-05-10 08:34:55.912716481 +0200
Modify: 2022-05-10 08:34:55.912716481 +0200
Change: 2022-05-10 08:35:05.921984544 +0200
 Birth: 2022-05-10 08:34:55.911716454 +0200

Oops, I thought ctime was creation time, not change time.

However, since -current leading up to 15.0 had several mass rebuilds, every official package file in the package database will be new. And you really should be rebuilding any 3rd-party packages since 15.0's system libraries had many, many updates over its almost 6 year development. I'm not seeing an issue with how the database migration was handled.

Either way, 15.0 has been finalized and ISOs created, so it's a little late to try and get it changed.

opty · 05-11-2022, 02:15 AM

Right, it affects mainly /var/log/removed_{packages,scripts}/ but the principle remains the same.

Better late than never as it may still help someone and I can still do it my way. :-)

chrisretusn · 05-11-2022, 02:37 AM

Quote:

Originally Posted by opty

I can still do it my way. :-)

The beauty of Slackware!

opty · 05-12-2022, 04:34 AM

"Manual" migration and pkgtools upgrade (14.2 to 15.0) successful! \o/