[SOLVED] hitting tab after man makes bash unresponsive

coltfire · 06-20-2023, 04:25 AM

Hi,
When I, accidentally, hit TAB after man command (empty argument),
the bash goes unresponsive, cpu 100% for couple of minutes.
I guess it happens because of bash completion,
but is there any solution to accidentally hitting TAB on empty argument after man?

Loomx · 06-20-2023, 05:05 AM

I used to have this happen too, very frustrating...

The master bash-completion file for `man' is /usr/share/bash-completion/completions/man
To edit it, copy it to /etc like this (as root):

Code:

cp /usr/share/bash-completion/completions/man /etc/bash_completion.d/man

Then edit line 69, which is the `else' branch of an `if' statement checking that there is an argument after the `man' command.
You want to change this:

Code:

manpath="${manpath//://*man$sect/ } ${manpath//://*cat$sect/ }"

to this:

Code:

return

Now if you push tab with an empty argument it just returns immediately.

coltfire · 06-20-2023, 05:43 AM

Thanks!

Your solution helps with an issue
(needed to restart bash, so the edit comes to an effect)

marav · 06-21-2023, 03:01 AM

FYI

The latest release (2.11) is 3 years old...
I recompiled bash_completion based on the latest commit (0a2443e3 - 2 days ago)
Everything works as it should

coltfire · 06-21-2023, 10:53 AM

Quote:

The latest release (2.11) is 3 years old...
I recompiled bash_completion based on the latest commit (0a2443e3 - 2 days ago)
Everything works as it should

Thanks, I will try to do the same
Did you installed it as a local slackbuild?

marav · 06-21-2023, 11:08 AM

Quote:

Originally Posted by coltfire

Thanks, I will try to do the same
Did you installed it as a local slackbuild?

I use this script (Thx PV) to catch the latest git version:

Code:

#!/bin/sh

URL=https://github.com/scop
PKGNAM=bash-completion

# Pull a stable branch + patches
BRANCH=${1:-master}

# Clear download area:
rm -rf ${PKGNAM}

# Clone repository:
git clone ${URL}/${PKGNAM}

# checkout $BRANCH:
( cd ${PKGNAM} 
  git checkout $BRANCH || exit 1
)

HEADISAT="$( cd ${PKGNAM} && git log -1 --format=%h )"
DATE="$( cd ${PKGNAM} && git log -1 --format=%cd --date=format:%Y%m%d )"
LONGDATE="$( cd ${PKGNAM} && git log -1 --format=%cd --date=format:%c )"

# Cleanup.  We're not packing up the whole git repo.
( cd ${PKGNAM} && find . -type d -name ".git*" -exec rm -rf {} \; 2> /dev/null )
mv ${PKGNAM} ${PKGNAM}-${DATE}_${HEADISAT}
tar cf ${PKGNAM}-${DATE}_${HEADISAT}.tar ${PKGNAM}-${DATE}_${HEADISAT}
plzip -9 -f ${PKGNAM}-${DATE}_${HEADISAT}.tar
rm -rf ${PKGNAM}-${DATE}_${HEADISAT}
touch -d "$LONGDATE" ${PKGNAM}-${DATE}_${HEADISAT}.tar.lz
echo
echo "${PKGNAM} branch $BRANCH with HEAD at $HEADISAT packaged as ${PKGNAM}-${DATE}_${HEADISAT}.tar.lz"
echo

And this modified SlackBuild

Code:

# Slackware build script for bash-completion
 
-VERSION=2.11
+VERSION=20230619_0a2443e3
 ARCH=noarch
 BUILD=${BUILD:-2}
 
@@ -49,7 +49,7 @@
 done
 
 # Fixup sh completion for us
-zcat $CWD/fixup-sh-script-completions.diff.gz | patch -p1 --verbose || exit 1
+#zcat $CWD/fixup-sh-script-completions.diff.gz | patch -p1 --verbose || exit 1
 
 autoreconf -vif

coltfire · 06-21-2023, 11:36 AM

Thank you!
Will try it out