Question on getops --long

maddyfreaks · 06-02-2015, 07:40 PM

Please Help me on this all....

I need to write a shell script with getopts long format taking couple arguments.
You can use either bash/ksh
I am using RHEL6

Code:

OPTS=`getopt -o vhns: --long verbose,dry-run,help,stack-size: -n 'parse-options' -- "$@"`
#`OPTS=`getopt -o vhn: --long verbose,dry-run,help: -n 'parse-options' -- "$@"`

if [ $? != 0 ] ; then echo "Failed parsing options." >&2 ; exit 1 ; fi

echo "$OPTS"
eval set -- "$OPTS"

VERBOSE=false
HELP=false
DRY_RUN=false
STACK_SIZE=0

while true; do
case "$1" in
-v | --verbose )        VERBOSE=true; shift ;;
-h | --help )           HELP=true; shift ;;
-n | --dry-run )        DRY_RUN="$2"; shift 2;;
-s | --stack-size )     STACK_SIZE="$2"; shift 3;;
-- ) shift; break ;;
* ) break ;;
esac
done

echo VERBOSE=$VERBOSE
echo HELP=$HELP
echo DRY_RUN=$DRY_RUN
echo STACK_SIZE=$STACK_SIZE

=======================================
When executing ...
$ ./test2 -s ABCD
-s 'ABCD' --
VERBOSE=false
HELP=false
DRY_RUN=false
STACK_SIZE=ABCD #Here I can see the output...

$ ./test2 -n ABCD
-n -- 'ABCD'
VERBOSE=false
HELP=false
DRY_RUN=-- #Here I am not able to see the output.. this is supposed to get value of ABCD to DRY_RUN
STACK_SIZE=0

Please help me fix this

a4z · 06-03-2015, 01:02 AM

replace your OPTS variable

Code:

OPTS=`getopt -o vhn:s: --long verbose,help,dry-run:,stack-size: -n 'test.sh' -- "$@"`

maddyfreaks · 06-14-2015, 08:10 PM

Tried what ever you asked but partially it helps not completly. Please see below.

Code:

./abcd.ksh  -n 2 -s 3
 -n '2' -s '3' --
VERBOSE=false
HELP=false
DRY_RUN=2     #It worked.
STACK_SIZE=3  #It worked.

#Tried changing the order it failed.

./abcd.ksh  -s 2 -n 3
 -s '2' -n '3' --
VERBOSE=false
HELP=false
DRY_RUN=false    #It Failed.
STACK_SIZE=2     #It Worked.

Not sure why it only works for S but not for N option.

michaelk · 06-14-2015, 09:04 PM

Code:

-n | --dry-run )        DRY_RUN="$2";    shift 2;;
-s | --stack-size )     STACK_SIZE="$2"; shift 3;;

Do you see your error?

maddyfreaks · 06-15-2015, 08:26 AM

No i dont see any error. If you feel there is one .. can you please correct. In sheer of completing the script.

your help is appreciated.

michaelk · 06-15-2015, 08:43 AM

Try:

Code:

-s | --stack-size )     STACK_SIZE="$2"; shift 2;;

pan64 · 06-15-2015, 08:44 AM

dry-run needs no argument, therefore shift 2 is not ok, but I'm not really sure what do you really want, probably there is an argument
STACK_SIZE needs 1 argument, therefore shift 3 is definitely wrong, you need shift 2.

maddyfreaks · 06-16-2015, 07:30 PM

DRY_RUN="$2" #this means we need an argument correct ?

pan64 · 06-17-2015, 12:35 AM

for me it is completely irrelevant if you want to have it an argument. But actually I have no idea what is that good for. But that does not mean it is not ok, just I can't understand.

rknichols · 06-17-2015, 09:56 AM

Quote:

Originally Posted by maddyfreaks

Code:

OPTS=`getopt -o vhns: --long verbose,dry-run,help,stack-size: -n 'parse-options' -- "$@"`

In your getopt call you indicate that "dry-run" does not take an argument (no trailing ":"). Later in your script, you handle it like it does have an argument. That is not going to work.

michaelk · 06-17-2015, 10:49 AM

The OP indicated that an argument was desired so that is why a4z added the :. Since an argument is desired $2 is required.

Code:

OPTS=`getopt -o vhn:s: --long verbose,help,dry-run:,stack-size: -n 'test.sh' -- "$@"`

maddyfreaks · 06-18-2015, 06:03 PM

I need to have an argument to dry-run. As said after pointing out ...
Here is the updated script.

Code:

#!/bin env ksh
OPTS=`getopt -o vhn:s: --long verbose,dry-run,help,stack-size: -n 'parse-options' -- "$@"`

if [ $? != 0 ] ; then echo "Failed parsing options." >&2 ; exit 1 ; fi

echo "$OPTS"
eval set -- "$OPTS"

VERBOSE=false
HELP=false
DRY_RUN=false
STACK_SIZE=0

while true; do
case "$1" in
-v | --verbose )        VERBOSE=true; shift ;;
-h | --help )           HELP=true; shift ;;
-n | --dry-run )        DRY_RUN="$2"; shift 2;;
-s | --stack-size )     STACK_SIZE="$2"; shift 3;;
-- ) shift; break ;;
* ) break ;;
esac
done

echo VERBOSE=$VERBOSE
echo HELP=$HELP
echo DRY_RUN=$DRY_RUN
echo STACK_SIZE=$STACK_SIZE

####################################
When i change the order of the passing arguments.. output is not desirable.

Code:

$ ./testcase.ksh -n 2 -s 3
 -n '2' -s '3' --
VERBOSE=false
HELP=false
DRY_RUN=2
STACK_SIZE=3
#the above works good.

Code:

$ ./testcase.ksh -s 2 -n 3
 -s '2' -n '3' --
VERBOSE=false
HELP=false
DRY_RUN=false
STACK_SIZE=2

##This failes.. though i passed Dry_run = 2 it went for other varaiable to stack-size.

michaelk · 06-18-2015, 06:44 PM

You still did not correct your script per our posts 6 and 7.