[SOLVED] Python

czezz · 05-07-2021, 08:50 AM

I am trying to reuse following python code to check host and port connectivity.
https://gist.github.com/betrcode/0248f0fda894013382d7

Code:

import socket
def isOpen("192.168.56.104",22):
   s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
   try:
      s.connect((ip, int(port)))
      s.shutdown(2)
      return True
   except:
      return False

The problem is that it does not work at all and its hard to me to figure out what is the issue (i just started with python today).
Seems like it does not like quota. But no matter what I try - change to single quota or remove quota completely - the error stays the same

Code:

./con.py
  File "./con.py", line 11
    def isOpen("192.168.56.104",22):
                              ^
SyntaxError: invalid syntax

pan64 · 05-07-2021, 08:53 AM

you need to specify variable names in functions, like:

Code:

def isOpen(ip, port):
   s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
   try:
      s.connect((ip, int(port)))
      s.shutdown(2)
      return True
   except:
      return False

a = isOpen("192.168.56.104",22)

Or probably do you want to specify default values?

Code:

def isOpen(ip="default ip", port="default port"):

czezz · 05-07-2021, 10:21 AM

Thanks. I guess it worked... I was expecting to get 0 or 1 (True or False actually) but instead i got... nothing?
Why?

Another question:
How come it knows what "a" is? It is nowhere used in the code. Only at the last line of the code.
I guess def isOpen(ip, port): somehow matches what stands in "a"... but how does it know to look for values there???

pan64 · 05-07-2021, 10:31 AM

Quote:

Originally Posted by czezz

Thanks. I guess it worked... I was expecting to get 0 or 1 (True or False actually) but instead i got... nothing?

Sorry, I don't really understand what did you expect and why. [obviously] the funtion will/should return with True or False (not 0 or 1), but you need to do something with that return value otherwise it will be simply lost.

Quote:

Originally Posted by czezz

Why?

https://www.programiz.com/python-programming/function

Quote:

Originally Posted by czezz

Another question:
How come it knows what "a" is? It is nowhere used in the code. Only at the last line of the code.
I guess def isOpen(ip, port): somehow matches what stands in "a"... but how does it know to look for values there???

a is a variable and your function will return with some value (in your case True or False) and that value will be assigned to a.
you can simply use

Code:

print(a)

to print the content of a (if a was a variable, not an object).

czezz · 05-07-2021, 12:43 PM

OK, im slowly getting there

1. def isOpen(ip, port) - is the definition/structure/body of the function isOpen()
2. isOpen() is executed with parameters - in this example: "192.168.56.104",22
3. a is variable that holds the output of the executed function isOpen()
At least this is how I explain it to myself

4. Now a mystery is why in the if() I cannot use string 'True' but on the other hand 1 / 0 works

Code:

#!/usr/bin/python3

import socket
def isOpen(ip, port):
   s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
   try:
      s.connect((ip, int(port)))
      s.shutdown(2)
      return True
   except:
      return False

a = isOpen("192.168.56.104",22)
print(a)

if (a == 1):
   print("Host is UP 1")

if (a is 'True'):   <<<--- This seems to be ignored
   print("Host is UP True")

NevemTeve · 05-07-2021, 12:47 PM

True and 'True' aren't the same, don't expect them to be equal. Also it is '==' not 'is':

Code:

if (a==True):
    print("Connecting succeed");

boughtonp · 05-07-2021, 12:50 PM

You're trying to compare a boolean to a string, and even correcting "'True'" to "True" is redundant because you already have a boolean.

All you need is "if a:", or do away with the single-use variable and use "if isOpen("192.168.56.104",22):"

pan64 · 05-07-2021, 01:41 PM

Quote:

Originally Posted by boughtonp

You're trying to compare a boolean to a string, and even correcting "'True'" to "True" is redundant because you already have a boolean.

Code:

a=True
if a == True:
    print("ok")   # works
if a == "True":
   print("ok")    # not ok, compare a string to boolean
if a:
    print("ok")   # works