Hi,

My script is as follows:


#!/bin/bash
#This script will extend the specified VG.
clear;
printf "Please enter the name of the vg that you want to extend: \t";
read VG_NAME;
echo "$VG_NAME will be extended.";
printf "Please enter the no. of new disks that will be assigned: \t";
read DISK_COUNT;
echo "You have entered $DISK_COUNT number of disks.";
for (( c=1; c<=$DISK_COUNT; c++ ))
do
printf "Enter disk name: \t";
read DISK_$c;
done
echo "You have entered following disk names:";
for (( c=1; c<=$DISK_COUNT; c++ ))
do
echo ${DISK_$c};
done

OUTPUT:
Please enter the name of the vg that you want to extend: vg_a
vg_a will be extended.
Please enter the no. of new disks that will be assigned: 3
You have entered 3 number of disks.
Enter disk name: a
Enter disk name: b
Enter disk name: c
You have entered following disk names:
./vg_extend.sh: line 18: ${DISK_$c}: bad substitution


I am unable to echo the individual disk names. Please help !


NOTE: I had executed the script in source shell to verify if variable DISK_1, DISK_2, DISK_3 are being initiated or not. They are
getting initiated and holds the value as a, b, c respectively. But the problem is I am unable to display them in for loop.

BR,
Inderpal

It's not possible to do indirect variables quite that way in bash. It's done a bit differently:

http://tldp.org/LDP/abs/html/ivr.html

1 members found this post helpful.

In addition, take a look at using arrays.

http://www.linuxjournal.com/content/bash-arrays

1 members found this post helpful.

Please place your code snippets inside [CODE]...[/CODE] tags for better readability. You may type those yourself or click the "#" button in the edit controls.

The link supplied by Turbocapitalist above is what you need to most directly adapt your existing code. You may also find it in the bash man page under Parameter Expansion, indirect expansion.

2 members found this post helpful.

Hi,

I used the arrays in bash and it is working now. Thanks for your answer.

BR,
Inderpal

Hi,

I used the bash arrays in following way and it is working now. Thanks

Script:
-bash-4.3$ cat vg_extend.sh
#!/bin/bash
#This script will extend the specified VG.
clear;
printf "Please enter the name of the vg that you want to extend: \t";
read VG_NAME;
echo "$VG_NAME will be extended.";
printf "Please enter the no. of new disks that will be assigned: \t";
read DISK_COUNT;
echo "You have entered $DISK_COUNT number of disks.";
for (( c=1; c<=$DISK_COUNT; c++ ))
do
printf "Enter disk name: \t";
read arr[$c];
done
echo "You have entered following disk names:";
for (( c=1; c<=$DISK_COUNT; c++ ))
do
echo ${arr[$c]};
done


Output:
Please enter the name of the vg that you want to extend: vg_gorkon
vg_gorkon will be extended.
Please enter the no. of new disks that will be assigned: 2
You have entered 2 number of disks.
Enter disk name: /dev/disk/disk248
Enter disk name: /dev/disk/disk249
You have entered following disk names:
/dev/disk/disk248
/dev/disk/disk249


BR,
Inderpal

Great. Now they're on One of Those Lists if they clicked on that link.

Seriously though, LJ is a useful resource.

Oh well. I'm sure that I am on several by now...