Hi,
I am trying to remove junk characters from a file through C program. But code is not working in desired way.No output is coming int the output_file.
Here is the code.
Junk characters in junk_file i have entered by typing numeric values >255

-bash-4.1# cat number.c
#include <stdio.h>

main()
{
FILE *fp,*fp1;
fp=fopen("junk_file","r");
char ch;
fp1=fopen("output.c","w");

while((ch=getc(fp))!=EOF)
{
if(ch < '0' || ch > '255') /*unget all the characters beyond the ascii bounds */
ungetc(ch,fp);
else
putc(ch,fp1); /*get rest of the characters in the output file */
}
fclose(fp);
fclose(fp1);
return(0);
}

-bash-4.1# cat junk_file
¦+¦ÃtÃ

i#include<¦-§



Any suggestions.

(1) char and int can be freely mixed. BUT if you mean the numeric values 0 and 255, then you should remove quotes around them.
(2) The so called junk characters are those < 32 or those > 127.
OK

I have edited the code:

-bash-4.1# cat number.c
#include <stdio.h>

main()
{
FILE *fp,*fp1;
fp=fopen("junk_file","r");
char ch;
fp1=fopen("output.c","w");

while((ch=getc(fp))!=EOF)
{
if(ch < 32 || ch > 127) /*unget all the characters beyond the ascii bounds */
ungetc(ch,fp);
else
putc(ch,fp1); /*get rest of the characters in the output file */
}
fclose(fp);
fclose(fp1);
return(0);
}

Still the code is not working, Is their any way we can remove them form appearing in the output file.

AFAIR, unget only pushes the character back to the stream and doesn't bypass it.

So try this
OK

Dear jack.sully,

First in your original program why you are using ungetc(int, FILE *) function. I have run and tested it, it is creating an infinite loop. It never terminates possibly because it first get character then unget it and situation repeats itself.

Try using this code
Also compiling your original code gives this warning.
number.c: In function ‘main’:
number.c:12:21: warning: multi-character character constant [-Wmultichar]
if(ch < '0' || ch > '255') /*unget all the characters beyond the ascii bounds */

So I am agreed with AnanthaP that you have to remove quotes. Write 255 not '255'.

Agree with AnanthaP for replacing the code.

Thanks a lot guys.

Code is working now.(even though i didn't edit the code for warning)

for shiggles heres my ascii scraper:

Instead of using "printf" (which is slow) why not use fputc?

And instead of all the "ifs" used, why not a switch?

And watch out for those "ch >255" tests -they are invalid.

ch is declared a "char", and that means it is an 8 bit signed value. There is no signed character that is 255... signed characters go from -127 to 128, so your test of "ch > 255" is never true.

Using "c" (from the example preceding mine) is declared an integer - which allows for testing for EOF (value is -1), and all values returned are then between 0 and 255...

-bash-4.1# cat junk_clear_new.c

#include <stdio.h>
main(int argc,char *argv[])
{
FILE *fp,*fp1;

if(argc!=2)
fprintf(stderr,"usage: %s file \n",argv[0]);

else
fp=fopen(argv[1],"r");

if(fp==NULL)
perror(argv[1]);
char ch;
fp1=fopen("output.c","w");

while((ch=getc(fp))!=EOF)
{
if(ch > 0 && ch < 255) /*get desired ones */
putc(ch,fp1); /* characters in the output file */
else if(ch=='\n')
printf("\n");
}
fclose(fp);
fclose(fp1);
return(0);
}
-bash-4.1#
-bash-4.1# cat try_junk
i#include<¦-§aa
t¦¦ y u
igg¦+qerté
-bash-4.1#
-bash-4.1# cat output.c
i#include<-aa
t y u
igg+qert
-bash-4.1#

Mission accomplished!

not really. You still have errors in the code...

yes u r very right pollard.
Problem with my code was ,after removing the junk characters from original file i was not able to preserve their empty space in the output file.

bash-4.1# cat try_junk
i#include<¦-§aa
t¦¦ y u
igg¦+qerté
-bash-4.1#
-bash-4.1# cat output.c
i#include<-aa
t y u
igg+qert
-bash-4.1

Correct code is your's one

-bash-4.1# cat latest_junk_clear.c

#include <stdio.h>

main(int argc, char *argv[])
{
int ch;
FILE * fp;

fp= fopen(argv[1], "r");
ch = fgetc(fp);

while(ch != EOF)
{
if(ch == 10)
printf("%c", ch);
if((ch >= 0 && ch <= 9) || (ch >= 11 && ch <= 31))
printf(" ");
if(ch >= 127)
printf(" ");
if((ch >= 32 && ch <= 126) && (ch != 59))
printf("%c", ch);
if(ch == 59)
{
printf("\n");
}

ch = fgetc(fp);
}
fclose(fp);
}

-bash-4.1# cat try_junk
i#include<¦-§aa
t¦¦ y u
igg¦+qerté
-bash-4.1#

-bash-4.1# ./latest_junk try_junk
i#include< - aa
t y u
igg +qert
-bash-4.1#

Now it's fine.

Thanks a lot