GTK header warnings

business_kid · 04-17-2021, 05:54 AM

I tried compiling geeqie-1.6 from source as I'm running from the 2021-02-11 iso and experiencing crashes from geeqie. Never mind about geeqie - that's in a separate thread. The issue in this thread is about headers. The 470K(!) output of

Code:

make -j2 > header.warns 2>&1

is up here at https://pastebin.com/4GueCXWU
As you see, it's mainly 'deprecated type warnings and I get them from the linux headers too. Now people pat me on the head and say "Oh that's OK - they're only warnings." I'm not convinced, because a programmer who uses gtk-2.x syntax in a gtk-3.x file is cruising for a bruising. And headers are lookup tables, basically. When all that stuff has to get changed, the potential for error is huge.

I'm getting 100% crashes from geeqie. It IS NOT working. Hence the question.

EDIT: Using 'grep -c' I get 1598 uses of 'deprecated' and 589 uses of 'declared.' Did somebody not do their homework?

EdGr · 04-17-2021, 10:09 AM

Unfortunately, the flood of GTK 3 deprecation warnings is normal.

GTK 3 deprecated large parts of its API that the developers consider "legacy" (i.e. superseded by newer widgets that GNOME uses). The deprecated API calls still work in GTK 3 but are removed entirely in GTK 4.

You can prevent warnings about real problems from being lost in the noise by defining GDK_DISABLE_DEPRECATION_WARNINGS.
Ed

business_kid · 04-17-2021, 10:15 AM

Quote:

Originally Posted by EdGr

Unfortunately, the flood of GTK 3 deprecation warnings is normal.

GTK 3 deprecated large parts of its API that the developers consider "legacy" (i.e. superseded by newer widgets that GNOME uses). The deprecated API calls still work in GTK 3 but are removed entirely in GTK 4.

You can prevent warnings about real problems from being lost in the noise by defining GDK_DISABLE_DEPRECATION_WARNINGS.
Ed

Great. Is that

Code:

GDK_DISABLE_DEPRECATION_WARNINGS=true
make

or does it go in the configure?

EdGr · 04-17-2021, 10:21 AM

It should go in the configure.

Code:

CFLAGS="-DGDK_DISABLE_DEPRECATION_WARNINGS=1"

or

Code:

CXXFLAGS="-DGDK_DISABLE_DEPRECATION_WARNINGS=1"

Ed

business_kid · 04-17-2021, 11:29 AM

Quote:

Originally Posted by EdGr

Unfortunately, the flood of GTK 3 deprecation warnings is normal.

GTK 3 deprecated large parts of its API that the developers consider "legacy" (i.e. superseded by newer widgets that GNOME uses). The deprecated API calls still work in GTK 3 but are removed entirely in GTK 4.

You can prevent warnings about real problems from being lost in the noise by defining GDK_DISABLE_DEPRECATION_WARNINGS.
Ed

Great. Is that

Code:

GDK_DISABLE_DEPRECATION_WARNINGS=true
make

or does it go in the configure?

EDIT: it apparently gets configured in glib.h. Which glib.h is confusing

Quote:

bash-5.1$ locate glib.h
/usr/include/jpeglib.h
/usr/include/dbus-1.0/dbus/dbus-glib.h
/usr/include/glib-1.2/glib.h
/usr/include/glib-2.0/glib.h
/usr/include/harfbuzz/hb-glib.h
/usr/include/json-glib-1.0/json-glib/json-glib.h
/usr/include/libdbusmenu-glib-0.4/libdbusmenu-glib/dbusmenu-glib.h
/usr/include/libical-glib/libical-glib.h
/usr/include/libmbim-glib/libmbim-glib.h
/usr/include/libmm-glib/libmm-glib.h
/usr/include/libqmi-glib/libqmi-glib.h
/usr/include/palemoon-29.0.1/jpeglib.h
/usr/include/palemoon-29.0.1/harfbuzz/hb-glib.h
/usr/include/pygtk-2.0/pyglib.h
/usr/include/reglib/reglib.h
/usr/include/taglib/taglib.h
/usr/share/gtk-doc/html/glib/glib.html
/usr/share/gtk-doc/html/harfbuzz/harfbuzz-hb-glib.html
/usr/src/linux-5.10.15/include/config/blk/dev/bsglib.h

Now which glib.h is it in? Or do I have to define it myself?

EdGr · 04-17-2021, 11:37 AM

Quote:

Originally Posted by business_kid

Now which glib.h is it in? Or do I have to define it myself?

You define GDK_DISABLE_DEPRECATION_WARNINGS yourself in the CFLAGS or CXXFLAGS when you configure Geeqie. You should not change the system headers.

The Geeqie crash indicates a real bug. Turning off the GTK 3 deprecation warnings may help you find it.
Ed

business_kid · 04-18-2021, 06:52 AM

OK, I set CFLAGS & CXXFLAGS as GDK_DISABLE_DEPRECATION_WARNINGS, and rebuilt the Slackware source from scratch. It didn't kill the log spam. The entire left panel is an un-adjustable mess, and I can't use keyboard shortcuts or resize anything in the left panel. Geeqie is now on a par with mirage here. All the sophistication is gone.

EdGr · 04-18-2021, 07:44 AM

I rebuilt Geeqie-1.6 with:

Code:

CFLAGS="$SLKCFLAGS -DGDK_DISABLE_DEPRECATION_WARNINGS=1" \
CXXFLAGS="$SLKCFLAGS -DGDK_DISABLE_DEPRECATION_WARNINGS=1" \
./configure \
  --prefix=/usr \
  --sysconfdir=/etc \
  --localstatedir=/var \
  --mandir=/usr/man \
  --with-readmedir=/usr/doc/geeqie-$VERSION \
  --with-htmldir=/usr/doc/geeqie-$VERSION/html \
  --program-prefix="" \
  --program-suffix="" \
  --build=$ARCH-slackware-linux || exit 1

That turned off the GTK 3 deprecation warnings. There are still a few warnings from other libraries.

Geeqie-1.6 came up with the panes in poor positions. Adjusting the panes made Geeqie usable. It did not crash for me at least in brief use (I don't use Geeqie).

ETA: Try removing ~/.config/geeqie to see if that fixes the crash.
Ed

business_kid · 04-18-2021, 10:34 AM

It is an absolute piece of <expletive>.

Compiled your way and the warnings went. I was missing the '-D' bit, but the CFLAGS are switches to gcc.

geeqie -r pukes. Plain geeqie works on the same or lower level as Mirage. No left panel adjustment. If someone handed that up as a CS project, he'd fail.