Compiling code against gtk+2 or gtk+3 causes gcc-8.1.1 to spew warnings about the use of unnecessary parentheses, because it now adopts the -Wparentheses flag by default.

gtk+-3.23.0 has modified the three affected header files to deal with this. It is a pain to compile any gtk+-using program on slackware by having to set CFLAGS/CXXFLAGS to pass the -Wno-parentheses option, and I wonder if the slackware could apply the attached patches to avoid this?

I have found the affected headers by grepping and I think I have picked up everything (errors and omissions excepted). The fix relies on the size of an object pointer being the same as the size of a function pointer, which is true of any POSIX system (ie slackware) and windows, and presumably of any OS which can run GTK+ given that gtk+-3.23.0 is not supposed to break GTK+3 ABI and does the same.

Attached Files

	gtk+-2.24.32-parentheses.txt (1.8 KB, 23 views)
	gtk+-3.22.30-parentheses.txt (1.6 KB, 20 views)

I built several GTK+ 2 and 3 apps here and did not notice warnings related to -Wparentheses. I also looked at GTK+ packages in other distributions shipping gcc8 and did not find that they'd patched their headers.

I think that unless it's causing build failures, the place to request fixes for gcc8 warnings is upstream, not here.