[SOLVED] -z check is not working :(:(

sysmicuser · 02-26-2012, 03:51 AM

Hi,

I am trying this.
if [[ -z "${RELEASE}" ]]; then
echo "RELEASE value not supplied";
exit 1
fi

a very small and simple piece of code but while executing it doesn't do echo but says exit 1

where is the mistake???

corp769 · 02-26-2012, 03:55 AM

Could we kindly see all of the code so we can get the feel what you are exactly trying to do? And also, what shell are you using? One last thing I can tell is that it should be $() instead of ${}.

Edit - Nevermind on the last part..... Still waking up.....

druuna · 02-26-2012, 03:57 AM

Hi,

Not sure how you actually tried, but this works like a charm:

Code:

#!/bin/bash

if [[ -z "${RELEASE}" ]]
then
  echo "RELEASE value not supplied"
  exit 1
fi

echo "RELEASE is supplied"

exit 0

Test run:

Code:

$ chmod 750 tst.sh
$ ./tst.sh
RELEASE value not supplied
$

Please elaborate on your problem.

sysmicuser · 02-26-2012, 04:01 AM

@drunna thanks for that, I shall try but I want to make my understanding very clear about my code is not working

@corp769 here is full code.
#!/bin/ksh

set -x
. /app/scm/dropzone/$RELEASE/release_record.sh

#echo $CI
#echo $ENVID
#echo $CCB_ENVNAME

if [[ -z "${RELEASE}" ]]; then
echo "RELEASE value not supplied"
exit 1
fi

if [[ -z ${CI} ]];then
exit 1
fi

if [[ -z ${CCB_ENVNAME} ]]; then
exit 1
fi

export TAR_FILENAME=$CCB_ENVNAME_PRE_$RELEASE_`hostname`.tar.gz

if [[ -f ${TAR_FILENAME} ]] ; then
echo "App tar ball exist please check backup directory"
fi

# ***************************************************************
# * *
# * Create Tarball file and put it in the backup directory *
# * *
# ***************************************************************
date
tar cvf - /app/ccb/$ENV_NAME | gzip > /app/scm/dropzone/Backups/ccb/$CI/$TAR_FILENAME
if [[ $? -ne 0 ]];then
exit 1
fi

sysmicuser · 02-26-2012, 04:03 AM

all what I want to do is check arguments like release,ci envid if they are not supplied build should fail with meaningfull message if these are present then it should check if that.tar.gz file is present(if present build should fail) if not it should proceed with doing tar of entire directory.

Cheers

corp769 · 02-26-2012, 04:06 AM

Well just like druuna, works for me too. Noticed you are using ksh though... Have you tried using a different shell though, like bash, just to rule it out?

druuna · 02-26-2012, 04:07 AM

Hi again,

If I run your posted code (post #4), it does what it is supposed to (I had to comment out the . /app/scm/dropzone/$RELEASE/release_record.sh part):

Code:

$ ./tst.sh
+ [[ -z '' ]]
+ echo 'RELEASE value not supplied'
RELEASE value not supplied
+ exit 1

You do realize that all the entries that are prepended with + are there because of the set -x statement in the script?

corp769 · 02-26-2012, 04:13 AM

Druuna beat me to it, as I was replying to another thread.... I noticed that as well, and that was the first thing that popped up in my head. Just like he said, are you getting " + exit 1" in your terminal?

sysmicuser · 02-26-2012, 04:22 AM

corp769 and drunna

First of all thank you for your support.

yes I am aware of "+ exit 1" output which I am getting because trace is ON that is set -x.

I am not sure what shell plays the role but same code but if I change /ksh value to /bash there is an interesting observation.
Output changes from just + exit 1 to
{code}
+ [[ -z 1.9.0.6.6.12 ]]
+ [[ -z '' ]]
+ exit 1
{code}

Yes it is doing what is supposed to meaning, build fails but I am not sure of two statements.

echo "RELEASE value not supplied"
exit 1

why it just does exit 1, it should display some meaning message as well?

sysmicuser · 02-26-2012, 04:26 AM

One more thing if I change from {} to ()
so
if [[ -z "$(RELEASE)" ]]; then
echo "RELEASE value not supplied"
exit 1
fi

it gives output as

line 10: RELEASE: command not found
+ [[ -z '' ]]
+ echo 'RELEASE value not supplied'
RELEASE value not supplied
+ exit 1

Now why the heck it is looking for RELEASE as command? it is displaying meaning output though which is good.

corp769 · 02-26-2012, 04:28 AM

Read my edit in that post, I said to nevermind that.... When I wrote that, I was still waking up, and apparently my brain thought that you were trying to execute that variable for some reason. My bad!

Just curious... What distro, and version of both bash and ksh are you using?

druuna · 02-26-2012, 04:40 AM

Hi,

Your code does have some strangeness:

You first parse a file which contains the $RELEASE variable (this line: . /app/scm/dropzone/$RELEASE/release_record.sh), after that is done you check for the existence of $RELEASE. If $RELEASE isn't set, the parsing part will give an error message and the script will exit at that point. No need to check for $RELEASE after the fact......

What happens if you give the following a try:

Code:

#!/bin/ksh

set -x

if [[ -z "${RELEASE}" ]]
then
  echo "RELEASE value not supplied"
  exit 1
fi

. /app/scm/dropzone/$RELEASE/release_record.sh

#echo $CI
#echo $ENVID
#echo $CCB_ENVNAME

if [[ -z "${CI}" ]]
then
  echo "CI value not supplied"
  exit 1
fi

if [[ -z "${CCB_ENVNAME}" ]]
then
  echo "CCB_ENVNAME value not supplied"
  exit 1
fi

export TAR_FILENAME="$CCB_ENVNAME_PRE_$RELEASE_`hostname`.tar.gz"

if [[ -f "${TAR_FILENAME}" ]]
then
  echo "App tar ball exist please check backup directory"
  exit 1
fi

echo "All is well"
exit 0

BTW: Do provide the info corp769 asked for. Also include the output of the following command:

Code:

file <name_of_script>

sysmicuser · 02-26-2012, 05:00 AM

drunna I agree with you, that is completely incorrect logic.
First I am parsing file to read it and source release variables and then checking for RELEASe value ! not good programming mate

we are using redhat os.
bash on source (build)server is
GNU bash, version 3.2.25(1)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2005 Free Software Foundation, Inc.
version sh (AT&T Research) 93s+ 2008-01-31
Red Hat Enterprise Linux Server release 5.3 (Tikanga)

on target server
I can tell easily bash version
GNU bash, version 3.00.15(1)-release (x86_64-redhat-linux-gnu)
Copyright (C) 2004 Free Software Foundation, Inc.

I am unable to tell ksh version as that is what I am unable to determine.

OS
Red Hat Enterprise Linux AS release 4 (Nahant Update 7)

corp769 · 02-26-2012, 05:01 AM

I do recommend upgrading to the latest and greatest, if you can. Are you a subscribed user? I say that because me and druuna aren't having problems with this...

sysmicuser · 02-26-2012, 05:03 AM

@drunna

file tar_ball.sh
tar_ball.sh: Korn shell script text executable
file ccb_create_tarball.sh
ccb_create_tarball.sh: Bourne-Again shell script text executable

---------- Post added 02-26-12 at 10:04 PM ----------

@corp769 u mean bash and kron shell version?