Why is this shell script not working?

astrogeek · 06-05-2019, 12:53 PM

Quote:

Originally Posted by riahc3

I dont know anything about shell scripting so I do not know what is wrong/right.
...
This is what I am asking. What errors are there?

So, in effect you have pasted whole cloth code presumably written by someone else, and you are asking others to understand it and debug it for you with little effort on your part and without gaining any understanding of it yourself?

That is not how LQ Programming forum should work. The forum is more about sharing knowledge than simply fixing code.

You have been given some excellent pointers by others, but you are going to have to understand how to use that knowledge, and how your script should work, and do your own debugging based on that new understanding.

Again, please review the Site FAQ for guidance in posting your questions and general forum usage. Especially, read the link in that page, How To Ask Questions The Smart Way. The more effort you put into understanding your problem and framing your questions, the better others can help!

While others are always willing to go to some lenghts to help you learn and to resolve your problems, if you are waiting for others to simply do it for you, you may be asking in the wrong place.

dc.901 · 06-05-2019, 01:25 PM

Quote:

Originally Posted by riahc3

Then I do not understand your posts. Im asking if there is anything wrong written in the script.

Technically, everything in the script that does not apply to your systems is wrong...

You have said your self that when you run it manually it works, so when does it not work as expected?
And what are the exact error(s)?

rnturn · 06-05-2019, 01:34 PM

Quote:

Originally Posted by BW-userx

I'd suppose you'd have to change your system time date to test it as well, yes?

That's too easy.

Code:

DOW=$( date +'%w' )
DOW=1              # Test the Monday code

Change the if statements to reference $DOW.

rnturn · 06-05-2019, 01:55 PM

Quote:

That's a misapprehension I see often: no, a #! is ONLY needed when you want a specific shell (or application) to run it.

The shebang is also needed if you want file(1) to be able to tell you that it's something other than "ASCII text". Why omit it?

BW-userx · 06-05-2019, 02:36 PM

Quote:

Originally Posted by rnturn

That's too easy.

Code:

DOW=$( date +'%w' )
DOW=1              # Test the Monday code

Change the if statements to reference $DOW.

well happy is me, someone is thinking out of the box, as I wasn't going to put every way to test.. still that does not change it for me, I still could not test it because why? and for such a detailed script and not knowing how to test it.. well again I am not really wanting to type every little detail about this script and everything on it ... so yeah.. you figure that part out too. cheers!!

ehartman · 06-05-2019, 04:35 PM

Quote:

Originally Posted by rnturn

The shebang is also needed if you want file(1) to be able to tell you that it's something other than "ASCII text".

That has already been done by setting the eXecutable bit on it:

Code:

cat script
echo This is a 1-line script
 $ file script
script: ASCII text executable

In fact most of my scripts DO have a shebang, but of #!/bin/sh, to tell that it
does not use any bash-specific features.

rnturn · 06-05-2019, 06:53 PM

Quote:

Originally Posted by ehartman

That has already been done by setting the eXecutable bit on it:

Code:

cat script
echo This is a 1-line script
 $ file script
script: ASCII text executable

In fact most of my scripts DO have a shebang, but of #!/bin/sh, to tell that it
does not use any bash-specific features.

Interesting... When I place 'code' into a file w/o a shebang line it is identified as "ASCII text".

If I make it executable ("chmod u+x ...") file(1) identifies it as... "ASCII text".

[scratching my head now]

Shadow_7 · 06-05-2019, 09:34 PM

In debian, if you do not override the default when you create your user, it will run whatever /bin/sh points at as your shell. It might look like bash, it might act like bash, but it might not BE bash. I rather like the bash extras to tell how many characters are in a string, and to extract a, or a set of, character(s) at a particular position. A lot of which doesn't work in dash.

$ ls -l $(which sh)

Code:

lrwxrwxrwx 1 root root 4 Jan 23  2017 /bin/sh -> dash

riahc3 · 06-07-2019, 03:34 AM

Quote:

Originally Posted by pan64

shellcheck was mentioned several times to you. Why don't you give it a try? You don't need to wait for everyone, it will give you the answer immediately. And you will see the errors.

come back if you fixed all the errors reported by shellcheck - or if you have problem fixing any of them.

shellcheck isnt giving me any error that is wrong with the script; The script runs.

riahc3 · 06-07-2019, 03:35 AM

Quote:

Originally Posted by Shadow_7

Also no #! at the top of the script. If you're running it ./, then it wont know what shell to use. And systems default to different shells. Like debian defaults to dash, bsd to tch?, and other quirks.

Yup, forgot about that one. It defaulted to the default share and worked but I forgot it is needed.

Quote:

Originally Posted by Shadow_7

Also, if you "require" external programs, why not check for them in the script instead of being lazy and having a comment that it is required?

Code:

if [[ ! $(which ipmi) ]]; then
  echo "ipmi NOT detected"
  exit 1
fi

You summed it up: Laziness

riahc3 · 06-07-2019, 03:36 AM

Quote:

Originally Posted by BW-userx

I can tell you yes, it looks fine and dandy to me

Thats all I needed. Thanks

riahc3 · 06-07-2019, 03:40 AM

Quote:

Originally Posted by dc.901

You have said your self that when you run it manually it works, so when does it not work as expected?
And what are the exact error(s)?

The only other thing I suspect is the crontab but:

*/5 * * * * /bin/bash /root/scripts/r710fanscript.sh >/dev/null 2>&1

michaelk · 06-07-2019, 05:22 AM

I agree with astrogeek's post.

You still have not posted where your script is failing.

Program syntax is correct but you have not paid attention to the note about octal numbers.

dc.901 · 06-07-2019, 05:46 AM

Quote:

Originally Posted by riahc3

The only other thing I suspect is the crontab but:

*/5 * * * * /bin/bash /root/scripts/r710fanscript.sh >/dev/null 2>&1

The way I troubleshoot why a script is not running via cron is change /dev/null to a file; for example:

Code:

*/5 * * * * /bin/bash /root/scripts/r710fanscript.sh >>/tmp/r710fanscript.out 2>&1

Then, review the file /tmp/r710fanscript.out after the job runs to determine what's happening; in this case looks like you want to run every 5-minutes.
This will help fix any errors. After all issues are resolved, change the crontab entry back to /dev/null...