[SOLVED] Question 2

BW-userx · 02-25-2016, 02:15 PM

Quote:

Originally Posted by suicidaleggroll

I recommend looking up a beginner's bash scripting guide. You have a lot of fundamental problems and inconsistencies with your syntax in this small block of code, such as:
1) Variable assignments must not have any spaces around the equal sign
2) Tests, such as 'if [[ "$var1 = "blah" ]]', MUST have spaces around the equal sign
3) Capturing the output of a command is done with $() or ``, you can't just say "var1=program", or it will set the variable "var1" to the string "program", rather than running the program and saving the output
4) Variable assignment is not done with "let"

You should also be posting your code in [code][/code] brackets to preserve formatting, such as indentation and white space.

He has already been advised about 97% of what you just advised him of, (yet again). Don't hold your breath on this one.

kernkraftx · 02-25-2016, 02:15 PM

... ya thanks for the encouragement

.

BW-userx · 02-25-2016, 02:20 PM

Quote:

Originally Posted by grail

Well my questions is ... how did this change from awk to bash all of a sudden? ... Talk about not paying attention

Espically after I explicitly gave him instructions on where to post his BASH.

Where are the results of your first homework assignment? Post them please in your orginal post for said homework.

Job Review:
Lacks focus and fails to follow instructions

kernkraftx · 02-25-2016, 02:26 PM

ya easier to criticize.

BW-userx · 02-25-2016, 02:34 PM

Quote:

Originally Posted by kernkraftx

ya easier to criticize.

Quote:

Constructive criticism is the process of offering valid and well-reasoned opinions about the work of others, usually involving both positive and negative comments, in a friendly manner rather than an oppositional one. The purpose of 'constructive criticism is to improve the outcome.

Please now demonstrate some improvements

kernkraftx · 02-26-2016, 11:28 AM

ok then, I'll be back some with some good stuff.

kernkraftx · 02-26-2016, 11:59 AM

#!/bin/bash
#
#
#
clear
divZero="vrai"
sortie="faux"
while [ "$sortie" = "faux" ]
do
printf "%sEntrer un nombre entier\nEntrer "q" pour stopper\n"
read valeur
if ! [[ "$valeur" =~ ^[0-9]+$ ]] && ! [[ "$valeur" =~ "q" ]] ;
then
exec >&2; echo "Pas un nombre"
else
if [ "$valeur" = "q" ]
then
if [ "$divZero" = "vrai" ]
then
clear
printf "%sEntrer au moins un entier!\n"
else
let sortie="vrai"
fi
else
echo "$valeur" >> temp.tmp
divZero="faux"
clear
fi
fi
done
awk -f calcul.awk temp.tmp
rm temp.tmp

awk

#!/bin/awk -f
BEGIN{somme=0
nombre=0
moyenne=0
}
{
somme=somme+$1
nombre++
}
END{
moyenne=somme/nombre
printf"Somme= %12.2f\n",somme
printf"Moyenne= %10.2f\n",moyenne
}

no more bashing me please....

hydrurga · 02-26-2016, 12:01 PM

Does it work? If not, how not?

grail · 02-26-2016, 12:03 PM

You still have not followed the first instruction you have received in nearly every post ... USE CODE TAGS.

Irrelevant of the fact that we all have to translate your code so we can understand what you are trying to do, without it being readable no one is going to help you.

kernkraftx · 02-26-2016, 12:09 PM

but it works dude....

BW-userx · 02-26-2016, 12:42 PM

Quote:

Originally Posted by grail

You still have not followed the first instruction you have received in nearly every post ... USE CODE TAGS.

Irrelevant of the fact that we all have to translate your code so we can understand what you are trying to do, without it being readable no one is going to help you.

too bad you cannot increase the font size to something like 100pts, in red letters.

let me try

If you have a script to speak about please post it between code tags:

[code]here comes your script[/code]

just to keep original formatting.

nope, thats it.

BW-userx · 02-26-2016, 01:04 PM

my output from your scripts

NOTICE HOW I PALCE IT BETWEEN [quote] quote tags [/quote] to make it look more better

Quote:

12:57 PM ~/testing$ ./oopsfrench

Entrer un nombre entier
Entrer q pour stopper
43566666

Entrer un nombre entier
Entrer q pour stopper
q
Somme= 43566666.00
Moyenne= 43566666.00
01:03 PM ~/testing$