Shell scripts issue

catkin · 11-30-2009, 01:48 AM

Quote:

Originally Posted by balakrishnay

Tried executing this code but it giving me error ..

testinst1.koel.co.in/apps12i]./check.sh
enter how many files
1
enter file
bala.txt
./check.sh: line 12: syntax error near unexpected token `done'
./check.sh: line 12: `done <<< $( find . -type f -name "$name" )'

Unbalanced if-fi and do-done. Easier to find problem if use indentation. Here is untested correction

Code:

echo " enter how many files "
read no
echo " enter file "
read name
if [ $no = 1 ] ; then
   while read FILE
    do
        if [[ "$FILE" == '' ]]; then
            echo "$name not found"
        else
            echo "$FILE found"
        fi
    done <<< $( find . -type f -name "$name" )
elif [ no -gt 1 ] ; then
    for j in {1..$no}
    do
       echo " enter file names "
       read name
       fn="-o -name $name"
       while read FILE
       do
           if [[ "$FILE" == '' ]]; then
               echo "$name not found"
           exit 1
           else
               echo "$FILE found"
           fi
       done <<< $( find . -type f -name "$name" $fn )
    done
fi
#fi

But it would be easier for the user and the code if you simply looped until the user entered an empty line.

Code:

while true
do
    echo " enter file name (or no name to finish)"
    read name
    [[ "$name" == '' ]] && \exit 0
    while read filepath
    do
        if [[ "$filepath" == '' ]]; then
            echo "$name not found"
        else
            echo "$filepath found"
        fi
    done <<< $( find . -type f -name "$name" )
done

balakrishnay · 12-01-2009, 04:22 AM

Hi Catkin,

Is this possible to read more than one file at a time .. instead of reading one file at a time in this code ..

Code:

while true
do
    echo " enter file name (or no name to finish)"
    read name
    [[ "$name" == '' ]] && \exit 0
    while read filepath
    do
        if [[ "$filepath" == '' ]]; then
            echo "$name not found"
        else
            echo "$filepath found"
        fi
    done <<< $( find . -type f -name "$name" )
done

Regards

Bala

Quote:

Originally Posted by catkin

Unbalanced if-fi and do-done. Easier to find problem if use indentation. Here is untested correction

Code:

echo " enter how many files "
read no
echo " enter file "
read name
if [ $no = 1 ] ; then
   while read FILE
    do
        if [[ "$FILE" == '' ]]; then
            echo "$name not found"
        else
            echo "$FILE found"
        fi
    done <<< $( find . -type f -name "$name" )
elif [ no -gt 1 ] ; then
    for j in {1..$no}
    do
       echo " enter file names "
       read name
       fn="-o -name $name"
       while read FILE
       do
           if [[ "$FILE" == '' ]]; then
               echo "$name not found"
           exit 1
           else
               echo "$FILE found"
           fi
       done <<< $( find . -type f -name "$name" $fn )
    done
fi
#fi

But it would be easier for the user and the code if you simply looped until the user entered an empty line.

Code:

while true
do
    echo " enter file name (or no name to finish)"
    read name
    [[ "$name" == '' ]] && \exit 0
    while read filepath
    do
        if [[ "$filepath" == '' ]]; then
            echo "$name not found"
        else
            echo "$filepath found"
        fi
    done <<< $( find . -type f -name "$name" )
done

catkin · 12-01-2009, 10:16 AM

Don't understand what you want. The code reads a file name each time, not a file.

balakrishnay · 12-01-2009, 09:33 PM

I am sorry catkin,

Yes the same code should read more than one file name at one time ..

Regards

Quote:

Originally Posted by catkin

Don't understand what you want. The code reads a file name each time, not a file.

catkin · 12-02-2009, 01:02 AM

Quote:

Originally Posted by balakrishnay

I am sorry catkin,

Yes the same code should read more than one file name at one time ..

Regards

OK. Where from? From command line, user input or find command?

balakrishnay · 12-02-2009, 02:20 AM

From the user input and the same has to be passed to find command dynamically .

I will explain to you in detail.

Initially i will ask the user how many files does he need to find . for Ex:- user enters 2 then we should allow him to enter 2 file names .This shell script should find these 2 files along with the path.

Like this .. the user might enter any no of files to find .....

I have tried manually to find multiple files using find command it worked but i have problem taking file names dynamically.

Manually we can find like this ..

find /apps12i -type f -name filename1 -o -name filename2

Thank you !!

Quote:

Originally Posted by catkin

OK. Where from? From command line, user input or find command?