LinuxQuestions.org
Help answer threads with 0 replies.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 04-08-2017, 07:16 AM   #1
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Rep: Reputation: 23
vim-7.4.050 in Slackware 14.1 uses broken Blowfish encryption


Hi,

Current version of vim available in Slackware 14.1 is 7.4.050. This version uses broken implementation of Blowfish encryption algorithm. This has been known for some time. This bug is fixed in vim-7.4.399, but it's not available in Slackware 14.1.

I was wondering: is it reasonable to make a request for updating vim in Slackware 14.1 to the version where encryption is fixed? That would be just a micro version update. How do I make this kind of request? Do we have some kind of process for it?
 
Old 04-08-2017, 07:36 AM   #2
Didier Spaier
LQ Addict
 
Registered: Nov 2008
Location: Paris, France
Distribution: Slint64-15.0
Posts: 11,063

Rep: Reputation: Disabled
Hi,

Quote:
Originally Posted by arcctgx View Post
How do I make this kind of request?
You just did it.
 
Old 04-08-2017, 01:46 PM   #3
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Original Poster
Rep: Reputation: 23
Initially I thought I'll just build a more recent version from source. But it's not exactly user friendly... I was surprised to see that one has to manually apply hundreds of patches to get to the latest patchlevel from 7.4 branch.

So I thought that maybe it would be worthwile to update the package in the distribution, since Slackware 14.1 is still supported. Especially that it would address a well known issue.
 
Old 04-08-2017, 02:30 PM   #4
speck
Member
 
Registered: Nov 2001
Location: US
Distribution: Slackware 14.2
Posts: 375

Rep: Reputation: 115Reputation: 115
You could try building the vim and gvim source from 14.2, or from Current if you don't mind moving up to version 8.
 
Old 04-08-2017, 02:34 PM   #5
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: West Jordan, UT, USA
Distribution: Slackware
Posts: 8,792

Rep: Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656
Quote:
Originally Posted by arcctgx View Post
Initially I thought I'll just build a more recent version from source. But it's not exactly user friendly... I was surprised to see that one has to manually apply hundreds of patches to get to the latest patchlevel from 7.4 branch.
You can just grab the tarball from github for that release.

Code:
wget https://github.com/vim/vim/archive/v7.4.399/vim-7.4.399.tar.gz
For the 7.4 branch, they have up to the 2367 patchlevel.

Code:
wget https://github.com/vim/vim/archive/v7.4.2367/vim-7.4.2367.tar.gz
But that is not a very friendly release style. Looks like pretty much every commit is turned into a release. I feel sorry for people who need to keep up with it.
 
Old 04-08-2017, 03:49 PM   #6
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Original Poster
Rep: Reputation: 23
Quote:
Originally Posted by bassmadrigal View Post
Code:
wget https://github.com/vim/vim/archive/v7.4.2367/vim-7.4.2367.tar.gz
That's a good tip. How did you find that download link? I was looking at the github page of vim before I posted, but I couldn't find it there.
 
Old 04-08-2017, 05:06 PM   #7
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: West Jordan, UT, USA
Distribution: Slackware
Posts: 8,792

Rep: Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656
There is a "releases" tab on github if you're on the main page. Once I went in there, I started browsing through their releases, but that was a fruitless endeavor, due to how many frickin releases they had. So I then checked your initial post which stated they fixed it in the .399 patch release, and I tried typing that in, which worked. I then checked their patches directory to find their highest patch for the 7.4 series and then plugged that into github, which is what I linked to.

The following is mostly unimportant, but if you download github releases frequently, it might be helpful to learn.

That actually isn't the exact link provided by github, but if you use their link (https://github.com/vim/vim/archive/v7.4.2367.tar.gz), you can get different names depending on whether you use a downloader that supports content disposition. Most (all?) browsers do, but wget, without flags, won't. If you download something that supports content disposition, it will take that link and provide you with vim-7.4.2367.tar.gz, but if you use something that doesn't support content disposition, it will use the exact name from the server, in this case, v7.4.2367.tar.gz. So, github provides a fancy way to change the name of the download by adding your own filename after the version. In this case, we want to add the program name and the version, keeping tar.gz at the end.

So, we're taking the following and adding the bit in red to make the filename end up with vim-7.4.2367.tar.gz.
https://github.com/vim/vim/archive/v7.4.2367.tar.gz
https://github.com/vim/vim/archive/v7.4.2367/vim-7.4.2367.tar.gz

It should be noted that basically, git will use the repo name and the version (removing an v from before it) for the folder name of the tarball. Basically, if your github release is formatted like: https://github.com/user/repo/v1.2.3, the folder will be called repo-1.2.3/, no matter what filename you put at the end. So, if you put https://github.com/user/repo/v1.2.3/repo-custom-1.2.3.4.tar.gz, the file will be called repo-custom-1.2.3.4.tar.gz, but when you extract it, the folder will just be repo-1.2.3/.

If you end up creating a SlackBuild for SBo based on a github release, the above information can help prevent some error reports from users who may or may not being using a downloader with content disposition. It's caught me before on a few of the SlackBuilds I maintain.

Last edited by bassmadrigal; 04-08-2017 at 05:10 PM. Reason: Fixed formatting issues...
 
5 members found this post helpful.
Old 04-08-2017, 05:45 PM   #8
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Original Poster
Rep: Reputation: 23
Quote:
Originally Posted by bassmadrigal View Post
The following is mostly unimportant, but if you download github releases frequently, it might be helpful to learn.
This is very informative. I was wondering about these things, but never found the time to investigate the details. Thank you for putting this together.
 
Old 04-08-2017, 06:20 PM   #9
dugan
LQ Guru
 
Registered: Nov 2003
Location: Canada
Distribution: distro hopper
Posts: 11,241

Rep: Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322Reputation: 5322
To build vim 8, you just do this:

Code:
rsync -avP rsync://ftp.osuosl.org/slackware/slackware64-current/source/xap/vim-gvim/ .
cd vim-gvim
./vim.SlackBuild
./vim-gvim.SlackBuild
And then you upgradepkg to the new vim packages in /tmp.

I'm 100 percent sure that this will work on 14.1.

Last edited by dugan; 04-08-2017 at 06:21 PM.
 
Old 04-08-2017, 10:04 PM   #10
MadMaverick9
Member
 
Registered: Aug 2010
Posts: 353
Blog Entries: 4

Rep: Reputation: Disabled
Quote:
Originally Posted by bassmadrigal
... For the 7.4 branch, they have up to the 2367 patchlevel. ...
You wish. There is no 7.4 branch. Just trunk (master).

For example "patch 1274" ("7.4.1274") adds the job functionality of vim8.

7.4.2367 is really 8.0.

Quote:
Originally Posted by bassmadrigal
... But that is not a very friendly release style. Looks like pretty much every commit is turned into a release. I feel sorry for people who need to keep up with it.
vim issue - Where do we see work for v8? #900

Now compare vim's mess to python - https://github.com/python/cpython/branches/active - python has stable branches and one trunk for playing around (master).
 
Old 04-09-2017, 04:43 AM   #11
audriusk
Member
 
Registered: Mar 2011
Location: Klaipėda, Lithuania
Distribution: Slackware
Posts: 361

Rep: Reputation: 199Reputation: 199
Quote:
Originally Posted by MadMaverick9 View Post
Well, that was really disrespectful of you to approach Vim developers in such fashion, I'm not surprised by the outcome of this GitHub issue.

Try to look at this from a different perspective. Vim is a very old project that's still in development (from Wikipedia: "Bram Moolenaar began working on Vim for the Amiga computer in 1988. Moolenaar first publicly released Vim (v1.14) in 1991."). It's been maintained mostly by a single person (with help from others) for more than 25 years without any monetary reward. 25 years is a big chunk of someone's life when you think about it. So try to be more grateful to this person for his ongoing commitment to this project which you seem to care about as well.
 
Old 04-09-2017, 05:07 AM   #12
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Original Poster
Rep: Reputation: 23
Quote:
Originally Posted by MadMaverick9 View Post
That's really a peculiar way of maintaining and releasing software...
I'll skip patching 7.4 and just build version 8.0.x like dugan suggested. It appears to be the most reasonable solution.
 
Old 04-09-2017, 07:33 AM   #13
bassmadrigal
LQ Guru
 
Registered: Nov 2003
Location: West Jordan, UT, USA
Distribution: Slackware
Posts: 8,792

Rep: Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656Reputation: 6656
Quote:
Originally Posted by MadMaverick9 View Post
You wish. There is no 7.4 branch. Just trunk (master).

For example "patch 1274" ("7.4.1274") adds the job functionality of vim8.

7.4.2367 is really 8.0.


vim issue - Where do we see work for v8? #900

Now compare vim's mess to python - https://github.com/python/cpython/branches/active - python has stable branches and one trunk for playing around (master).
Geez, that makes it even worse. That's crazy that they don't keep things separate.

Quote:
Originally Posted by audriusk View Post
Well, that was really disrespectful of you to approach Vim developers in such fashion, I'm not surprised by the outcome of this GitHub issue.

Try to look at this from a different perspective. Vim is a very old project that's still in development (from Wikipedia: "Bram Moolenaar began working on Vim for the Amiga computer in 1988. Moolenaar first publicly released Vim (v1.14) in 1991."). It's been maintained mostly by a single person (with help from others) for more than 25 years without any monetary reward. 25 years is a big chunk of someone's life when you think about it. So try to be more grateful to this person for his ongoing commitment to this project which you seem to care about as well.
So, just because he's been doing it for 25 years excuses poor coding practice? Good points were brought up that it is almost impossible to distinguish between bug fixes and new (potentially buggy/harmful) additions. Not to mention there are literally 1000s of releases to try and wade through even if they did keep stable and development separate.

Personally, I don't care too much about this, because I'm not a vim user, but for someone trying to get a known stable, patched version of vim (not just rolling the dice hoping the latest commit/release fits that criteria)... good luck.
 
Old 04-09-2017, 08:24 AM   #14
audriusk
Member
 
Registered: Mar 2011
Location: Klaipėda, Lithuania
Distribution: Slackware
Posts: 361

Rep: Reputation: 199Reputation: 199
Quote:
Originally Posted by bassmadrigal View Post
So, just because he's been doing it for 25 years excuses poor coding practice? Good points were brought up that it is almost impossible to distinguish between bug fixes and new (potentially buggy/harmful) additions. Not to mention there are literally 1000s of releases to try and wade through even if they did keep stable and development separate.
No, of course anyone's free to criticize the current development model of Vim and suggest ways to make it better, I myself do think it could be better. But telling it in the way it was told ("the way you're doing things is stupid, you should be doing this instead") to someone who's doing it for free and giving his work away for free (and for so many years!) for anyone to use however they like won't be received with much enthusiasm, to say the least.

Quote:
Originally Posted by bassmadrigal View Post
Personally, I don't care too much about this, because I'm not a vim user, but for someone trying to get a known stable, patched version of vim (not just rolling the dice hoping the latest commit/release fits that criteria)... good luck.
The way I see it, it's essentially a rolling release development model, with major versions being a snapshots to indicate that some milestones have been accomplished. There, now I put a more trendy term on it.
 
Old 04-10-2017, 03:42 PM   #15
arcctgx
Member
 
Registered: Mar 2006
Location: EU
Distribution: Slackware, Gentoo
Posts: 58

Original Poster
Rep: Reputation: 23
vim-7.4.399 is now available in Slackware 14.1: ChangeLog.txt

I'm marking thread as solved. Thanks for your helpful replies.
 
1 members found this post helpful.
  


Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
Comparing encryption techniques RSA, Blowfish, etc? MrUmunhum Linux - Security 5 03-01-2017 08:34 AM
blowfish encryption algorithm mutwkil Linux - Security 2 06-17-2011 01:42 PM
Password Encryption: DES, MD5, Blowfish. swiadek Linux - Security 7 02-13-2006 04:27 PM
Password Encryption: DES, MD5, Blowfish. swiadek Linux - General 1 02-13-2006 05:25 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 08:47 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration