slackbuild matplotlib fails with NameError

cmk77 · 03-16-2020, 05:49 AM

Using Slackware 14.2 and SlackBuilds, I'm trying to build matplotlib for default python, but got the following error. Any idea what could be wrong?

Code:

============================================================================
Edit setup.cfg to change the build options

BUILDING MATPLOTLIB
            matplotlib: yes [2.2.3]
                python: yes [2.7.17 (default, Oct 20 2019, 14:16:51)  [GCC
                        5.5.0]]
              platform: yes [linux2]

REQUIRED DEPENDENCIES AND EXTENSIONS
                 numpy: yes [version 1.14.3]
Traceback (most recent call last):
  File "setup.py", line 172, in <module>
    result = package.check()
  File "/tmp/SBo/matplotlib-2.2.3/setupext.py", line 1480, in check
    print_status(package.name, req_fail_msg)
NameError: global name 'package' is not defined

ponce · 03-16-2020, 08:05 AM

I just tried it and it built fine here: the line after the numpy one in my output is

Code:

      install_requires: yes [all third-party python packages are present]

have you installed all of the dependencies listed on this page (and the dependencies of the dependencies and so on...)?
I had to install these packages to let it build

Code:

six
singledispatch
futures
python-certifi
backports-abc
tornado
kiwisolver
subprocess32
setuptools-scm
functools-lru-cache
cycler
pytz
pyparsing
python-dateutil
numpy
matplotlib

montagdude · 03-16-2020, 08:45 AM

I've had that issue with the matplotlib SlackBuild before too. For me it was fixed by commenting out this line in matplotlib.SlackBuild:

Code:

# Use modified setupext.py to make sure that the build process gets
# interrupted if requirements are not fulfilled
#
cat "${CWD}/setupext.py" > setupext.py

But please make sure you have all the dependencies installed first, because this will bypass the feature that you see in that comment. I think this is a bug in the modified setupext.py script, but my limited attempt to track it down in the past was not successful (and obviously the script must work for some people).

montagdude · 03-16-2020, 09:04 AM

Actually, I think this might fix it. Please give this change to setupext.py a try before commenting out the line in the SlackBuild mentioned previously.

Code:

--- setupext.py	2020-03-16 10:02:52.376214282 -0400
+++ setupext.py.new	2020-03-16 10:03:34.462812966 -0400
@@ -1477,7 +1477,7 @@
             req_fail_msg += (os.linesep.join(not_available) +
                             os.linesep*(2*sp_mult)) * min(1, len(not_available))
             req_fail_msg += (os.linesep*2).join(wrong_version)
-            print_status(package.name, req_fail_msg)
+            print_status(pack_name, req_fail_msg)
             raise CheckFailed("missing or faulty third-party python packages")
         return "all third-party python packages are present"

cmk77 · 03-16-2020, 10:44 AM

@ponce: not yet, I'm in dependency hell. But the script shouldn't break, it should tell me which deps I'm missing. And it actually did for numpy!

@montagdude: yes, that change fixes the problem, now I get a nice list of missing deps, next one is subprocess32.

Code:

Edit setup.cfg to change the build options

BUILDING MATPLOTLIB
            matplotlib: yes [2.2.3]
                python: yes [2.7.17 (default, Oct 20 2019, 14:16:51)  [GCC
                        5.5.0]]
              platform: yes [linux2]

REQUIRED DEPENDENCIES AND EXTENSIONS
                 numpy: yes [version 1.14.3]
          subprocess32: ERROR: At least one third-party python package is
                        missing or has the wrong version: cycler could not
                        be found pyparsing could not be found dateutil could
                        not be found pytz could not be found six could not
                        be found kiwisolver could not be found
                        backports.functools_lru_cache could not be found
                        subprocess32 could not be found

ponce · 03-16-2020, 10:51 AM

Quote:

Originally Posted by cmk77

@ponce: not yet, I'm in dependency hell. But the script shouldn't break, it should tell me which deps I'm missing. And it actually did for numpy!

I think you are using the SlackBuilds.org' scripts wrong: before installing a specific script you should install whatever is listed in the relative *.info file as "REQUIRED" (and whatever is required by what's required and so on).
you are doing twice the work that has already been done for you by the maintainer of the script: as I told you, just building the needed SlackBuilds in order (they are listed above) I had a package ready for matplotlib in no time.

montagdude · 03-16-2020, 10:58 AM

Quote:

Originally Posted by ponce

I think you are using the SlackBuilds.org' scripts wrong: before installing a specific script you should install whatever is listed in the relative *.info file as "REQUIRED" (and whatever is required by what's required and so on).
you are doing twice the work that has already been done for you by the maintainer of the script: as I told you, just building the needed SlackBuilds in order (they are listed above) I had a package ready for matplotlib in no time.

But the point remains that the custom setupext.py has a bug and isn't doing what it is intended to do. Rather than failing with a NameError, it should report the missing package and exit gracefully.

ponce · 03-16-2020, 12:27 PM

Quote:

Originally Posted by montagdude

But the point remains that the custom setupext.py has a bug and isn't doing what it is intended to do. Rather than failing with a NameError, it should report the missing package and exit gracefully.

if you think so report this to the matplotlib maintainer, maybe he will explain why he used this instead of the stock one (but a partial explaination seems to be also in the comment from the SlackBuild you quoted above).

montagdude · 03-16-2020, 12:49 PM

Quote:

Originally Posted by ponce

if you think so report this to the matplotlib maintainer, maybe he will explain why he used this instead of the stock one (but a partial explaination seems to be also in the comment from the SlackBuild you quoted above).

I plan to when I get the opportunity. But maybe cmk77 can confirm, does the script still stop due to missing dependencies after the fix from post #4 is applied? I find it unlikely that the maintainer purposely put in a nonexistent variable name ("package") to make the script crash with an unhelpful (to the user) error message when a dependency is missing.

cmk77 · 03-17-2020, 04:59 AM

Yes, after the fix from post #4 the script points the user to the missing dependency and stops gracefully.

cmk77 · 03-17-2020, 05:05 AM

@ponce: yes, I'm doing this the wrong way. Matplotlib has 10 deps, some of which have other deps, slackbuilding it all in the right order will take time.

montagdude · 03-17-2020, 06:07 AM

Quote:

Originally Posted by cmk77

@ponce: yes, I'm doing this the wrong way. Matplotlib has 10 deps, some of which have other deps, slackbuilding it all in the right order will take time.

Why not use sbopkg/sbotools/sboui?