[SOLVED] regression on -current with mozilla-firefox and mozilla-thunderbird

nobodino · 12-13-2021, 12:36 AM

mozilla-firefox doesn't build anymore on -current:
-----------------------------

Code:

34:01.98 >>>               /tmp/firefox-91.4.0/obj/toolkit/library/build/../../../gfx/layers/Unified_cpp_gfx_layers1.o:(mozilla::layers::NativeLayerRootWayland::EnsureHideLayer(RefPtr<mozilla::layers::NativeLayerWayland> const&))
34:01.98 >>> referenced 85 more times
34:02.05 clang-13: error: linker command failed with exit code 1 (use -v to see invocation)
34:02.05 gmake[4]: *** [/tmp/firefox-91.4.0/config/rules.mk:545: libxul.so] Error 1
34:02.05 gmake[3]: *** [/tmp/firefox-91.4.0/config/recurse.mk:72: toolkit/library/build/target] Error 2
34:02.05 gmake[2]: *** [/tmp/firefox-91.4.0/config/recurse.mk:34: compile] Error 2
34:02.05 gmake[1]: *** [/tmp/firefox-91.4.0/config/rules.mk:355: default] Error 2
34:02.05 gmake: *** [client.mk:65: build] Error 2
34:02.07 161 compiler warnings present.
34:02.57 Failed to parse ccache stats output: Summary:
34:02.58 /usr/bin/notify-send --app-name=Mozilla Build System Mozilla Build System Build failed

-----------------------------
maybe the new rust (as usual).

With no surprise, mozilla-thunderbird is affected the same way.

marav · 12-13-2021, 03:44 AM

Quote:

Originally Posted by nobodino

mozilla-firefox doesn't build anymore on -current:

maybe the new rust (as usual).

With no surprise, mozilla-thunderbird is affected the same way.

Our firefox ESR is build with rust 1.54

about:buildconfig

Code:

...
/usr/bin/rustc 	1.54.0 	-Cdebuginfo=0

Code:

Fri Nov  5 22:49:19 UTC 2021
xap/mozilla-firefox-91.3.0esr-x86_64-2.txz:  Rebuilt.
  Rebuilt with rust-1.54.0, which seems to produce a stable Firefox package.
  Looking at this page, it would seem that upstream is probably compiling
  the official package with rust-1.54.0:
  https://firefox-source-docs.mozilla.org/writing-rust-code/update-policy.html
  Normally I'd be inclined to drop back on the version of Rust in the main
  tree, but rust-1.56.1 fixes a security issue (one that doesn't affect any
  crates used by Firefox), so that doesn't seem to be a good idea.

nobodino · 12-13-2021, 04:51 AM

thanks for the reminder.

ponce · 12-13-2021, 05:12 AM

my bet is this being related to the wayland update, instead...
unfortunately not even firefox-96.0b4 is building ATM.

here there should be some hints about it
https://bugs.gentoo.org/811840

nobodino · 12-13-2021, 07:21 AM

I'll try with wayland-1.19.0 and see if it's the same problem.

ponce · 12-13-2021, 09:22 AM

I'm trying this (still from the gentoo patches tarball)

Code:

From d30c921928a12fccd5085888011f899ff1c788cd Mon Sep 17 00:00:00 2001
From: Jan Beich <jbeich@FreeBSD.org>
Date: Sun, 12 Dec 2021 02:16:02 +0100
Subject: [PATCH 32/32] bmo#1745560: Fix building against >=wayland-1.20

Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
---
 widget/gtk/mozwayland/mozwayland.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/widget/gtk/mozwayland/mozwayland.c b/widget/gtk/mozwayland/mozwayland.c
index 7a448e6321..b997c59d78 100644
--- a/widget/gtk/mozwayland/mozwayland.c
+++ b/widget/gtk/mozwayland/mozwayland.c
@@ -40,6 +40,13 @@ MOZ_EXPORT void wl_event_queue_destroy(struct wl_event_queue* queue) {}
 
 MOZ_EXPORT void wl_proxy_marshal(struct wl_proxy* p, uint32_t opcode, ...) {}
 
+MOZ_EXPORT struct wl_proxy* wl_proxy_marshal_flags(
+    struct wl_proxy* proxy, uint32_t opcode,
+    const struct wl_interface* interface, uint32_t version, uint32_t flags,
+    ...) {
+  return NULL;
+}
+
 MOZ_EXPORT void wl_proxy_marshal_array(struct wl_proxy* p, uint32_t opcode,
                                        union wl_argument* args) {}
 
-- 
2.34.1

I'll report back

nobodino · 12-13-2021, 09:24 AM

your bet Mr Ponce was correct, downgrading wayland to version 1.19.0 solves the problem.

Now I'll try with wayland-1.20.0 and the patch your provide.

Thanks for all your expertise.

ponce · 12-13-2021, 09:40 AM

I can confirm that the above patch fixes building against wayland-1.20.0 (most probably also for thunderbird).

nobodino · 12-13-2021, 10:16 AM

as you tested for firefox, I'll test for thunderbird.

ponce · 12-13-2021, 10:20 AM

Quote:

Originally Posted by nobodino

as you tested for firefox, I'll test for thunderbird.

I just finished building a thunderbird package too!

nobodino · 12-13-2021, 10:22 AM

a question: how long doesn't it take to build firefox on your machine, and what are its specs?
For me it takes about 1 hour.

marav · 12-13-2021, 10:25 AM

Quote:

Originally Posted by nobodino

a question: how long doesn't it take to build firefox on your machine, and what are its specs?
For me it takes about 1 hour.

both are boring
45~50min, with a ryzen 7 (8cores, 16th.)

ponce · 12-13-2021, 10:26 AM

Quote:

Originally Posted by nobodino

a question: how long doesn't it take to build firefox on your machine, and what are its specs?
For me it takes about 1 hour.

never measured precisely but less than half an hour (virtual machine with 24 cores assigned).

nobodino · 12-13-2021, 03:05 PM

Fixed in the source tree (see FTBFS.log).
Thanks to PV and Ponce.

chrisretusn · 12-14-2021, 12:50 AM

Tested this patch with Firefox 95.0, works. Prior to the new version of wayland, in order to get firefox 95.0 to build I had to add "--without-wasm-sandboxed-libraries" as a build option. I kept that option in for this build with the patch. I also use my installed version of node (17.1.0) by commenting out the appropriate line in build-deps.sh

My build time:
real 111m3.010s
user 383m9.383s
sys 12m31.609s