[SOLVED] Potential bug in NetworkManager.Slackbuild on -current (patches not applied)

K4rolis · 01-15-2016, 06:08 PM

Hi,

In the slackbuild for NM on -current there appears to be a mistake on lines 88-97 where patches are supposed to be applied. I believe the output of zcat should be piped to patch and not OR'ed with it.

I might be completely wrong here (have barely any experience in shell scripting) - the reason why I looked at the NM slackbuild is because I'm still experiencing same issues as with unpatched NM and this seems to be incorrect.

Thanks!

CTM · 01-15-2016, 06:34 PM

Yep, that's a bug - those patches aren't being applied. Well spotted.

I've just been through the rest of the slackware64-current source tree and no other SlackBuilds suffer from the same problem, so fortunately this is an isolated incident.

rworkman · 01-15-2016, 09:48 PM

Well, just damn. Thanks.

gmgf · 01-16-2016, 04:09 AM

it seem just the 0001 patch who has a problem

CTM · 01-16-2016, 04:21 AM

Quote:

Originally Posted by gmgf

it seem just the 0001 patch who has a problem

No, it affects all of them:

Code:

# Some patches to nm-1.0 stable branch in git
zcat $CWD/patches/0001-man-fix-typos.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0002-core-fix-failure-to-configure-routes-due-to-wrong-de.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0003-ppp-manager-clear-ppp_watch_id-upon-pppd-termination.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0004-device-update-ip_iface-only-if-IP-interface-exists.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0005-device-infiniband-take-interface-down-to-set-transpo.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0006-wifi-olpc-refactor-NMDeviceOlpcMesh-to-hold-pointer-.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0007-wifi-don-t-fail-construction-of-NMDeviceWifi-in-cons.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0008-wifi-refactor-creation-of-NMDeviceWifi-NMDeviceOlpcM.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0009-build-use-symlinks-for-nmtui.patch.gz || patch -p1 --verbose || exit 1
zcat $CWD/patches/0010-build-minor-change-creating-symlinks-in-install-exec.patch.gz || patch -p1 --verbose || exit 1

gmgf · 01-16-2016, 04:28 AM

here, with modified SlackBuild only 0001 patch no work

K4rolis · 01-16-2016, 05:49 AM

Quote:

Originally Posted by gmgf

here, with modified SlackBuild only 0001 patch no work

True, man/NetworkManager.xml does not seem to exist in source code tree anymore but is still being patched in the 0001.

EDIT: Just checked NM GIT repo, and it appears that the man/NetworkManager.xml should be there.

CTM · 01-17-2016, 11:23 AM

Closure:

Code:

Sun Jan 17 07:24:08 UTC 2016
n/NetworkManager-1.0.10-x86_64-3.txz:  Rebuilt.
  Fixed build script to properly apply the patches.
  Thanks to K4rolis and rworkman.

K4rolis · 01-17-2016, 01:13 PM

Hehe, my first ever bug report.

And things got fixed within two days... Really cool. Going to put [SOLVED] in.

Thank you guys!