[SOLVED] giflib: build regression with NUMJOBS=-j1

lucabon · 03-04-2024, 08:16 AM

On new giflib version 5.2.2, patch giflib.GifQuantizeBuffer.diff.gz misses ($UOBJECT) dependency (it will fail to build on single-job make).

Fixed patch:

Code:

--- ./Makefile.orig     2024-02-19 13:22:38.525026520 -0600
+++ ./Makefile  2024-03-04 15:01:37.446904111 +0100
@@ -95,11 +95,11 @@
 
 $(UTILS):: libgif.a libutil.a
 
-$(LIBGIFSO): $(OBJECTS) $(HEADERS)
+$(LIBGIFSO): $(OBJECTS) $(UOBJECTS) $(HEADERS)
 ifeq ($(UNAME), Darwin)
        $(CC) $(CFLAGS) -dynamiclib -current_version $(LIBVER) $(OBJECTS) -o $(LIBGIFSO)
 else
-       $(CC) $(CFLAGS) -shared $(LDFLAGS) -Wl,-soname -Wl,$(LIBGIFSOMAJOR) -o $(LIBGIFSO) $(OBJECTS)
+       $(CC) $(CFLAGS) -shared $(LDFLAGS) -Wl,-soname -Wl,$(LIBGIFSOMAJOR) -o $(LIBGIFSO) $(OBJECTS) $(UOBJECTS)
 endif
 
 libgif.a: $(OBJECTS) $(HEADERS)

lucabon · 03-05-2024, 07:43 AM

Quote:

Originally Posted by lucabon

On new giflib version 5.2.2, patch giflib.GifQuantizeBuffer.diff.gz misses ($UOBJECT) dependency (it will fail to build on single-job make).

Fixed in the latest sources.