BUG slackpkg upgrade does not work with $ROOT

zerouno · 01-13-2016, 03:07 PM

I tried

Code:

# ROOT=/rootfs slackpkg -dialog=off upgrade wget

Checking local integrity... DONE
Looking for wget in package list. Please wait... DONE

wget-1.14-i486-3_slack14.1.txz

Total package(s): 1

Do you wish to upgrade selected packages (Y/n)? n

wget-1.14-i486-3_slack14.1.txz
is already installed, so slackpkg should presents nothing.

pkglist.awk intend a package as local if after first '/' there is the 'var' word.

This should solve: slackpkg-root-upgrade-patch.txt.
I tried it on a slackware-current host (slackpkg-2.82.0-noarch-16) that contains a slackware-14.1 chrooted

Code:

--- core-functions.sh-orig      2016-01-13 21:48:23.016726727 +0100
+++ core-functions.sh   2016-01-13 21:48:59.025276558 +0100
@@ -560,9 +560,9 @@
 
        grep -vE "(^#|^[[:blank:]]*$)" ${CONF}/blacklist > ${TMPDIR}/blacklist
        if echo $CMD | grep -q install ; then
-               ls -1 $ROOT/var/log/packages/* | awk -f /usr/libexec/slackpkg/pkglist.awk > ${TMPDIR}/tmplist
+    ( cd $ROOT ; ls -1 ./var/log/packages/* ) | awk -f /usr/libexec/slackpkg/pkglist.awk > ${TMPDIR}/tmplist
        else
-               ls -1 $ROOT/var/log/packages/* | awk -f /usr/libexec/slackpkg/pkglist.awk | applyblacklist > ${TMPDIR}/tmplist
+    ( cd $ROOT ; ls -1 ./var/log/packages/* ) | awk -f /usr/libexec/slackpkg/pkglist.awk | applyblacklist > ${TMPDIR}/tmplist
        fi
        cat ${WORKDIR}/pkglist | applyblacklist > ${TMPDIR}/pkglist

Rinndalir · 01-15-2016, 02:18 PM

You may want to also send to slackware maintaineer.

zerouno · 01-15-2016, 02:30 PM

Latest time I have reported a bug I wrote here and the fix was released in a few days, so I posted here now.

How I can report it to mantainers?

zerouno · 01-15-2016, 05:29 PM

small bug in the patch.

Code:

( cd $ROOT ; ls -1 ./var/log/packages/* )

should be

Code:

( cd $ROOT/ ; ls -1 ./var/log/packages/* )