[SOLVED] warning: 'XKeycodeToKeysym' is deprecated, how do I switch to XkbKeycodeToKeysym

H_TeXMeX_H · 12-24-2012, 06:04 AM

I'm trying to update rox-filer myself, because it hasn't been updated in 2 years, and I'll submit the patches after I finish.
http://sourceforge.net/projects/rox/files/

When I compile Rox-filer 2.11, I get:

Code:

/home/demonslayer/tmp/rox-filer-2.11/ROX-Filer/src/icon.c: In function 'filter_get_key':
/home/demonslayer/tmp/rox-filer-2.11/ROX-Filer/src/icon.c:749:3: warning: 'XKeycodeToKeysym' is deprecated (declared at /usr/include/X11/Xlib.h:1695) [-Wdeprecated-declarations]

The function there is:

Code:

static GdkFilterReturn filter_get_key(GdkXEvent *xevent,
				      GdkEvent *event,
				      gpointer data)
{
	XKeyEvent *kev = (XKeyEvent *) xevent;
	GtkWidget *popup = (GtkWidget *) data;
	Display *dpy = GDK_DISPLAY();

	if (kev->type != KeyRelease && kev->type != ButtonPressMask)
		return GDK_FILTER_CONTINUE;

	initModifiers();

	if (kev->type == KeyRelease)
	{
		gchar *str;
		KeySym sym;
		unsigned int m = kev->state;

		sym = XKeycodeToKeysym(dpy, kev->keycode, 0);
		if (!sym)
			return GDK_FILTER_CONTINUE;

		str = g_strdup_printf("%s%s%s%s%s%s%s",
			m & ControlMask ? "Control+" : "",
			m & ShiftMask ? "Shift+" : "",
			m & AltMask ? "Alt+" : "",
			m & MetaMask ? "Meta+" : "",
			m & SuperMask ? "Super+" : "",
			m & HyperMask ? "Hyper+" : "",
			XKeysymToString(sym));
			
		g_object_set_data(G_OBJECT(popup), "chosen-key", str);
	}

	gdk_window_remove_filter(popup->window, filter_get_key, data);
	gtk_widget_destroy(popup);

	return GDK_FILTER_REMOVE;
}

Here they suggest using XkbKeycodeToKeysym instead:
https://bugs.freedesktop.org/show_bug.cgi?id=5349

The problem is I can't just replace it, because the definitions are different, and I don't have any experience with X11 programming. What are groups and levels ? How do I fix it ?

Thanks, I will give credit to you when I submit the patches.

H_TeXMeX_H · 12-24-2012, 10:12 AM

Well, I just used:

Code:

sym = XkbKeycodeToKeysym(dpy, kev->keycode, 0, 0);

It seems to work ok in all my tests.

I'll leave the question open for a little longer in case there are any thoughts, otherwise I'll mark it solved.

RichZ · 03-19-2013, 08:33 AM

Quote:

Originally Posted by H_TeXMeX_H

Well, I just used:

Code:

sym = XkbKeycodeToKeysym(dpy, kev->keycode, 0, 0);

It seems to work ok in all my tests.

I'll leave the question open for a little longer in case there are any thoughts, otherwise I'll mark it solved.

Xkb is an extension that is not present or disabled on many servers. Either test for this condition or use another workaround - did you try XGetKeyboardMapping ?

H_TeXMeX_H · 03-19-2013, 09:53 AM

Actually, my solution is likely not good because I have experienced some crashes with it. I never got any other solution working.

It no longer bothers me. I suppose if it ain't broke don't fix it. It will break tho, and someone will have to fix it, hopefully not me.

RichZ · 03-19-2013, 11:06 AM

the other solution that has been suggested on stackoverflow is using XGetKeyboardMapping, see http://stackoverflow.com/questions/9...eycodetokeysym

But as long as it is just a warning it may be best to leave that alone.

H_TeXMeX_H · 03-19-2013, 11:28 AM

Thanks, I actually checked that exact link before, but the last reply wasn't there. That might just work, but I will have to test it.

RichZ · 03-20-2013, 07:31 AM

ok, let me know when you have some results.

H_TeXMeX_H · 05-27-2013, 12:55 PM

The solution actually does work and the crashing was caused by other things. So, it is ok to replace XKeycodeToKeysym with XkbKeycodeToKeysym, AFAIK.

Also see:
https://code.google.com/p/chromium/i...tail?id=117274