[SOLVED] Variable lost in loop

rknichols · 10-23-2021, 03:03 PM

What shell is executing this? What does "type echo" show? It looks like your echo command is treating "," as an operator.

Just a suggestion unrelated to yuor problem: You don't need to test for a nonexistent or zero-length "$db" file. The ">>" redirection will create the file if it does not currently exist.

pedropt · 10-23-2021, 03:24 PM

Thanks for the simple code shruggy , but i have the same problem as before , that did not solve the variables that i need to write in data.csv .
We returned to point 0 again .
By default in every thread i make here someone always simplify the code

))

Anyway check the image .

shruggy · 10-23-2021, 03:47 PM

As I said, you may try cueprint.

Using a cue sheet file from Wikipedia:

Code:

$ drd=/media/Disk5/Flac/xxx;cueprint -t"%p - %t , $drd\n" wp.cue
Faithless - Reverence , /media/Disk5/Flac/xxx
Faithless - She's My Baby , /media/Disk5/Flac/xxx
Faithless - Take the Long Way Home , /media/Disk5/Flac/xxx
Faithless - Insomnia , /media/Disk5/Flac/xxx
Faithless - Bring the Family Back , /media/Disk5/Flac/xxx
Faithless - Salva Mea , /media/Disk5/Flac/xxx
Faithless - Dirty Old Man , /media/Disk5/Flac/xxx
Faithless - God Is a DJ , /media/Disk5/Flac/xxx

Of course, this would work only as long as you don't have any % in $drd. Just extracting performer and title with cueprint would be safer.

Like this, using a cue sheet file from HAK:

Code:

$ cueprint -t'%p - %t\n' hak.cue
The Specials - Gangsters
The Specials - Rudi, A Message To You
The Specials - Nite Klub
The Specials - Too Much Too Young
The Specials - Guns Of Navarone
The Specials - Rat Race
The Specials - Stereotype
The Specials - International Jet Set
The Specials - Do Nothing
The Specials - Ghost Town
The Specials - Why?
The Specials - Friday Night, Saturday Morning
The Specials - War Crimes
The Specials - Racist Friend
The Specials - Nelson Mandela
The Specials - (What I Like Most About You Is Your) Girlfriend

Or you may double each % in $drd for cueprint

Code:

$ drd="/media/Disk5/Flac/From 0% to 100%"; echo ${drd//%/%%}
/media/Disk5/Flac/From 0%% to 100%%
$ cueprint -t"%p - %t , ${drd//%/%%}\n" wp.cue
Faithless - Reverence , /media/Disk5/Flac/From 0% to 100%
Faithless - She's My Baby , /media/Disk5/Flac/From 0% to 100%
Faithless - Take the Long Way Home , /media/Disk5/Flac/From 0% to 100%
Faithless - Insomnia , /media/Disk5/Flac/From 0% to 100%
Faithless - Bring the Family Back , /media/Disk5/Flac/From 0% to 100%
Faithless - Salva Mea , /media/Disk5/Flac/From 0% to 100%
Faithless - Dirty Old Man , /media/Disk5/Flac/From 0% to 100%
Faithless - God Is a DJ , /media/Disk5/Flac/From 0% to 100%

A thought. Could a performer name start with a dash? Then better use printf rather than echo.

Code:

printf %s\\n "$performer - ${titles[$i]} , $drd" >>"$db"

pedropt · 10-23-2021, 04:29 PM

Quote:

rknichols wrote:
What shell is executing this? What does "type echo" show? It looks like your echo command is treating "," as an operator.

"echo is a shell builtin"

Most likely , is there a way to bypass it ?
printf is not helping also .

I have tried * & | as replacements in echo and still got the same output

shruggy · 10-23-2021, 04:34 PM

Quote:

Originally Posted by pedropt

Most likely , is there a way to bypass it ?

Sure. /bin/echo

But I don't think echo is the culprit. Rather the way you generate art and song looks fragile and problematic:

Code:

grep "PERFORMER" "$scue" | sed 's/PERFORMER//' | sed 's/"//g' | sed 's/^ *//g' | sed '/^[[:space:]]*$/d' | uniq > "$art"
grep "TITLE" "$scue" | sed 's/TITLE//' | sed 's/"//g' | sed 's/^ *//g' | sed '/^[[:space:]]*$/d' | sed -e '1d' > "$song"

Even if you simplify it like this

Code:

sed '/PERFORMER/!d;s///;s/"//g;s/^ *//;/^$/d' "$scue"|uniq >"$art"
sed '/TITLE/!d;s///;s/"//g;s/^ *//;/^$/d' "$scue" >"$song"

But I don't know the cue sheet file format enough to judge. Again, rather than doing ad-hoc parsing with sed, I'd use a specialized tool (cueprint).

pedropt · 10-23-2021, 05:58 PM

New Update

Using cat on data.csv shows me this :

Quote:

root@Cloud:/usr/local/share/dbserver# cat data.csv
/media/Disk5/Flac/Albums & Remixed/Alan Barry - Greatest Hits & Remixes (2019)/CD1
/media/Disk5/Flac/Albums & Remixed/Alan Barry - Greatest Hits & Remixes (2019)/CD1

but using an editor like nano i get this :

Quote:

Alan Barry
- Good Vibrations (Radio Version)
/media/Disk5/Flac/Albums & Remixed/Alan Barry - Greatest Hits & Remixes (2019)/CD1
Alan Barry
- Come On (Radio Version)
/media/Disk5/Flac/Albums & Remixed/Alan Barry - Greatest Hits & Remixes (2019)/CD1

I have no idea why cat dont show everything , i only notice it now when i used nano .

Also they are not on same line , they are in separated lines each variable !!!!

For last and more strange i get in nano "read 271 lines (Converted from Mac format)" !!!
i am not in mac , i am in linux and data.csv was created in linux .

Quote:

root@Cloud:/usr/local/share/dbserver# file data.csv
data.csv: CSV text

image11 attached shows file opened on leafpad editor
Any idea ?

shruggy · 10-23-2021, 06:04 PM

That means there are embedded CR characters (\r, ^M, ASCII 13). cat -A will show them.

An explanation that I have. Your .cue files are in DOS format (CRLF). Again, cat -A will show it. Command substitution $() and mapfile -t will remove trailing LF (\n, ^J, ASCII 10), but CR will be left intact. When you cat it, the lines get overlapped, i.e. performer gets overwritten by title which in turn gets overwritten by $drd (remember how carriage return on a typewriter works).

sed 's/\s*$//' to the rescue.

Again, I'm pretty sure that cueprint can cope with this.

pedropt · 10-23-2021, 06:20 PM

Quote:

That means there are embedded CR characters (\r, ^M). cat -A will show them.

Exactly .
Is there a way to avoid this in the code ?

shruggy · 10-23-2021, 06:25 PM

Trim trailing white space when you generate $art and $song:

Code:

sed '/PERFORMER/!d;s///;s/"//g;s/^ *//;s/\s*$//;/^$/d' "$scue"|uniq >"$art"
sed '/TITLE/!d;s///;s/"//g;s/^ *//;s/\s*$//;/^$/d' "$scue" >"$song"

Or better, use cueprint instead.

pedropt · 10-23-2021, 06:36 PM

Bingo , you hit it .
Thank you so much for all your time and patience on this one , really appreciated .