Validate and sort input in script

stuaz · 08-25-2009, 04:14 PM

Hi,

This will most likely be a simple answer.

Currently I have a situation where my script will be sent various options:

Code:

-o1 -o2 -oe3@somthing.com

Now, if I want to run a certain command based on the option I am sent, I am doing the following.

Code:

for o in $(echo $options)
do
  if [ $o == "1" ]
  then
  
run commands
        exit 0
  fi
  if [ $o == "2" ]
  then
          run commands
        exit 0
  fi
done

However you will notice from my first example I gave "-oe3@something.com"

I need to be able to find where "-eXXX" is and then remove the 'e' and use the bit after (3@something.com). Or if it is easier, just forget about the "e" and look for anything with "@" init, but I would perfer to do the "e" method.

This next bit is later on at somepoint.

I will then want to "validate" what I have to check that is it a valid email address (You know so that it has an @ sign a domain name etc.

catkin · 08-25-2009, 04:51 PM

It's hard to understand exactly what you are trying to do. You list several options but your script only processes one but you use a variable called options for them (or it). The arguments passed to a script appear in $1, $2 etc. but you are processing them (or it) from $options which has the -o already stripped off and you say you get "-eXXX" but the example shows -oeXXX ... so many uncertainties.

Assuming (correct me if I'm wrong) that your script only gets one of these options at a time an that it has no embedded whitespace (so it all arrives in $1) and that somehow $1 gets into $options with the leading -o stripped off then

Code:

case $options in
    1 )
        <commands>
        ;;
    2 )
        <commands>
        ;;
    e* )
        address="${options#e}"
        <validate address>
        <commands>
        ;;
    * )
        <error messaging commands>
        ;;
esac

chrism01 · 08-25-2009, 08:51 PM

Maybe getopt or getopts would be better: http://aplawrence.com/Unix/getopts.html

stuaz · 08-26-2009, 01:48 AM

Quote:

Originally Posted by catkin

It's hard to understand exactly what you are trying to do. You list several options but your script only processes one but you use a variable called options for them (or it). The arguments passed to a script appear in $1, $2 etc. but you are processing them (or it) from $options which has the -o already stripped off and you say you get "-eXXX" but the example shows -oeXXX ... so many uncertainties.

Assuming (correct me if I'm wrong) that your script only gets one of these options at a time an that it has no embedded whitespace (so it all arrives in $1) and that somehow $1 gets into $options with the leading -o stripped off then

Code:

case $options in
    1 )
        <commands>
        ;;
    2 )
        <commands>
        ;;
    e* )
        address="${options#e}"
        <validate address>
        <commands>
        ;;
    * )
        <error messaging commands>
        ;;
esac

When I receive the options they will look like '1 2 eXXXX', so I don't think what you put will work? But I may be wrong.

I can't use getopts in my partiuclar situation.

catkin · 08-26-2009, 01:23 PM

Quote:

Originally Posted by stuaz

When I receive the options they will look like '1 2 eXXXX'

It would help if you showed us a) what the command line is like when your script is called and b) how you get $options from $1, $2 ... (or $* or $@).

Assuming your $options is a a string containing space-separated values as you said then something like this will work

Code:

set -o noglob
for option in $options
do
    case $option in
        1 )
            <commands>
            ;;
        2 )
            <commands>
            ;;
        e* )
            address="${option#e}"
            <validate address>
            <commands>
            ;;
        * )
            <error messaging commands>
            ;;
    esac
done
set +o noglob

The set -o noglob prevents $options being subjected to file name expansion in case it matches any files in your current directory. set +o noglob turns it back on (the default setting)

stuaz · 08-26-2009, 04:18 PM

Quote:

Originally Posted by catkin

It would help if you showed us a) what the command line is like when your script is called and b) how you get $options from $1, $2 ... (or $* or $@).

Assuming your $options is a a string containing space-separated values as you said then something like this will work

Code:

set -o noglob
for option in $options
do
    case $option in
        1 )
            <commands>
            ;;
        2 )
            <commands>
            ;;
        e* )
            address="${option#e}"
            <validate address>
            <commands>
            ;;
        * )
            <error messaging commands>
            ;;
    esac
done
set +o noglob

The set -o noglob prevents $options being subjected to file name expansion in case it matches any files in your current directory. set +o noglob turns it back on (the default setting)

Ok, I didn't realise I would need to provide that information so sorry that I left it out. My script is actually an interface script held in /etc/cups/interfaces which when I send a print job will activate my script and do whatever.

So the line I would be sending would be something like:

Code:

lp -dprintername -o1 -oetest@example.com /etc/hosts

So the variable "options" which is fed through to my interface script will contain:

Code:

1 etest@example.com

So what my script current does is search through that varaible for "1" and executes a command when it finds it. However the next stage is for me to send Two commands (like above) - so something like:

Finds Option 1
Also finds Option that starts with 'e', so then find out whatever is after 'e' (to the last blank space - cos i may in the future want to add further commands after). Then at that point I have some text which needs to be verfied as an email address - so maybe check that it has a @ sign? If it is valid then execute an email other wise carry on with the rest of the script.