[SOLVED] Strange Error executing the script.

pinga123 · 04-25-2012, 12:15 AM

I have a script which is giving me error as below.
script test.sh

Code:

getInfo()
{
Total_Memory=$(ssh -ttq fmguser@$1 "sudo /usr/sbin/xm info" | grep total_mem |awk -F " " '{print $3}')
echo "$Total_Memory"
Count=`expr $Total_Memory + 1`
echo "$Count"
}
getInfo 10.180.85.65

output.

Code:

$ sh test.sh
1013
expr: non-numeric argument

I m not sure where is the issue. Please help.

flamelord · 04-25-2012, 01:04 AM

you might have some trailing space in $Total_memory, so expr would interpret it as non-numeric.
I think something like Count=$(expr $(echo $Total_memory) + 1) would work. (There is probably something more elegant though).

pinga123 · 04-25-2012, 01:25 AM

Quote:

Originally Posted by flamelord

you might have some trailing space in $Total_memory, so expr would interpret it as non-numeric.
I think something like Count=$(expr $(echo $Total_memory) + 1) would work. (There is probably something more elegant though).

Modified the script however new set of errors comming

Code:

# cat test.sh
getInfo()
{
Total_Memory=$(ssh -t -tqn  fmguser@$1 "sudo /usr/sbin/xm info" < /dev/null | grep total_mem |awk -F " " '{print $3}')
echo "$Total_Memory"
Count=`$(expr $(echo $Total_Memory) + 1)`
echo "$Count"
}
getInfo 10.180.45.13

output

Code:

$ sh test.sh
tcgetattr: Inappropriate ioctl for device
1013
test.sh: line 5: 1014: command not found

colucix · 04-25-2012, 02:10 AM

What shell are you using? In bash you have the arithmetic operator, example:

Code:

Count=$((Total_Memory + 1))

or

Code:

Count=$((Total_Memory++))

The problem with your statement is that there are too many unnecessary commands substitutions. The outer one (with backticks) is responsible of the 1014: command not found error: the result of expr is 1014 and the script tries to execute it as a command.

pan64 · 04-25-2012, 02:29 AM

just a comment:
instead of

Code:

grep total_mem |awk -F " " '{print $3}'

you can write:

Code:

awk -F " " ' /total_mem/ {print $3}'

and also the whole function can be simplified:

Code:

ssh -ttq fmguser@$1 "sudo /usr/sbin/xm info" | awk -F " " ' /total_mem/ { print "Total memory = " $3 " , Count = " $3 + 1 }'

pinga123 · 04-25-2012, 02:51 AM

Quote:

Originally Posted by pan64

just a comment:
instead of

Code:

grep total_mem |awk -F " " '{print $3}'

you can write:

Code:

awk -F " " ' /total_mem/ {print $3}'

and also the whole function can be simplified:

Code:

ssh -ttq fmguser@$1 "sudo /usr/sbin/xm info" | awk -F " " ' /total_mem/ { print "Total memory = " $3 " , Count = " $3 + 1 }'

Now most of the errors are solved but still one error is comming.

Code:

getInfo()
{
Total_Memory=$(ssh -t -tqn  fmguser@$1 "sudo /usr/sbin/xm info" < /dev/null |awk -F " " ' /total_mem/ {print $3}')
echo "$Total_Memory"
Count=$((Total_Memory + 1))
echo "$Count"
}
getInfo 10.180.45.13

output:

Code:

$ sh test.sh
tcgetattr: Inappropriate ioctl for device
1013
1014

what is tcgetattr: Inappropriate ioctl for device?

pan64 · 04-25-2012, 03:01 AM

http://pubs.opengroup.org/onlinepubs...tcgetattr.html
this error means you have no terminal associated with the "current" process.
I assume this is caused by "< /dev/null".

grail · 04-25-2012, 03:55 AM

As the issues have been answered, I would just add that the -F switch is not required at all seeing whitespace is the default separator used.

pinga123 · 04-25-2012, 05:14 AM

Quote:

Originally Posted by pan64

http://pubs.opengroup.org/onlinepubs...tcgetattr.html
this error means you have no terminal associated with the "current" process.
I assume this is caused by "< /dev/null".

Error after removing /dev/null

Code:

getInfo()
{
Total_Memory=$(ssh -t -tq  fmguser@$1 "sudo /usr/sbin/xm info"  |awk -F " " ' /total_mem/ {print $3}')
echo "$Total_Memory"
Count=$((Total_Memory + 1))
echo "$Count"
}
getInfo 10.180.45.13

Code:

$ sh test.sh
1013
")syntax error: invalid arithmetic operator (error token is "

---------- Post added 04-25-12 at 05:15 AM ----------

Quote:

Originally Posted by grail

As the issues have been answered, I would just add that the -F switch is not required at all seeing whitespace is the default separator used.

The issue is not yet resolved. agree on -F switch but the problem is somewhat different .

pan64 · 04-25-2012, 05:31 AM

just try my awk, here it is again:

Code:

getInfo()
{
    ssh -ttq fmguser@$1 "sudo /usr/sbin/xm info" | awk ' /total_mem/ { print "Total memory = " $3 " , Count = " $3 + 1 }'
}

you can change the print at the and as you like....

Kenhelm · 04-25-2012, 10:20 AM

The confused error message

")syntax error: invalid arithmetic operator (error token is "

is caused by carriage return characters in the script.
The message was meant to be seen like this

test.sh: 1013\r: syntax error: invalid arithmetic operator (error token is "\r")

where \r is a carriage return character.
Carriage returns take printing back to the beginning of the line so that whatever has been printed starts to get overprinted. Here it happens twice:-

Code:

#!/bin/bash
echo -e 'test.sh: 1013\r: syntax error: invalid arithmetic operator (error token is "\r")'

")syntax error: invalid arithmetic operator (error token is "

pinga123 · 04-25-2012, 11:17 PM

Quote:

Originally Posted by Kenhelm

The confused error message

")syntax error: invalid arithmetic operator (error token is "

is caused by carriage return characters in the script.
The message was meant to be seen like this

test.sh: 1013\r: syntax error: invalid arithmetic operator (error token is "\r")

where \r is a carriage return character.
Carriage returns take printing back to the beginning of the line so that whatever has been printed starts to get overprinted. Here it happens twice:-

Code:

#!/bin/bash
echo -e 'test.sh: 1013\r: syntax error: invalid arithmetic operator (error token is "\r")'

")syntax error: invalid arithmetic operator (error token is "

What is the solution?

pan64 · 04-26-2012, 01:03 AM

Quote:

Originally Posted by pinga123

What is the solution?

what is the problem with my awk? that should work.
Where do you execute this script? which os, which shell...?

grail · 04-26-2012, 04:37 AM

The awk will not work any better without tweaking the RS to accommodate for the alternate line endings.

Kenhelm · 04-26-2012, 08:46 AM

Various ways of converting a DOS/Windows text file to Unix format are given here
http://en.wikipedia.org/wiki/Newline...sion_utilities
For example, tr can be used to remove all of the carriage returns

Code:

tr -d '\r' < test.sh > newtest.sh