Spam reporting script was working now fails

Toadman · 12-06-2009, 11:52 AM

I run a script, not written by me, that will take spam and report it to the various abuse addresses. Prior to my upgrade to Mandriva 2010 from 2009.1 this script was working with no issues, now however when trying to run the script I get:

/usr/local/bin/reportSpam: line 1020: syntax error near unexpected token `('
/usr/local/bin/reportSpam: line 1020: ` SUBJECT="$BASE_SUBJECT (${SPAM_IP}) $ORIGINAL_SUBJECT"'

Line 1020 of the script is:

SUBJECT="$BASE_SUBJECT (${SPAM_IP}) $ORIGINAL_SUBJECT"

This probably isn't much help so I've attached the entire script.

Thanks for any advice/assistance.

Chris

gaurav1086 · 12-06-2009, 12:24 PM

hello
why are using the parenthesis. Parenthisis is for subshell. remove the parenthesis and it would work fine.
regards.

Toadman · 12-06-2009, 05:05 PM

Tried that, didn't work:

/usr/local/bin/reportSpam: line 1022: syntax error near unexpected token `('
/usr/local/bin/reportSpam: line 1022: `## NANAS_SUBJECT="[email] (${SPAM_IP}) $ORIGINAL_SUBJECT"'

Removed the parens on line 1022 and get:

/usr/local/bin/reportSpam: line 1092: unexpected EOF while looking for matching `)'
/usr/local/bin/reportSpam: line 1243: syntax error: unexpected end of file

Line 1092 being:

BAD_ADDRS="$(

and there is no line 1243. As I said in my original post this script used to work fine before I upgraded to Mandriva 2010 so something must have changed somewhere but I'll be darned if I can figure it out. I know very little about scripts.

ntubski · 12-06-2009, 09:34 PM

Quote:

Tried that, didn't work:

Well, it did work, but there was another problem. This one is more interesting, it looks bash's parser fails when faced with a here document piped to command with spaces in it when that is inside a $() substitution. The bash version here is
4.0.28(1)-release, perhaps bash 3.x does not have this problem, which is why the upgrade caused you problems. dash appears to handle this just fine.

Anyways, here is a workaround:

Code:

# change the following lines (1092, 1093)
        BAD_ADDRS="$(
    cat <<-EOF | fold -s -w 64
# to this
        fold_s_w64() { fold -s -w 64; }
        BAD_ADDRS="$(cat <<-EOF | fold_s_w64

Toadman · 12-07-2009, 05:18 PM

Sorry to say that didn't work for me. I changed 1092/1093 to:

Code:

fold_s_w64() { fold -s -w 64; }
        BAD_ADDRS="$(cat <<-EOF | fold_s_w64

and still get the line 1020 error:

Code:

/usr/local/bin/reportSpam: line 1020: syntax error near unexpected token `('
/usr/local/bin/reportSpam: line 1020: `    SUBJECT="$BASE_SUBJECT (${SPAM_IP}) $ORIGINAL_SUBJECT"'

catkin · 12-07-2009, 11:48 PM

Quote:

Originally Posted by Toadman

This probably isn't much help so I've attached the entire script.

Try removing the \c at the end of the echo string on line 747. If that works we can try to figure out why!

ntubski · 12-08-2009, 03:02 PM

Quote:

Originally Posted by Toadman

and still get the line 1020 error

I was thinking you would apply gaurav1086's fix in addition to mine. Although looking at the script again now, I can't actually see why having parens in a string would be a problem.

Is it possible to install bash 3.x? That would probably be the easiest way to run this script.

Toadman · 12-08-2009, 08:00 PM

I've currently got all the changes suggested made to the script, still I get the line 1020 error. Bash reports version

bash --version
GNU bash, version 4.0.33(2)-release (i586-mandriva-linux-gnu)

not sure if I could downgrade to verson 3 though.

I've got dash installed however haven't had a chance to read the manpage. running [chris@localhost ~]$ dash
$ reportSpam
then entering the script name also gives me the same line 1020 error though I may not be doing this correctly. Will have to print out the manpage and look it over.

ntubski · 12-09-2009, 10:25 AM

Quote:

Originally Posted by Toadman

I've currently got all the changes suggested made to the script, still I get the line 1020 error.

Oh, from your earlier post I assumed that the 1020 error was fixed. Unfortunately I can't reproduce this error in a small script (can't run the whole script because it depends on other things in your system), so I have no idea why it's occuring.

To run the script with dash do

Code:

 $ dash $(which reportSpam)

I assume reportSpam is in your PATH. I don't think dash will be able to run the script as it has less features than bash (eg: doesn't support arrays). I just mentioned it because dash doesn't have a problem with the syntax used on line 1092 (I was able to reproduce that problem in a small script).