Simple script for adding groups to Linux

keefaz · 05-30-2004, 03:24 AM

Well do no hesitate to put the script here, frankly I don't see what's wrong if $group_name entered by user (although if the user has no rights to write in /home, it is logical than it can't create directory here)

kenji1903 · 05-31-2004, 12:02 AM

Here is part of the code, have not finished it off yet.
I know it looks like what a elementary school student would have written, I am just a bad programmer

Code:

#!/bin/bash

echo "*************************"
echo "* Please select an option:       *"
echo "* 1. Create a group                 *"
echo "* 2. Adding a user                    *"
echo "* 3. Adding a machine account *"
echo "* OR Press any key to exit        *"
echo "**************************"

read menu_input

case $menu_input in 
1)  echo "===== Group creation ====="
    echo -n "Please enter group name: "
    read group_name

    group_test=$(cat /etc/group | awk -F: '{ print $1 }' | grep $group_name)

    if [ -z $group_test ] || [ ! "$group_test" = "$group_name" ]; then
	/usr/sbin/groupadd "$group_name"
	mkdir /home/"$groupname"
	chgrp "$groupname" /home/"$groupname"
	chmod 0770 /home/"$groupname"
	echo "Group and Group's home directory added"
    else 
	echo "Group already exists! Skipping group creation..."
    fi
;;
2) echo "Adding a user"
;;
3) echo "Adding a machine account"
;;
*) echo "Exit"
esac

I was reading other threads about scripts... those mkdir, chown commands, do they belong somewhere like /usr/bin or /sbin? Maybe i need to include the entire path of the command or something, do I?

keefaz · 05-31-2004, 04:43 AM

replace the lines

Code:

mkdir /home/"$groupname"
chgrp "$groupname" /home/"$groupname"
chmod 0770 /home/"$groupname"

by :

Code:

mkdir /home/$group_name
chgrp $group_name /home/$group_name
chmod 0770 /home/$group_name

Ma3oiS · 05-31-2004, 07:56 AM

Hi,

I think you can't create directory with mkdir because you've already created it... check your /home/ directory.
If you don't want mkdir to display error messages replace it with
mkdir "/home/$group_name" &> /dev/null

Ma3oiS

kenji1903 · 05-31-2004, 10:11 AM

thanks guys, i'll give that a try first thing tomorrow morning

Cracking my head in the mean time on RAID stuff, haha

CheeRs,
~WiLL~

kenji1903 · 06-03-2004, 10:14 PM

Thanks guys~

Its working now

I'll come back if I have more queries (I bet that will me very soon, haha)

CheeRs,
~WiLL~