[SOLVED] script stops if unable to navigate to mentioned path

ankitpandey · 03-12-2013, 01:47 PM

Hello Team

I have set of folder which i am taking as input and then navigating to one fixed path. There are few folders which dont have that path becuase of which the script is geting stopped at that point. Please suggest how to overcome this. I want to continue with next folder input if present one don't have defined path. Below is the script i am trying.

Below is the error i am getting when executing the script.

Quote:

test1.sh: /path/dataintigrity/cubes/: does not exist

Below is the code:

Code:

fix=1851162600
DIR=/path/
SCRIPT_DIR=/path/scripts/
cd $DIR

for folder in `ls -ltr |egrep '^d' |awk '{print $9}'`
do
	cd /path/$folder/cubes/
		if [ $? -eq 0 ]
		then
		echo `ls -ltr |awk '{print $5}'` >$SCRIPT_DIR/size.txt
		for size in `cat $SCRIPT_DIR/size.txt`
		do
			if [ $size -gt $fix ]
			then
		echo "Cube in folder $folder has crossed 1.7G, please take appropriate action" | mailx -s "cube file has exceeded 1.7G size" xyz@abc.com
			fi
		done
		fi
done

mina86 · 03-12-2013, 02:04 PM

Quote:

for folder in `ls -ltr |egrep '^d' |awk '{print $9}'`

Before you go any further or write another line of shell script you must read this: http://partmaps.org/era/unix/award.html.

I'm serious.

Now that you've read that page, what you want is:

Code:

for dir in /path/*/cubes/; do
    cd "$dir" || continue
    ls -ltr | awk '{print $5}' | while read size; do
        if [ $size -gt $fix ]; then
            echo "Cube in folder $folder has crossed 1.7G, please take appropriate action" | 
                mailx -s "cube file has exceeded 1.7G size" xyz@abc.com
        fi
    done
done

By the way, you were getting the massage because -x option was set, probably via set -x somewhere in your script or #!/bin/sh -x at the beginning.

PS. Did you know, that you can use find to do exactly what you did in this script? Go read man find. The option you will be most interested in is -size.

David the H. · 03-12-2013, 02:20 PM

1) Don't Read Lines With For

2) Don't parse ls for filenames and metadata.

3) QUOTE ALL OF YOUR VARIABLE EXPANSIONS. You should never leave the quotes off a parameter expansion unless you explicitly want the resulting string to be word-split by the shell and possible globbing patterns expanded. This is a vitally important concept in scripting, so train yourself to do it correctly now. You can learn about the exceptions later.

http://mywiki.wooledge.org/Arguments
http://mywiki.wooledge.org/WordSplitting
http://mywiki.wooledge.org/Quotes

4) $(..) is highly recommended over `..`

5) When using bash or ksh, it's recommended to use [[..]] for string/file tests, and ((..)) for numerical tests. Avoid using the old [..] test unless you specifically need POSIX-style portability.

http://mywiki.wooledge.org/BashFAQ/031
http://mywiki.wooledge.org/ArithmeticExpression

6) Useless Use Of Grep.

7) Since environment variables are generally all upper-case, it's recommended practice to keep your own user variables in lower-case or mixed-case to help differentiate them. You should also generally try to use variable names that clearly relate to their function in the script, but avoid ones that conflict with existing command names like "file".

8) Scripting With Style

Congratulations! I think this one post has made me post more of my canned responses at once than any other.

Start by correcting the worst of the above, particularly the first three, then come back if you still have problems.