[SOLVED] Rewrite bash function to use parameter expansion instead of custom IFS

OreCollector · 04-06-2018, 03:41 PM

I am trying to rewrite the isvalidip() from Pro Bash Programming to use parameter expansion as suggested by the exercise at the end of the chapter and I am stuck.

I found https://www.linuxquestions.org/quest...fs-4175422897/ but I can't get my version of the solution to work.

Any ideas?

Code:

isvalidip() #@ USAGE: isvalidip DOTTED-QUAD
{
    case $1 in
        ## reject the following:
        ##   empty string
        ##   anything other than digits and dots
        ##   anything not ending in a digit
        "" | *[!0-9].* | *.[!0-9]) return 5 ;;
    esac

    #IFS=.  ## original code

    set "${1//./ }" ## my attempt at parameter expansion instead - for fun and science

    #set -- $1  ## more orignal code

    [ $# -eq 4 ] && ## must be four parameters
                    ## each must be less than 256
    ## A default of 666 (which is invalid) is used if a parameter is empty
    ## All four parameters must pass the test
    [ ${1:-666} -le 255 ] && [ ${2:-666} -le 255 ] &&
    [ ${3:-666} -le 255 ] && [ ${4:-666} -le 255 ]
}

Execution attempt;I am expecting 0 for $?:

Code:

[mdittmer@ops2 bin]$ . isvalidip
[mdittmer@ops2 bin]$
[mdittmer@ops2 bin]$ isvalidip 123.123.123.123; echo $?
1
[mdittmer@ops2 bin]$

keefaz · 04-06-2018, 05:22 PM

The idea maybe is to replace dots with spaces so you end up with a numbers list separated with spaces.
With original IFS, you can assign this value into an array easily (autosplit with spaces)

Code:

ip_arr=(${1//./ })

From that you can count elements in $ip_arr, iterate values etc...

Oh sorry, I read too quickly. I overlooked you want to overwrite the arguments list...
I never did that, not my programming style but why not

Correct syntax would be

Code:

set -- ${1//./ }

OreCollector · 04-06-2018, 06:41 PM

You are correct! My set syntax was off. Thank you very much!