[SOLVED] rename files in folders using perl script

pablgonz · 11-23-2011, 08:51 PM

I need to create a perl script for the following, I have an images folder, creates for other script, with the following files (creates whit script):

Code:

test-tmp-000001.ppm
test-tmp-000002.ppm
test-tmp-000003.ppm
test-tmp-000004.ppm
test-tmp-000005.ppm

and I want to stay in the following way

Quote:

test-tmp-1.ppm
test-tmp-2.ppm
test-tmp-3.ppm
test-tmp-4.ppm
test-tmp-5.ppm

but, using a perl script to open the directory and rename files only. ppm (in the directory there are more files with the same names and other extensions), dealing with the following code:

Code:

my $dir_renombra = "$tempDir/$imageDir";
my $fichero = '';
my $resultado = '';
my $var = 1;
if(opendir(DIR,$dir_renombra)){
  foreach (readdir DIR){
        $fichero = $_;
        if ($fichero =~ /($name-tmp-)\d+.ppm/)
        {
        next if $fichero=~/($name-tmp-$var)\.ppm/;
             my $nuevo_nombre = substr($fichero,0,-10) . "$var.ppm";
             $var = $var + 1;
             $resultado = rename("$dir_renombra/$fichero","$dir_renombra/$nuevo_nombre");
             print "Renaming $fichero to $nuevo_nombre: $resultado : $!\n";
        }
      }
    print "FIN\n";
   }
  else
   {
   print "dont open".$dir_renombra;
   }
closedir DIR;

but it throws the error and rename all the files. ppm to find.
If I puden assist with this, I would be very grateful or display an easier way to do it thanks.
Pablo.

firstfire · 11-23-2011, 10:15 PM

Hi.

You can use groups (parentheses) in regular expressions to extract matching substrings. See this link for example and play with the following code

Code:

my $dir_renombra = "$tempDir/$imageDir";
my $fichero = '';
my $resultado = '';
my $var = 1;
if(opendir(DIR,$dir_renombra)){
  foreach (readdir DIR){
        $fichero = $_;
        if ($fichero =~ /([^\d]+)(\d+).ppm/)
        {
	     my $var=int($2);
	     my $nuevo_nombre ="$1$var.ppm";
             print "Renaming $fichero to $nuevo_nombre\n";
        }
      }
    print "FIN\n";
   }
  else
   {
   print "dont open".$dir_renombra;
   }
closedir DIR;

You should add actual renaming to the code.

Hope this helps.

bigearsbilly · 11-24-2011, 03:20 AM

Hmm, the art of perl is to minimize typing:

Code:

foreach (<test-tmp-*.ppm>) {
    print "mv $_ ", s/0+// && $_, "\n";
}

pablgonz · 11-24-2011, 04:23 AM

Quote:

Originally Posted by firstfire

Hi.

You can use groups (parentheses) in regular expressions to extract matching substrings. See this link for example and play with the following code
....
You should add actual renaming to the code.
Hope this helps.

Thanks, I made the changes you indicated, but, although the re display shows file names, but in reality (in the folder) not modify.

firstfire · 11-24-2011, 04:37 AM

Quote:

Originally Posted by pablgonz

but in reality (in the folder) not modify.

That is why i wrote

Quote:

You should add actual renaming to the code.

This part (renaming) was implemented in your first program. Just copy it.

bigearsbilly · 11-24-2011, 05:14 AM

safest is to copy the output then look at it and run it.
that's why I use a "print" statement rather than do the
move, it's safer.

my_script.pl | tee ~/1

cat ~/1
[take a look at it]

Code:

mv test-tmp-000001.ppm test-tmp-1.ppm
mv test-tmp-000002.ppm test-tmp-2.ppm
mv test-tmp-000003.ppm test-tmp-3.ppm
mv test-tmp-000004.ppm test-tmp-4.ppm
mv test-tmp-000005.ppm test-tmp-5.ppm

It looks ok so run it as a shell script...

sh ~/1

Cedrik · 11-24-2011, 07:45 AM

zero-padded images filenames look better to me, if you want to do animations, diaporama, it will be easier to have them in correct sequence order

pablgonz · 11-24-2011, 05:40 PM

Thanks, the rename fThank you very much, the script works perfectly, I had forgotten to print a line (I was a little sleepy)

pablgonz · 12-17-2011, 02:03 PM

I am making some modifications to the script (adding a few features) and I encountered the following problem, in some cases files are created as follows

Code:

test1-tmp-000001.ppm
test1-tmp-000002.ppm
test1-tmp-000003.ppm

or

Code:

test1-tmp-1-000001.ppm 
test1-tmp-2-000002.ppm 
test1-tmp-3-000003.ppm

or

Code:

test1-tmp-1-1.ppm 
test1-tmp-2-1.ppm 
test1-tmp-3-1.ppm

my question is that I should change in line

Code:

if ($fichero =~ /([^\d]+)(\d+).ppm/)

to re name in either case files to

Code:

test1-tmp-1.ppm 
test1-tmp-2.ppm 
test1-tmp-3.ppm

In simpler terms i want to save at test1-tmp- in $1 and the rest in $2
thanks for your help

firstfire · 12-17-2011, 10:20 PM

Hi.

I see the problem.. Try the following regular expression

Code:

if ($fichero =~ /(.+-)(\d+).ppm/)

First group matches (almost) any string ending with the dash "-". Previously the first group matched only a string of non-digits.

If you want to use filenames like "test-tmp_000001.ppm" then change regexp as follows

Code:

if ($fichero =~ /(.+[^\d])(\d+).ppm/)

pablgonz · 12-17-2011, 10:51 PM

thanks for the answer, change the line to

Code:

if ($fichero =~ /(.+[^\d])(\d+).ppm/)

but fails if the files are of the form

Code:

test1-tmp-1-000001.ppm 
test1-tmp-2-000002.ppm 
test1-tmp-3-000003.ppm

firstfire · 12-17-2011, 11:23 PM

Hi.

Code:

$ perl rename.pl 
Renaming test-tmp-000005.ppm to test-tmp-5.ppm
Renaming test-tmp-000003.ppm to test-tmp-3.ppm
Renaming test1-tmp-000001.ppm to test1-tmp-1.ppm
Renaming test-tmp-000001.ppm to test-tmp-1.ppm
Renaming test-tmp-000002.ppm to test-tmp-2.ppm
Renaming test-tmp-000004.ppm to test-tmp-4.ppm
Renaming test1-tmp-2-000001.ppm to test1-tmp-2-1.ppm
FIN

What is the desired output? How the program is supposed to decide which number to keep?

pablgonz · 12-18-2011, 12:00 AM

Quote:

Originally Posted by firstfire

Hi.
What is the desired output? How the program is supposed to decide which number to keep?

Thanks for the reply, I was trying something like this

Code:

if ( $fichero =~ /(save in $1)(\d+|\d+[-]\d+).ppm/)

In theory it should save test-tmp- in $1 and the rest (all case) in $2

firstfire · 12-18-2011, 01:21 AM

Code:

if ($fichero =~ /(.+?-)((\d+-?)+).ppm/)

'.+?' is a non-greedy regular expression.
Example:

Code:

$ echo test1-tmp-2-000001.ppm | perl -ne '/(.+?-)((\d+.+-?)+).ppm/;print "[$1][$2]\n"'
[test1-tmp-][2-000001]

Note that in this case $2 may be something like '2-000001' and int(2-000001) -> 2. This may be a problem, because int(2-000005) -> 2 as well.

David the H. · 12-18-2011, 03:01 AM

Are you aware that there's already a perfectly good perl renaming script available? It comes bundled with the perl package in debian-based systems (at least), or you can get it here:

https://gist.github.com/995151

With it, renaming the files listed above would be as simple as:

Code:

prename 's/-0{5}/-/' *.ppm

Modify the expression as necessary, of course. Ensuring that you're renaming the correct files is just a matter of making sure you use regex and globbing expressions that accurately target only the pattens you want.

Even if prename isn't exactly what you're looking for, you may be able to look at its code for more tips.