please fix the bug

lipun4u · 02-21-2011, 02:11 PM

plz go throuugh the following code...

Code:

#!/bin/bash
set -x


if [ $# -ne 2 ]
then
        echo "Usage : $(basename) <start-date> <end-date>"
        exit 1
fi

start_date=$1
end_date=$2
process_name=$(basename $0)
log_file="${process_name}_$(date +%d%m%Y%H%M%S).LOG"

##$>>$log_file

date -d"+$k day" +%d%b%Y | tr [:lower:] [:upper:]

convert_to_days()
{
        local tot_sec
        local ip_date="$1"

        tot_sec=$(date -d "$ip_date" +%s)

        echo $(( $tot_sec / ( 24 * 3600) ))
}

compare_date_days()
{
        local start_dt
        local end_dt

        start_dt=$(convert_to_days "$1")
        end_dt="$(convert_to_days "$2")

        if [ $start_dt -gt $end_dt ]
        then
                echo "-1"
        elif [ $start_dt -lt $end_dt ]
        then
                echo "1"
        else
                echo "0"
        fi
}





echo "Start Date : $(convert_to_days $start_date )"
echo "End Date : $(convert_to_days $end_date )"

echo $(compare_date_days $start_date $end_date)

when i run, it says that there is a bug at line 54.

druuna · 02-21-2011, 02:48 PM

Hi,

At first glance: You call your functions as a separate process ($(convert_to_days $start_date )), no need for that.

Something like this is better (untested):

Code:

echo -n "Start Date : " convert_to_days $start_date
echo -n "End Date : " convert_to_days $end_date

You do this more then once in your script, modify all those lines.

Hope this helps.

corp769 · 02-21-2011, 02:49 PM

Can you post the output of the script?

And FYI, please use something more descriptive in your subject line next time. Just using "please fix the bug" is telling me that you want someone else to do the work for you. We are here to assist, not to do everything for you. Thanks!

H_TeXMeX_H · 02-21-2011, 02:49 PM

Try:

Code:

#!/bin/bash
set -x


if [ $# -ne 2 ]
then
        echo "Usage : $(basename) <start-date> <end-date>"
        exit 1
fi

start_date=$1
end_date=$2
process_name=$(basename $0)
log_file="${process_name}_$(date +%d%m%Y%H%M%S).LOG"

##$>>$log_file

date -d"+$k day" +%d%b%Y | tr [:lower:] [:upper:]

convert_to_days()
{
        local tot_sec
        local ip_date="$1"

        tot_sec=$(date -d "$ip_date" +%s)

        echo $(( $tot_sec / ( 24 * 3600) ))
}

compare_date_days()
{
        local start_dt
        local end_dt

        start_dt=$(convert_to_days "$1")
        end_dt=$(convert_to_days "$2")

        if [ $start_dt -gt $end_dt ]
        then
                echo "-1"
        elif [ $start_dt -lt $end_dt ]
        then
                echo "1"
        else
                echo "0"
        fi
}





echo "Start Date : $(convert_to_days $start_date )"
echo "End Date : $(convert_to_days $end_date )"

echo $(compare_date_days $start_date $end_date)