php read from file and compare.

xushi · 07-07-2005, 10:01 AM

I'm making a simple php script to read a list of IPs from a file into an array, and ban - exit() - the user if the ip matches. When the IPs are manually typed in the script, it works, i.e.
$banned_ip[] = '1.2.3.4';
$banned_ip[] = '5.6.7.8';
...

But when i stick the addresses in a file, it doesn't seem like its doing the if check.. Here's my code

Code:

<?php
$banned_ip = file("banlist.txt");
$ip = $_SERVER['REMOTE_ADDR'];

    // Ban if IP matches.
    if(in_array($ip,$banned_ip)) {
        echo "You have been banned!";
        exit();
    }
    //else continue...
    echo "success";
?>

where banlist.txt contains an ip address per line. If i add echo $banned_ip[5]; or echo $ip; i get the values i want... so i guess the problem is with the if(in_array(......)

marghorp · 07-07-2005, 10:07 AM

Maybe in the array, there are some hidden characters, when read from a file? Check into that.

keefaz · 07-07-2005, 10:23 AM

You could also use :

PHP Code:



$ip = $_SERVER['REMOTE_ADDR']; 
$out=`grep $ip banlist.txt`; 
 
if(!empty($out)) { 
    echo "You have been banned!"; 
    exit(); 
}

xushi · 07-07-2005, 10:30 AM

Excellent! =))

that did the job keefaz. Many thanks =) And i'm currently testing the bash script, will post about it asap.

xushi · 07-10-2005, 04:24 AM

Hmm, it doesn't seem to work 100% when i add it to any of my html/php files...

If i stick it by itself in a test.php, it works. But if i add it to any other file, it just says success, weather i stick my ip in the list or not.

PHP Code:



    $ip = $_SERVER['REMOTE_ADDR']; 
    $out=`grep $ip banlist.txt`; 
    if(!empty($out)) { 
        echo "You have been banned!"; 
        exit(); 
    } 
    echo $out; 
    echo "success";

I stuck echo $out; to as a check, and its empty (with or witout my ip in the list). Also, how would i open banlist.txt if it were 2 folders up?

Many thanks.

msound · 07-11-2005, 10:47 PM

lets say:
/www/html/banlist.txt
and you're in /www/html/forum/template, the following should work:

Code:

$out = `grep $ip ../../banlist.txt';

xushi · 07-12-2005, 03:32 AM

Quote:

Originally posted by msound
lets say:
/www/html/banlist.txt
and you're in /www/html/forum/template, the following should work:

Code:

$out = `grep $ip ../../banlist.txt';

Ignoring the typo ' , But i've already tried it. It just won't read banlist.txt at all. Even if its in the current directory or any other. All i get is 'success' even if i stick my ip address in the list, delete the list, rename it, whatever =/

keefaz · 07-12-2005, 07:46 AM

It is weird...
Here is a deeper test :

PHP Code:



// give the full path to banlist.txt,  
// just to make sure... 
 
$banfile = '/home/www/banlist.txt';  
$ip = $_SERVER['REMOTE_ADDR']; 
$iptest = false; 
 
if(empty($ip)) die('ip is empty...'); 
 
$fd = fopen($banfile, 'r')  
    or die("Could not open $banfile to read in"); 
 
while($buffer = fgets($fd,4096)) { 
    $buffer = trim($buffer); 
    echo "is $buffer equal to $ip ? "; 
    if(strcmp($ip, $buffer) == 0) { 
        echo "yes! <br>"; 
        $iptest = true; 
        break; 
    } 
    echo "no <br>"; 
} 
 
fclose($fd); 
 
echo ($iptest) ? "You have been banned" : "SUCCESS";

xushi · 07-12-2005, 11:45 AM

Sorry for the late reply,

Heh, ok, this one seems to work.

Code:

is 192.168.0.69 equal to 192.168.0.69 ? yes!
You have been banned

I guess i could stick to this script, although i'm itching to know why the other one refused to work in certain cases.

edit: hmm, i'd also want to stick an exit(); code with the banned part.

Probably in the if condition, before the break; would be the best place

edit: 2

an addition

Code:

...
...
...
...
...
is 211.46.196.124 equal to 192.168.0.69 ? no
is 193.194.84.198 equal to 192.168.0.69 ? no
is 200.30.146.150 equal to 192.168.0.69 ? no
is 200.205.145.70 equal to 192.168.0.69 ? no
is 209.161.5.194 equal to 192.168.0.69 ? no
is 62.245.167.6 equal to 192.168.0.69 ? no
is 204.83.150.196 equal to 192.168.0.69 ? no
is 207.234.208.66 equal to 192.168.0.69 ? no
is equal to 192.168.0.69 ? no
SUCCESS

Messy

keefaz · 07-12-2005, 01:24 PM

quick fix :

PHP Code:



while($buffer = fgets($fd,4096)) { 
    $buffer = trim($buffer);  
    if(empty($buffer)) continue; 
 ...

xushi · 07-13-2005, 09:43 AM

Quote:

Originally posted by keefaz
quick fix :

PHP Code:

while($buffer = fgets($fd,4096)) { $buffer = trim($buffer); if(empty($buffer)) continue; ...

Hmm... nope..
That fix gives me,
is 192.168.0.69 equal to 192.168.0.69 ? no
SUCCESS

PHP Code:



$banfile = '/full/path/to/banlist.txt'; 
$ip = $_SERVER['REMOTE_ADDR']; 
$iptest = false; 
 
if(empty($ip)) die('ip is empty...'); 
 
$fd = fopen($banfile, 'r') 
    or die("Could not open $banfile to read in"); 
 
while($buffer = fgets($fd,4096)) { 
    $buffer = trim($buffer); 
    echo "is $buffer equal to $ip ? "; 
    //if(strcmp($ip, $buffer) == 0) { 
    if(empty($buffer)) { 
       echo "yes! <br>"; 
        $iptest = true; 
        exit('Banned'); 
        break; 
    } 
    echo "no <br>"; 
} 
 
fclose($fd); 
echo ($iptest) ? "You have been banned" : "SUCCESS";

edit, didn't think you literally meant 'continue;', but even if i changed the code to the following, it doesn't work properly

PHP Code:



$banfile = '/full/path/to/banlist.txt'; 
$ip = $_SERVER['REMOTE_ADDR']; 
$iptest = false; 
 
if(empty($ip)) die('ip is empty...'); 
 
$fd = fopen($banfile, 'r') 
    or die("Could not open $banfile to read in"); 
 
while($buffer = fgets($fd,4096)) { 
    $buffer = trim($buffer); 
    if(empty($buffer)) continue; 
} 
 
fclose($fd);

keefaz · 07-14-2005, 01:10 PM

I should have been more precise

I didn't mean to replace the test :
if(strcmp($ip, $buffer) == 0)
with :
if(empty($buffer))

As you pointed out, the script originally tested the empty lines
so I thought that before the test :
if(strcmp($ip, $buffer) == 0)
We could add :
if(empty($buffer)) continue;
So the loop skips the empty lines