one more easy one ? anybody??

sleepwalker1.0 · 10-26-2002, 06:12 AM

This is as simple as it gets but i get an error when i try to get the option 4 (the exit option) to exit the script. It says "line 28 unexpected token , fi" now I know that i have to close the if statement and have tried it both ways to make sure. However, i get the same error both ways. Do i need the "fi" statement at all here?

<code>

echo "Your current IPaddress is:
"/sbin/ifconfig ppp0|grep inet|cut -d : -f 2|cut -d " " -f 1"
echo

uptime
echo

echo "Whar do you want to do today?"
echo "1.Burn a cd"
echo "2.Erease a CD"
echo "3.Use instant messenger"
echo "4.Exit"
read A

if [ $A -eq 1 ]
[ cdwrite.sh ]
then
fi

read A
if [ $A -eq 2 ]
then
[ cde.sh ]
exit
fi

if [ $A -eq 3 ]
then
[ amsn ]
exit
fi

if [ $A -eq 4 ]
then
exit
fi
</code>

The script runs fine and does what i want it to do (so far) just a little something to do im my spare time. just wont exit. thanks for looking .

Hko · 10-26-2002, 09:24 AM

There is more than one error in your script, like nested quotes, an extra "read A", and the ' [ ' and ' ] ' around the names of shell-scripts you want to execute. While there's nothing wrong with the exit-option in your menu.
I guess you copied it incorrectly to the forum-entry-box (?).

Anyways, I fixed it:

Code:

#!/bin/bash

echo -n "Your current IPaddress is: "
/sbin/ifconfig eth0 | grep inet|cut -d : -f 2|cut -d " " -f 1
echo

uptime
echo

echo "What do you want to do today?"
echo "1.Burn a cd"
echo "2.Erease a CD"
echo "3.Use instant messenger"
echo "4.Exit"
read A

if [ $A -eq 1 ]
then
    cdwrite.sh
fi

if [ $A -eq 2 ]
then
    cde.sh
exit
fi

if [ $A -eq 3 ]
then
    amsn
exit
fi

if [ $A -eq 4 ]
then
    exit
fi

Or better maybe:

Code:

#!/bin/bash

clear
echo -n "Your current IPaddress is: "
/sbin/ifconfig eth0 | grep inet|cut -d : -f 2|cut -d " " -f 1
echo

uptime

while true ; do
    echo
    echo "What do you want to do today?"
    echo "1.Burn a cd"
    echo "2.Erease a CD"
    echo "3.Use instant messenger"
    echo "4.Exit"
    read A

    case "$A" in
	"1") cdwrite.sh;;
	"2") cde.sh;;
	"3") amsn;;
	"4") exit 0;;
	*)   echo -e "\n==> Sorry, menu option not recognized.";;
    esac
done

# We should never get here...
exit 1

sleepwalker1.0 · 10-26-2002, 10:19 AM

Registered: Aug 2002
Location: Groningen, The Netherlands
Distribution: SuSE & Debian
Posts: 52

( post #2)
<quote>
There is more than one error in your script, like nested quotes, an extra "read A", and the ' [ ' and ' ] ' around the names of shell-scripts you want to execute. While there's nothing wrong with the exit-option in your menu.
I guess you copied it incorrectly to the forum-entry-box (?).
</quote>

sorry about the errors in the script, the one i use in linux is fine. I have no internet in linux (yet) and had to do a copy to mnt/windows/mydocuments and note pad did not split the code up right so i had to do the best i could with no "working" script in front of me. The script i have runs fine but yours is better code for sure. I need to work on that.
I can see the "exit 0" is better than the "exit" command i have.
I see also the "shorter" or "tighter" code looks better when reading.
The "case" statement is also cleaner.
The exit statement i had will exit the script but with errors. I got a unidentified token startment about the "fi" statement. dont understand i thought it would work myself. Oh well , thanks again.
Guess i just leave the "if and 'fi" alone and use more "case" when i can. lol

Hko · 10-26-2002, 10:47 AM

Quote:

Guess i just leave the "if and 'fi" alone and use more "case" when i can. lol

Note: There's absolutely nothing wrong with "if". That's not what I mean. (sorry if it sounded that way). Use "if -- fi" whenever you need it.
It's just that when scanning multiple values for a variable, "case" is often cleaner. Good Luck.