newbie bash programmer question

cashton2k · 03-04-2007, 06:52 PM

hi i'm tryin to make a simple script with bash but i keep gettin an error when i try and run the script on the line "Q|q) quit=yy;;"

I was wonderin if anyone cud help, it must be sumthin silly im missin

thanks for any help

jlliagre · 03-04-2007, 07:05 PM

The line with "done" before "Q|q) ..." should be "done ;;"

cfaj · 03-04-2007, 08:58 PM

Quote:

Originally Posted by cashton2k

hi i'm tryin to make a simple script with bash but i keep gettin an error when i try and run the script on the line "Q|q) quit=yy;;"

Code:

#!/bin/sh
#Filename: secondarynode
quit=n

location=$(echo $(pwd))

You don't need echo or any command substitution; if you need to store the output of pwd, you should use:

location=$(pwd)

However, you don't even need that, as the current directory is stored in $PWD:

location=$PWD

Quote:

Code:

while [  "$quit"   =   "n"  ];
do
  clear
  echo "Secondary Node Control Utility"
  echo
  echo
  echo "1. Activate Heartbeat and Failover System"
  echo "Q. Quit"
  echo
  echo "Enter choice:"
  read choice
  case $choice in
  1)  while [ "$BEAT" -eq 0 ];
      do
      dump=`ping -c 1 192.168.225.120`
      if [ ! $? == 0 ];
      then
      echo "WARNING: Primary Node is Dead"
      let BEAT=BEAT+1

I recommend using the portable, POSIX syntax for shell arithmetic:

BEAT=$(( $BEAT + 1 ))

Quote:

Code:

      else
      echo "Primary Node is Alive at:"
      fi
      done

You are missing the closing ';;' before the next case.

Quote:

Code:

  Q|q) quit=y;;
  *) echo "Invalid Selection!"
      sleep 1
   esac
done
echo "Program Closed"

I was wonderin if anyone cud help, it must be sumthin silly im missin

thanks for any help

cashton2k · 03-05-2007, 05:48 AM

cheers, thanks guys i got it going great

cashton2k · 03-05-2007, 01:48 PM

hey sorry bother folk again but im tryin to make a bigger menu system on another similar script is it possible to have a case with a another, my attempts so far have failed

Code:

#!/bin/sh
#Filename: nascontrol
quit=n

location=$(echo $(pwd))

while [  "$quit"   =   "n"  ]
do
  clear
  echo "Network Attached Storage Control Utility"
  echo
  echo "Your current location is: " $location
  echo
  echo "1. NFS Mount Space"
  echo "2. NFS Unount Space"
  echo "3. Check NFS Service Status"
  echo "4. Start NFS Service"
  echo "5. View Currently Exported Areas"
  echo "6. View Available Directories"
  echo "Q. Quit"
  echo
  echo "Enter choice:"
  read choice
  case $choice in
  1) echo "Please enter the directory you would like to export:"
     echo
     echo "Would you like include the current working directory?"
      read pwdquest
      case $pwdquest in
      Y|y) echo "Enter Directory under: $location"
           read sharedir
           echo
           exportfs -v  :$location/$sharedir
           echo "Directory has been Exported"
           echo
           echo "Hit Enter..."
                read junk;;
      N|n) echo "Enter full path of directory"
           read shareddir
           echo
           exportfs -v  :$sharedir
           echo "Directory has been Exported"
           echo
           echo "Hit Enter..."
                read junk;;
      *)    echo "Invalid choice!"
            sleep 1
         esac 
     done ;;
  2) echo "Please enter the directory you would like to unexport"
      read unsharedir
      exportfs -u :$unsharedir
      echo "Directory is no longer being exported"
      echo
      echo "Hit Enter..."
      read junk;;
  3)  service nfs status
      echo "Hit Enter..."
      read junk;;
  4)  service nfs start
      echo "Hit Enter..."
      read junk;;
  5)  showmount -e
      echo
      echo "Hit Enter..."
      read junk;;
  6)  dir
      echo
      echo "Hit Enter..."
      read junk;;
  Q|q) quit=y;;
   *) echo "Invalid choice!\07\07"
      sleep 1
   esac
done
echo "Program Exit Completed"

i get errors for the done on the second case

ygloo · 03-05-2007, 02:25 PM

..............

ygloo · 03-05-2007, 02:25 PM

You are missing the closing ';;'

Code:

      *)    echo "Invalid choice!"
            sleep 1
         esac

       *) echo "Invalid choice!\07\07"
             sleep 1
       esac

jlliagre · 03-05-2007, 02:32 PM

There was one "do" but two "done" in your script ...

Edited: Ygloo, please add some comments to your postings. An empty post or one with only code doesn't help figuring out where you are now with your script.

Thanks.

ygloo · 03-05-2007, 02:47 PM

you could add ";;" on a new line to make reading easier:

Code:

Y|y) echo "Enter Directory under: $location"
           read sharedir
           echo
           exportfs -v  :$location/$sharedir
           echo "Directory has been Exported"
           echo
           echo "Hit Enter..."
                read junk
           ;;

cashton2k · 03-05-2007, 03:09 PM

cheers again guys really appreciate it

cfaj · 03-05-2007, 03:51 PM

Quote:

Originally Posted by cashton2k

hey sorry bother folk again but im tryin to make a bigger menu system on another similar script is it possible to have a case with a another, my attempts so far have failed

Code:

#!/bin/sh
#Filename: nascontrol
quit=n

location=$(echo $(pwd))

location=$PWD

Note the difference:

Code:

$ time location=$PWD

real    0m0.000s
user    0m0.000s
sys     0m0.000s
$ time location=$( echo $(pwd))

real    0m0.010s
user    0m0.001s
sys     0m0.008s

Quote:

Code:

while [  "$quit"   =   "n"  ]
do
  clear
  echo "Network Attached Storage Control Utility"
  echo
  echo "Your current location is: " $location
  echo
  echo "1. NFS Mount Space"
  echo "2. NFS Unount Space"
  echo "3. Check NFS Service Status"
  echo "4. Start NFS Service"
  echo "5. View Currently Exported Areas"
  echo "6. View Available Directories"
  echo "Q. Quit"
  echo
  echo "Enter choice:"
  read choice
  case $choice in
  1) echo "Please enter the directory you would like to export:"
     echo
     echo "Would you like include the current working directory?"
      read pwdquest
      case $pwdquest in
      Y|y) echo "Enter Directory under: $location"
           read sharedir
           echo
           exportfs -v  :$location/$sharedir
           echo "Directory has been Exported"
           echo
           echo "Hit Enter..."
                read junk;;
      N|n) echo "Enter full path of directory"
           read shareddir
           echo
           exportfs -v  :$sharedir
           echo "Directory has been Exported"
           echo
           echo "Hit Enter..."
                read junk;;
      *)    echo "Invalid choice!"
            sleep 1
         esac 
     done ;;

i get errors for the done on the second case

What loop does that "done" close?