[SOLVED] Network Scripts Now On GitHub!

des_a · 12-22-2023, 12:17 AM

Hi everybody! Merry Christmas or Happy Holidays! I just wanted everyone to know, that I now have posted my set of scripts, just the LINUX side for now. This has been many years of long, hard work as well, and part of the reason I sent it, is so I have a great backup. It's on github.

www.github.com/smileynet000

They are designed for Linux Mint, but they probably work on other Linux systems too. Hopefully, this should explain and show you a bit about how the network stuff fits together, which you, as a community, have helped me work on. Now others can benefit from hard work, which has been put into these! Please review, and tell me what you think! Please tell me what you think of it. I'll keep it open for a bit, while you tell me what you think of it. Thanks!

NevemTeve · 12-22-2023, 12:40 AM

Thank you, and I wish Merry Christmass to you.

des_a · 12-22-2023, 10:14 PM

You're welcome.

ntubski · 12-23-2023, 09:58 AM

You meant to link to https://github.com/smileynet000/network_checks specifically, I guess?

Just looking at basic_internet_check.sh I'd suggest using a function to reduce the duplication a bit, e.g.,

Code:

check() {
    echo "$2"...
    ping -c 4 "$1" > /dev/null
    if [ $? -eq 1 -o $? -eq 2 ]; then
        exit 1
    fi
}

check 192.168.1.11 'Network DNS server'
check 192.168.2.1 'Clientrouter'
check 192.168.2.2 'Clientap'
check 192.168.1.2 'Mainap'
check 192.168.1.1 'Mainrouter'
check 192.168.0.1 'Mainrouter PFSense'

des_a · 12-23-2023, 06:49 PM

No. Not just network checks. That's why I posted the generic link. But I was refferring to ANY of my script repos. I'll take that, improvement if it's OK. But the reason, I didn't know to use a function, was I don't really know that part of the language well enough yet. Improvements and "show and tell", is why I put them up there. Is it OK to use the improvements?

ntubski · 12-23-2023, 08:21 PM

Quote:

Originally Posted by des_a

No. Not just network checks. That's why I posted the generic link. But I was refferring to ANY of my script repos.

Ah, okay, from the thread title I assumed it was just about the network ones.

Quote:

Is it OK to use the improvements?

Please do.

des_a · 12-24-2023, 11:49 AM

They are all origionally designed for my home network. Of course, when I posted them, I hoped that for other people, they would find all kinds of uses as well. More improvements to come after focusing on servers for awhile! There's a bunch of things, like an update system for the network, that I want to implement, as I've done at my Mom's businesses. I can't use exact code, because they are designed for windows. I have to translate it to bash or sh language, as I go, and make other adjustments to it.

des_a · 01-02-2024, 12:36 AM

I've implemented the changes, but not proprigated them out yet to github. I'm going to see if I can replace my laptop keyboard before I do that.

des_a · 01-02-2024, 12:37 AM

It's also been long enough now, so thanks for those who looked!

des_a · 01-30-2024, 03:11 AM

Now, I included copies of a basic, "settings" directory. The settings directory is like a custom /etc, which resides IN /etc. You can, like in all other cases, create a configuration specific to your enviroment. Have fun with my network scripts!

MadeInGermany · 01-30-2024, 06:28 AM

Quote:

Originally Posted by ntubski

...

Code:

check() {
...
        exit 1
...
}

This would exit the shell(-script).
Better just return from the function:

Code:

check() {
...
        return 1
...
}

ntubski · 01-30-2024, 08:19 AM

Quote:

Originally Posted by MadeInGermany

This would exit the shell(-script).
Better just return from the function:

The original exits from the script when any of the pings fails, so I was trying to replicate that behaviour. I suppose it could also be done with return and then set -e at the top level.

des_a · 02-05-2024, 07:30 AM

I do like the exit behavior. But that is pretty much why I put it on github. You can always help me with it by trying to come up with a complete patch to suggest, here or back on github. I would evaulate it, and see if I liked it enough to add it. I'm not checking here that often right now, as it's marked solved now, it had been awhile with no replies. And then if you don't like the path I'm taking, but find it useful, you could always fork it. I'm not so unhappy with the code, that I would want to use your fork though, unless it practically writes the moon. From the network script projects, I just wanted to make sure I could share, so I could a) become a better programmer and get more used to github, and b) Be able to have backups in case I lose my work locally, and c) Use the idea from others, that I can store my configuration on github, so others can benefit from it too. With these scripts, I can take Linux Mint, and by running them, have the system back up and running in a day or so, including the install. So things are pretty powerful!

des_a · 02-05-2024, 07:31 AM

P.S. - Having the system ready that fast was not possible with windows 10! Part of the reason this works, is the package manager.