JavaScript IF ELSE not functioning correctly! HELP

SangrelX · 08-30-2009, 02:19 PM

Ok guys this makes no sense to me so im hoping someone can spot the error

java code snipplet below

Code:

<script type="text/JavaScript">
addEvent(window, 'load', initCorners);
function initCorners() {
var setting = {
tl: { radius: 6 },
tr: { radius: 6 },
bl: { radius: 6 },
br: { radius: 6 },
antiAlias: true
}

var rbar = documentgetElementByID('r_sidebar')
var lbar = documentgetElementByID('l_sidebar')
var wrapped = documentgetElementByID('wrap')
var cleft = documentgetElementByID('contentleft')

if (rbar != r_sidebar) { 
}else{
curvyCorners(setting, ".r_sidebar");
}

if (lbar != l_sidebar) { 
}else{
curvyCorners(setting, ".l_sidebar");
}

if (wrapper != wrap) { 
}else{
curvyCorners(setting, ".wrap");
}

if (cleft != contentleft) { 
}else{
curvyCorners(setting, ".contentleft");
}



curvyCorners(setting, ".roundedCorners");
curvyCorners(setting, ".hrr");
curvyCorners(setting, ".content");
}
</script>

as you can see im trying to verify a Element ID Exists - if it doesnt Exist DO NOTHING if it DOES Exist then set the option for the function

Its not working properly no matter what i try it still sets the option and the function throws an error any page that the Element doesnt exist on?

any ideas?

paulsm4 · 08-30-2009, 02:28 PM

Hi -

1. Semicolons are good:

Code:

var rbar = documentgetElementByID('r_sidebar');

2. The test is too complex:

Code:

  // Poor
  if (rbar != r_sidebar) { 
  }else{
  curvyCorners(setting, ".r_sidebar");
  }

  // Better
  if (rbar == r_sidebar)
    curvyCorners(setting, ".r_sidebar");

3. You're not correctly testing for (the very real case!) "object not found":

Code:

  if ( (rbar) && (rbar == r_sidebar) )
    curvyCorners(setting, ".r_sidebar");

'Hope that helps .. PSM

PS:
Strong recommendation:
Install Firefox (if you haven't already) and install the Firebug debugger. It's totally indispensable!

SangrelX · 08-30-2009, 05:05 PM

Quote:

Originally Posted by paulsm4

Hi -

1. Semicolons are good:

Code:

var rbar = documentgetElementByID('r_sidebar');

2. The test is too complex:

Code:

  // Poor
  if (rbar != r_sidebar) { 
  }else{
  curvyCorners(setting, ".r_sidebar");
  }

  // Better
  if (rbar == r_sidebar)
    curvyCorners(setting, ".r_sidebar");

3. You're not correctly testing for (the very real case!) "object not found":

Code:

  if ( (rbar) && (rbar == r_sidebar) )
    curvyCorners(setting, ".r_sidebar");

'Hope that helps .. PSM

PS:
Strong recommendation:
Install Firefox (if you haven't already) and install the Firebug debugger. It's totally indispensable!

Paul-

I actually have tested it with semicolons - I forgot to put em back when I tested the method above again LOL..

I do alot of PHP coding and javascript is similar to it but it seems there are some differences I just have not learned yet

Im trying to expand my Javascript skills a bit lol

I had tried all the methods you showed me except the last one the

" testing for (the very real case!) "object not found":"

so ill give that a whirl.

thanks for the input

p.s. I have FireFox Just dont use it often and forgot totally about FireBug!!! (smacks self in head)

did not work !!! arg.

ok let me further explain this

I have say 2 pages

page 1 contains all the div ids that are listed in the javascript function for roundcorners

page 2 DOES NOT have division id contentleft, r_sidebar, l_sidebar, blah blah

HOW can I tell the javascript to CHECK if the div id exists BEFORE assign ing the settings to the roundcorners function?

because as it is now whenever a user travels to a page that does not contain the divisions it throws an error alert up! and well I cant have that lol

headrift · 08-30-2009, 08:12 PM

Quote:

Originally Posted by SangrelX

HOW can I tell the javascript to CHECK if the div id exists BEFORE assign ing the settings to the roundcorners function?

Done a try/catch block? It sounds like what you need. Something along these lines:

Code:

for(divId in divIdList){
  try{
    divId = document.getElementById(divId);
  }catch(ex){
    continue;
  }

  //  Do your stuff here
}

If devId doesn't pull an object, an error will be thrown and the loop will continue. Otherwise, the corner stuff is free to run.

...should work, but is kind of ugly. I don't like using exceptions to handle "normal" runtime situations. I personally would find a way to keep track of what ids are used in which pages. Much slicker.

SangrelX · 08-30-2009, 09:55 PM

Quote:

Originally Posted by headrift

Done a try/catch block? It sounds like what you need. Something along these lines:

Code:

for(divId in divIdList){
  try{
    divId = document.getElementById(divId);
  }catch(ex){
    continue;
  }

  //  Do your stuff here
}

If devId doesn't pull an object, an error will be thrown and the loop will continue. Otherwise, the corner stuff is free to run.

...should work, but is kind of ugly. I don't like using exceptions to handle "normal" runtime situations. I personally would find a way to keep track of what ids are used in which pages. Much slicker.

lol guys sorry to have wasted your time!!

I found a solution the RoundCorners script has a built in function that blocks alert messages for missing divs!

I scanned over their faq the other night and didnt see this tidbit so again I apologize for wasting your time

Thanks
SangrelX