Java

gomez6211 · 09-22-2006, 11:17 PM

I'm having problems getting a specific implementation of selection sort working. The pseudo code given is as follows:

FOR i = 0 TO n-2 DO
min = i
FOR j = i+1 TO n-1 DO
IF A[j] < A[min] THEN
min = j
swap(A[i], A[min])

my code is as follows:

for(int i = 0; i <= array.length-2; i++)
{
int min = i;
for (int j = i+1; j <= array.length-1; j++)
{
if(array[j] < array[min])
{
min = j;
comp_count++;
}
int temp = array[i];
array[i] = array[min];
array[min] = temp;
}
}

For some reason, it doesn't sort properly. I can't seem to find out where I made a mistake. I would appreciate if anyone could point out my mistake.

paulsm4 · 09-22-2006, 11:54 PM

Hi -

There's something wrong with your algorithm. Here's a slightly modified version that works (albeit with typical bubble sort lack of efficiency ;-)):

Code:

public class Bubble {

  public static void main (String[] args) {

    int[] array = { 3,7,1,5,3,8,2 };

    for (int i = 0; i < array.length-1; i++) {
      for (int j = 0; j < array.length-1-i; j++) {
        if (array[j+1] < array[j]) {
          int temp = array[j];
          array[j] = array[j+1];
          array[j+1] = temp;
        }
      }
    }

    for (int i = 0; i < array.length-1; i++) {
      System.out.println ("a["+ i + "]: " + array[i] + "...");
    }

  }      

}

'Hope that helps .. PSM

PS:
Please be sure you use "[code]" tags in future LQ posts!