I need help with my shutdown bash script, please help!

ranito1980 · 03-08-2013, 04:53 PM

Hell everyone. I'm a noob to bash scripting. I'm running LinuxMint 14 (Nadia). I've successfully created a bash script for cleaning out my ram, firefox caches (using shred), updating the OS, etc and at the tail end of the script I'd like to call a script I call shut.sh. However I keep getting errors when I try to run this script. I'm brand new to bash scripting using if...else statements so please help me out. What am I doing wrong?
------
#!/bin/bash
clear
echo "Shutdown?"
read what
if ["$what" = "y"];
then
shutdown -h now
elif ["$what" = "r"];
then
shutdown -r now
else
echo "Terminating Script. Thanks!"
fi

NevemTeve · 03-08-2013, 05:01 PM

What errors are you getting? Not everyone here is mind-reader. (And please use [code] and [/code] tags, when you paste code.)

PS: add some spaces, eg:

Code:

...
 if [ "$what" = "y" ];
...

kooru · 03-09-2013, 02:24 AM

You should write it into tag code and give us what error you get.
Anyway, as said by NevemTeve, you must insert some spaces for "if" syntax

David the H. · 03-09-2013, 11:42 AM

Please use ***[code][/code]*** tags around your code and data, to preserve the original formatting and to improve readability. Do not use quote tags, bolding, colors, "start/end" lines, or other creative techniques.

Processing of user input when using read and such is generally better done with a case statement.

And for simple multiple choice menus like this I'd suggest using a select loop.

Code:

#!/bin/bash

clear
PS3='What do you want to do?: '

select what in Shutdown Restart Abort; do

    echo "You selected: $what"

    case $REPLY in
        1) shutdown -h now ;;
        2) shutdown -r now ;;
        3) echo "Terminating script without action."
           break  ;;
        *) echo "invalid selection" ;;
    esac

done

exit 0

BTW, remember that shutdown requires that the user running the script have proper permission to do so.

Xeratul · 03-10-2013, 03:42 PM

spaces might be needed.

here it goes:

Code:

#!/bin/bash
clear
echo "Shutdown?" ; read what

if [ -f /sbin/halt ] ; then
  echo "Notice: you might also make use of halt since this file exists"
  # sudo -l ;)
fi

if [ "$what" = "y" ] ; then
     shutdown -h now
elif [ "$what" = "r" ] ; then
     shutdown -r now
fi
echo "Terminating Script. Thanks!"