I need a little help with "if test -r"

sancre · 11-16-2007, 03:22 AM

Hello

I need make a script in Linux. It don`t work when I have several files in the directory (it return ./script: line 1: test: too many arguments), only when I have one file it work fine. I need make several actions when I have files, but I have this problem. Can anybody help me.

this is the script

if test -r /ftp/GESTOP/AI/entrada/INV*
then
ftp prodinven > /home/sant/inven/log/ftp.log 2>&1
exit 0
else
exit 1
exit 0
exit 1
fi

thank you

acid_kewpie · 11-16-2007, 03:31 AM

when you put the star in, you expand it to all files matching it. so it becomes "if test -r filea fileb filec filed ...." which clearly makes no sense.... what do you expect a correct answer to that test to mean?

colucix · 11-16-2007, 03:33 AM

Code:

./script: line 1: test: too many arguments

The error message is clear enough: when the shell expands the wild character "*" it produces a statement like

Code:

if test -r /ftp/GESTOP/AI/entrada/INV_file1 /ftp/GESTOP/AI/entrada/INV_file2 /ftp/GESTOP/AI/entrada/INV_file3 ...

but multiple arguments is not permitted for the test command. You have to loop through the files and test them one at a time:

Code:

for file in /ftp/GESTOP/AI/entrada/INV*
do
   test -r $file && <your_command_here>
done

Edit: Sorry Chris for redundancy. As always you're too fast in replying!

sancre · 11-16-2007, 04:00 AM

Maybe I don,t explain correctly, because my english is very bad I need make things only when I have files INV* in this directory.
This is my complete script

if test -r `/ftp/GESTOP/AI/entrada/INV*`
then
/home/sant/inven/channame > /home/sant/inven/log/channame.log 2>&1
cd /home/sant/inven
/home/sant/inven/forjcl > /home/sant/inven/log/for.log 2>&1
ftp prodinven > /home/sant/inven/log/ftp.log 2>&1
rm /home/sant/inven/jclftp/INV.*
exit 0
else
exit 1
exit 0
exit 1
fi

acid_kewpie · 11-16-2007, 04:38 AM

if [ "$(ls /where/ever/ | wc -l)" -gt 0 ]
then
...
fi

sancre · 11-16-2007, 06:05 AM

Good, you example is ok, is valid for me,thank you for you help