Getopts script not working in redhat sh (works in sunos sh)

khandu · 02-15-2012, 03:35 PM

I have a script with works perfectly on SunOS machines with sh..

Here is a part of it which is not working on RedHat sh

config.sh

Code:

#!/bin/sh
..............
..............
# main

PATH=/usr/bin:/bin
export PATH

$HOSTNAME=`hostname`

while getopts t:a:D:w:r:h:p:i: name
do
  case $name in
    t)  TYPE=$OPTARG;if [ "$TYPE" != "abc" -o "$TYPE" != "xy" ]
                        then
                        usage
                        elif [ "$TYPE" = "abc" ]
                        then
                            PORT=3546
                            PATH="/srv/temp/$HOST_NAME"
                        elif [ "$TYPE" = "xy" ]
                        then
                                PORT=7854
                                PATH="/srv/temp/$HOST_NAME-xy"
                        fi;;
    a)  INSTTYPE=$OPTARG;;
    D)  DN=$OPTARG;;
    w)  PASSWORD=$OPTARG;;
    r)  MAN=$OPTARG;;
    h)  HOST_NAME=$OPTARG;;
    p)  PORT=$OPTARG;;
    i)  PATH=$OPTARG;;
    ?)  usage
        ;;
  esac
done

usage function is defined elsewhere and works fine

Now when I call the program as

Code:

./config.sh -t abc -a all .......

the -a does not get registered and nor does -p and -i

When I do

Code:

./config.sh -a all -t abc -p 5478 -i /srv/asd/casd .......

the value of -a gets registered in $TYPE but then the values of -i and -p does not get stored..

this script is working fine on a SunOS machine.. but not on RHEL

What is going wrong here? I want the script to run as

Quote:

./config.sh -t xxx -a xxx .... (t first)

In SunOS the

Quote:

[ "$TYPE" != "abc" -o "$TYPE" != "xy" ]

is actually

Quote:

[ $TYPE -ne abc -o $TYPE -ne xy ]

This has been changed in RHEL to avoide some errors i was getting

tronayne · 02-16-2012, 08:27 AM

I've found that enclosing an ${OPTARG} is double quotes is useful; e.g.,

Code:

aval="${OPTARG}"

For what it's worth here is the Korn Shell template I use for shell programs. Other than the "print" command it ought to work in the other shells (dunno, don't use BASH).

Code:

#!/bin/ksh
#ident  "$Id$"
#
#       Name:           $Source$
#       Version:        $Revision$
#       Modified:       $Date$
#       Purpose:        What does it do
#       Author:         You Name goes here
#       Date:           Today's date goes here
#       $Log$
#
#       define a fatal error function
function fatal
{
        print -u2 "${1}"
        exit 1
}
#       initialize flags to null
aflag=
bflag=
#       define usage message
USAGE="Usage:\t${0} [-a value] [-b value] args"
#       process command line arguments
while getopts :?a:b: name
do
        case ${name} in
        a)      aflag=1
                aval="${OPTARG}";;
        b)      bflag=1
                bval="${OPTARG}";;
        :)      print -u2 "${0}:\t${OPTARG} requires a value"
                fatal "${USAGE}";;
        \?)     print -u2 "${0}:\tunknown option"
                fatal "${USAGE}";;
        esac
done
if [ ! -z "${aflag}" ]
then
        print "Option -a ${aval} specified"
fi
if [ ! -z "${bflag}" ]
then
        print "Option -b ${bval} specified"
fi
shift $((${OPTIND}-1))
if [ "$*" ]
then
        print "Remaining arguments are:\t${*}"
fi
exit 0

Hope this helps some.