gcc, filecopy program ? (corrections)

frenchn00b · 09-10-2007, 02:45 PM

How can I update this program to make filecopy file1 to file2 ?

Code:

#include <stdio.h>
#define max 60
#define min 3
main()
{
        int count;
        int i;
        char name[max];
        char extname[]="jpg";
        FILE *fp;
        FILE*fp2;
        int c;
        int zero='0';

        printf("Please input the name of the file");
        scanf("%s",name);
        printf("\n");
        printf("Please input file count");
        scanf("%d",&count);
        printf("\n");

        fp=fopen("dmtmp","wr");
        for( i = 0; i < count ; i++){
                fprintf(fp,"%s",name);
                fprintf(fp,"%3d",i);
                fprintf(fp,"%3d",i+1);
                fprintf(fp,".%s",extname);
                fprintf(fp,"\n");
        }
       
        rewind(fp);
        fp2=fopen("dmlist","w");
       
        while((c = getc(fp)) != EOF){
                if ( c == ' ')
                        putc('0',fp2);
                else
                        putc(c,fp2);
        }

        fclose(fp);
        fclose(fp2);
}

Code:

#include <stdio.h>

main(int argc, char *argv[])
{
        FILE *fp;
        void filecopy(FILE * , FILE * );

        if ( argc == 1 )
                filecopy(stdin,stdout);
        else
                while ( --argc > 0)
                         if((fp=fopen(*++argv,"r")) == NULL ){
                                printf("cat:can'topen %s\n",*argv);
                                return 1;
                        }else{
                                filecopy(fp,stdout);
                                fclose(fp);
                        }
                        return 0;
}

void filecopy(FILE *ifp, FILE *ofp)
{
        int c;

        while ((c = getc(ifp)) != EOF)
                if(c == ' ')
                        putc('0',ofp);
                else
                        putc(c,ofp);
               
}

theNbomr · 09-10-2007, 11:14 PM

May I suggest reading from & writing to files in much larger blocks than single bytes? Why do you inspect every byte, and replace space characters with '0's? If you really need to do this, then your program function is probably about as good as it can be.

I'm not sure if function declarations are allowed the way you've done it, but it is more conventional to make the declaration file file-scoped, by putting the declaration outside of main(), or any other function. I suppose if the function calling the declared function is the only caller, it makes some sense. In that case, I would tend to make it a static function.

--- rod.