finding error

iqra · 06-17-2010, 05:53 AM

hiii...

i running a program of C heres one function in which i am getting an error.

Code:

void snmp()
{
int count;
char switch_val;
	printf(" start sending requests\n");
	printf(" select '1' to send get request\n");
	printf(" select '2' to send get next request");
	scanf( "%d", switch_val);
	
	switch(switch_val)
	{
		case '1':
			
			count=0;
			if (count==0)
			{
			get();
			}
			else getnext();
			count++;
			break;
		case '2':
			getnext();
			break;
			
					
		default:
			printf("OOooPPppssss");
			break;
	}

}

program always go in default case. i can not figure it out why it is happeing. i have used switch statements manny times but on linux i have never worked before so could not debug the error properly.

if i use integer values for cases (for exmaple case '1')
then after selecting any option it gives 'segmentation fault' error.

plzzzz tell me whats wrong with this code....!!!

Gavin Harper · 06-17-2010, 06:03 AM

The ' ' around the 1 and 2 in the switch imply that the switch ases are looking for items of type char which is why it isn't matching to the switch cases.

Remove the ' ' and it will recognise switch_val as an integer

iqra · 06-17-2010, 06:24 AM

switch_val is an integer
and i tried by removing ' ' it is giving segmentation fault error.

is it becasue of any problem in my get() and getnext() functions?
either choosing case 1 or case 2.... same error occurs..

if i take switch_val as a char then it keeps on going in default case

crts · 06-17-2010, 07:38 AM

Hi,

try the following (changes in bold and red)

Code:

void snmp()
{
int count;
int switch_val;
    printf(" start sending requests\n");
    printf(" select '1' to send get request\n");
    printf(" select '2' to send get next request");
    scanf( "%d", &switch_val);
    
    switch(switch_val)
    {
        case 1:
            
            count=0;
            if (count==0)
            {
            get();
            }
            else getnext();
            count++;
            break;
        case 2:
            getnext();
            break;
            
                    
        default:
            printf("OOooPPppssss");
            break;
    }

}

iqra · 06-17-2010, 08:00 AM

@ crts
thnx

i just tried this and it worked fine...
anyways thanx for help..

Gavin Harper · 06-17-2010, 09:16 AM

I totally missed that switch_val was declared as a char