Exception in thread "main" java.lang.StackOverflowError

Hello, when I run the following code I get the error Exception in thread "main" java.lang.StackOverflowError (Main.java:59) and I don't know how to fix it.

public class Main{

public static int r = 0;
public static int n;

public static final int i = 4;
public static final int j = 4;
public static int x = 0;
public static int y = 0;
public static boolean simetrica = true;
public static int [][] m = new int[i][j];

public static int tmp = 0;
public static boolean simetricaSuRaizCuadradaEntera = true;

public static void main(String[] args) {

n = 10;

m[0][0]=1;
m[1][0]=10;
m[2][0]=25;
m[3][0]=5;
m[0][1]=9;
m[1][1]=1;
m[2][1]=64;
m[3][1]=2;
m[0][2]=25;
m[1][2]=64;
m[2][2]=1;
m[3][2]=4;
m[0][3]=5;
m[1][3]=2;
m[2][3]=4;
m[3][3]=50;

Main prueba = new Main();

prueba.raizCuadradaEntera(n);
System.out.println(r);
prueba.esSimetrica(m);
System.out.println(simetrica);
prueba.esSimetricaSuRaizCuadradaEntera(m);
System.out.println(simetricaSuRaizCuadradaEntera);

}

public int raizCuadradaEntera(int n){

if (n == 0){
return n;
}else{
if ( (n >= (r*r)) && (n < (r+1)*(r+1)) ){
return(r);
}else{
r++;
return(raizCuadradaEntera(n));
}
}

}

public boolean esSimetrica(int [][] m){

if (m.length != m[0].length){
return false;
}
if (x != m.length - 1){
if (y == m[x].length - 1){
if (m[x][y] != m[y][x]){
simetrica = false;
}
x++;
y = 0;
esSimetrica(m);
}else{
if (m[x][y] != m[y][x]){
simetrica = false;
}else{
y++;
esSimetrica(m);
}
}
}

return simetrica;
}

public boolean esSimetricaSuRaizCuadradaEntera(int[][] m){

calcularRaices(m);
esSimetrica(m);
simetricaSuRaizCuadradaEntera = simetrica;
return simetricaSuRaizCuadradaEntera;
}

private int[][] calcularRaices(int [][] m){

if (x != m.length - 1){
if (y == m[x].length - 1){
n = m[x][y];
m[x][y] = raizCuadradaEntera(n);
x++;
y = 0;
calcularRaices(m);
}else{
n = m[x][y];
m[x][y] = raizCuadradaEntera(n);
y++;
calcularRaices(m);
}
}
return m;
}

}

3
false
Exception in thread "main" java.lang.StackOverflowError
at ....(Main.java:59)


Thanks for any suggestions

Looks like the none of the end conditions for the recursive call are being met
so you keep calling raizCudradaEntera with the same unadjusted value for n until the
stackoverflows.

public int raizCuadradaEntera(int n){

if (n == 0){
   return n;
   }else{
   
 if ( (n >= (r*r)) && (n < (r+1)*(r+1)) ){
   return(r);
  }else{
  
 r++;

 return(raizCuadradaEntera(n));
}
}

}

Thanks for your post.
I made some modification, but my level of programming isn't very good and I haven't fixed the error. If you could help me I would appreciate that.

Thanks for any suggestions

public class Main{

public static int r = 0;
public static int n;

public static final int i = 4;
public static final int j = 4;
public static int x = 0;
public static int y = 0;
public static boolean simetrica = true;
public static int [][] m = new int[i][j];

public static int tmp = 0;
public static boolean simetricaSuRaizCuadradaEntera = true;

public static void main(String[] args) {

n = 10;

m[0][0]=1;
m[1][0]=10;
m[2][0]=25;
m[3][0]=5;
m[0][1]=9;
m[1][1]=1;
m[2][1]=64;
m[3][1]=2;
m[0][2]=25;
m[1][2]=64;
m[2][2]=1;
m[3][2]=4;
m[0][3]=5;
m[1][3]=2;
m[2][3]=4;
m[3][3]=50;

Main prueba = new Main();

prueba.raizCuadradaEntera(n);
System.out.println(r);
prueba.esSimetrica(m);
System.out.println(simetrica);
prueba.esSimetricaSuRaizCuadradaEntera(m);
System.out.println(simetricaSuRaizCuadradaEntera);

}

public int raizCuadradaEntera(int n){

if (n == 0){
return n;
}else{
if ( (n >= (r*r)) && (n < (r+1)*(r+1)) ){
return(r);
}else{
r++;
raizCuadradaEntera(n);
}
}
return(r);

}

public boolean esSimetrica(int [][] m){

if (m.length != m[0].length){
return false;
}
if (x != m.length - 1){
if (y == m[x].length - 1){
if (m[x][y] != m[y][x]){
simetrica = false;
}
x++;
y = 0;
esSimetrica(m);
}else{
if (m[x][y] != m[y][x]){
simetrica = false;
}else{
y++;
esSimetrica(m);
}
}
}

return simetrica;
}

public boolean esSimetricaSuRaizCuadradaEntera(int[][] m){

calcularRaices(m);
esSimetrica(m);
simetricaSuRaizCuadradaEntera = simetrica;
return simetricaSuRaizCuadradaEntera;
}

private int[][] calcularRaices(int [][] m){

if (x != m.length - 1){
if (y == m[x].length - 1){
n = m[x][y];
raizCuadradaEntera(n);
m[x][y] = r;
x++;
y = 0;
calcularRaices(m);
}else{
n = m[x][y];
raizCuadradaEntera(n);
m[x][y] = r;
y++;
calcularRaices(m);
}
}
return m;
}

}

public int raizCuadradaEntera(int n){

if (n == 0){
return n;
}else{
if ( (n >= (r*r)) && (n < (r+1)*(r+1)) ){  // This line
return(r);
}else{
r++;
raizCuadradaEntera(n);
}
}
return(r);

}

Running your code: eventually n=5 and r=5, you test will never be true
from now on. You increment r then call raizCuadradaEntera(5);
Now n=5 and r=6
The test obviously fails, you increment
r then call raizCuadradaEntera(5);
n=5 now and r = 7
and so on stuck in the recursive call.

Modify the conditions and variable adjusts so
that the you can get out of the recusrion.

Thank you very much! : D
I think I've managed to fix.
I have another problem .... : S

m [0] [0] = 1;
m [1] [0] = 10 / / would have to be 9 to be symmetrical, but applying the serious raizCuadradaEntera = 3, then [1] [0] = [0] [1] and would be true, but it comes out false
m [2] [0] = 25;
m [3] [0] = 5;
m [0] [1] = 9 -> 3
m [1] [1] = 1;
m [2] [1] = 64;
m [3] [1] = 2;
m [0] [2] = 25;
m [1] [2] = 64;
m [2] [2] = 1;
m [3] [2] = 4;
m [0] [3] = 5;
m [1] [3] = 2;
m [2] [3] = 4;
m [3] [3] = 50;

Thank you very much!
I think I've managed to fix.
I didn't modify this line because using only this method works correctly. I modified the following:

private int[][] calcularRaices(int [][] m){

if (x != m.length - 1){
if (y == m[x].length - 1){
n = m[x][y];
r = 0;
raizCuadradaEntera(n);
m[x][y] = r;
x++;
y = 0;
calcularRaices(m);
}else{
n = m[x][y];
r = 0;
raizCuadradaEntera(n);
m[x][y] = r;
y++;
calcularRaices(m);
}
}
return m;
}



I have another problem .... : S

m [0] [0] = 1;
m [1] [0] = 10 // It would have to be 9 to be symmetrical, but applying raizCuadradaEntera -> 3, then [1][0] = [0][1] and would be true, but it comes out false.
m [2] [0] = 25;
m [3] [0] = 5;
m [0] [1] = 9 -> 3
m [1] [1] = 1;
m [2] [1] = 64;
m [3] [1] = 2;
m [0] [2] = 25;
m [1] [2] = 64;
m [2] [2] = 1;
m [3] [2] = 4;
m [0] [3] = 5;
m [1] [3] = 2;
m [2] [3] = 4;
m [3] [3] = 50;

My level of English is regular, forgive me if I write something wrong.