error: ‘for’ loop initial declaration

nasim751 · 06-07-2008, 12:03 AM

hello,
how you will deal this problem

error: ‘for’ loop initial declaration used outside C99 mode

Code:

#include <stdio.h>
#include <stdlib.h>
#include <errno.h>
#include <string.h> 
#include <netdb.h>
#include <netinet/ip.h>
#include <netinet/in.h>
#include <netinet/ip_icmp.h>
#include <sys/socket.h>
#include <netdb.h>
#include <netinet/in.h>
#include <arpa/inet.h>
//#include <iostream.h>
#include <sys/types.h>
#include <unistd.h>

unsigned short in_checksum(unsigned short*,int );
void counter(unsigned int);
void banner(void);


int main(int argc,char **argv)
{
banner();

int sockfd;
const int on = 1;
int datalen, packlen, targetlen;
datalen = 0;

char *targetip;
char *broadcastip;

char readbuffer[1500];
char sendbuffer[1500];

struct sockaddr_in broadcast,target;

struct iphdr *ipheader;
struct icmp *icmpheader;

if(argc != 3)
{
printf("\n\nbash#./rurf <Target> <Broadcast>\n\n");
return (-1);
}

if((sockfd = socket(AF_INET, SOCK_RAW, IPPROTO_RAW)) < 0)
{
printf("\n\n Are you root?\n\n");
return 0;
}

setsockopt(sockfd, SOL_SOCKET, SO_BROADCAST, &on, sizeof(on));

broadcastip = argv[2];
targetip= argv[1];

broadcast.sin_family = AF_INET;
broadcast.sin_family = htons(0);
if(inet_pton(AF_INET, broadcastip, &broadcast.sin_addr) <= 0)
  {
   printf("\n\nFehler: inet_pton() broadcastip\n\n");
   return 0;
  }
if(inet_pton(AF_INET, targetip, &target.sin_addr) <= 0)
  {
   printf("\n\nFehler: inet_pton() targetip\n\n");
   return 0;
  }

ipheader = (struct iphdr *)sendbuffer;
icmpheader = (struct icmp *) (sendbuffer + sizeof(struct iphdr)); 

ipheader->ihl = 5;
ipheader->version = 4;
ipheader->tos = 0;
ipheader->tot_len = htons(sizeof(struct iphdr) + sizeof(struct icmp) + 
                          datalen);
ipheader->id = 0; 
ipheader->frag_off = 0;
ipheader->ttl = 200;
ipheader->protocol = IPPROTO_ICMP;
ipheader->check = in_checksum( (u_short *)ipheader, sizeof(struct iphdr));  
ipheader->saddr = target.sin_addr.s_addr;
ipheader->daddr = broadcast.sin_addr.s_addr;


printf("\n\nPing from <<argv[1]<< to the broadcast <<argv[2]<< are sent");
printf("\nPings: ");
printf("0000000000");

for(unsigned int i= 0;;i++)
{
icmpheader->icmp_type = ICMP_ECHO;
icmpheader->icmp_code = 0;
icmpheader->icmp_seq = i;
icmpheader->icmp_cksum = in_checksum( (u_short *)icmpheader, 
                                    sizeof(struct icmp) + datalen);


sendto(sockfd,sendbuffer,sizeof(struct iphdr) + sizeof(struct icmphdr) 
      + datalen,0,(struct sockaddr *)&broadcast,sizeof(struct sockaddr));
counter(i);
 
}
printf("\n");
return 0;
}

paulsm4 · 06-07-2008, 12:08 AM

Code:

int 
main(int argc,char **argv)
{
  banner();

  int sockfd;
  const int on = 1;
  int datalen = 0, packlen = 0, targetlen = 0;
  unsigned int i = 0;
  ...
  for(i= 0; ; i++)
  {
    icmpheader->icmp_type = ICMP_ECHO;
    icmpheader->icmp_code = 0;
    icmpheader->icmp_seq = i;
    ...

kapsikum · 06-07-2008, 12:33 AM

if you are using gcc, the declaration is not understood by iso c90 which is by default. optionally, you can also use -std=c99 option to tell your compiler to enable c99 flag to understand c99 features. This will solve your this problem but others may creep in.

taylor_venable · 06-07-2008, 10:31 AM

Even though the most recent GCC doesn't have *total* C99 support, it does provide lots of useful features and I would recommend that you use it. Additionally, GCC's C99 mode should be backwards compatible with C90 and thus should not introduce additional problems (other than warnings) for compiling code written in C90. It's for good reason that systems like FreeBSD have moved over to an increasingly C99 (with the ever-closer goal of a totaly C99) codebase.