Could someone tell me what's wrong with my shell script please?

RowanB · 11-11-2004, 08:32 PM

Hi, I'm trying to write a shell script that allows the user to enter an arbitrary number of values and then returns the sum of all the values entered. The following happens when I try to run the script. Can someone tell me what I am doing wrong please? Help appreciated!

Enter the number of numbers you want to add together
6
Enter number
1
./sum3.txt: line 6: [: too many arguments

Here is my script:

#!/bin/sh
s=1
sum=0
echo "Enter the number of numbers you want to add together"
read N
while [ $s -le $N ]
do
echo "Enter number"
read D
sum='expr $sum + $D'
s='expr $s + 1'
done
echo "Answer = $sum'

randyding · 11-11-2004, 09:31 PM

Some problems I see...
1) The line sum='stuff' should use back quotes instead of single quotes
2) The line s='stuff', same as above
3) the last echo line should end in a double quote to match opening quote

RowanB · 11-11-2004, 09:49 PM

OK, that's a bit of progress. Now this is what happens:

Enter the number of numbers you want to add together
3
Enter number
4
./sum3.txt: line 6: [: too many arguments
Answer = expr 0 + 4

homey · 11-11-2004, 10:49 PM

How about this ...

Code:

#!/bin/sh
s=1
sum=0
echo "Enter the number of numbers you want to add together"
read num
while [ $s -le $num ]
do
echo "Enter number"
read stuff
sum=`expr $sum + $stuff`
s=`expr $s + 1`
done
echo "Answer = $sum"

RowanB · 11-11-2004, 11:17 PM

Quote:

Originally posted by homey
How about this ...

Code:

#!/bin/sh s=1 sum=0 echo "Enter the number of numbers you want to add together" read num while [ $s -le $num ] do echo "Enter number" read stuff sum=`expr $sum + $stuff` s=`expr $s + 1` done echo "Answer = $sum"

Brilliant. Thanks a lot.