[SOLVED] Continuous loop

pedropt · 10-14-2022, 06:43 AM

Hi everyone , i am building here a script but i have a problem controling a variable in it , it looks that the variable always return to 1 when it loops .

A simple code :

Code:

cntdir="5"
function count () {

#This if statement also must be here
if [[ "$i" -gt "5" ]]
then
exit 0
fi
for i in $(seq "$cntdir")
do

#I need to have this next code to control the position of i
# this next line should add +1 to current i value , and it does but when it
# loops the code in count then changes it to 1 again
echo "i value is $i"
i=$((i+1))
echo "i value now is $i"
count
done
}
count

I need to control the variable "i" but every time it finishes the code and return it goes to 1 again instead the next number .
This is an eternal loop , and the problem is that i can not control the i variable by adding +1 to i .

Any ideas ?

NevemTeve · 10-14-2022, 07:30 AM

Did you make your `count` function recursive deliberately?

michaelk · 10-14-2022, 07:32 AM

You are calling your function from within the loop which means the sequence starts from 1 and therefore i=1 regardless.

If you want to control i use a while true loop instead of a for. It would help to know what you a trying to accomplish with the function.

pedropt · 10-14-2022, 09:49 AM

Quote:

Originally Posted by NevemTeve

Did you make your `count` function recursive deliberately?

yes , this is an example .

i variable starts at 1 with a sequence to 5 , but inside the code i add another 1 to the i var ,
witch means that 1+1 =2 , so i should be at 2 when it loops again in the "for" sentence , however i believe that this is not working because the loops "For" never reaches the "Done" command to start the next sequence witch is 2 , so no matter what i do , if the loop command does not finish by itself then i will be always 1 .

I made a different approach to the code here and already fixed my issue , i added additional functions to allow the loop work correctly , however if i post these changes here it will not make any sense because i need to post the full script witch already goes in 385 lines of code , because no one will understand unless they start to read the code from the beginning .

Best way is to remove this thread because definitively the "for" loop must run until the "done" to follow to the next sequence , if not reaches "done" instruction witch tells the code that first sequence is finished and can go to next sequence then it will never work .

michaelk · 10-14-2022, 10:06 AM

Code:

for i in $(seq "$cntdir")
do
#I need to have this next code to control the position of i
# this next line should add +1 to current i value , and it does but when it
# loops the code in count then changes it to 1 again
echo "i value is $i"
i=$((i+1))
echo "i value now is $i"
count <-- starts function over again which resets i -->
done

Your correct the loop never reaches "done" because you keep starting the function over. Without extra context the example script does not make much sense but here is one way to "fix" it.

Code:

#!/bin/bash
cntdir="5"
i=1

function count {
#This if statement also must be here
if [[ "$i" -gt "5" ]]
then
  exit 0
fi

while true
do
  echo "i value is $i"
  i=$((i+1))
  echo "i value now is $i"
  count
done
}
count

NevemTeve · 10-14-2022, 10:20 AM

@OP I think your code just makes no sense; if you explained what problem X is, maybe we could suggest something.

pedropt · 10-14-2022, 10:26 AM

Thank you for the code , works perfectly .