I tried to write a code in which the user is supposed to supply the directory name from the command prompt and the list all the files in that directory & filename is displayed only if the size of the file is greater than zero.

when i execure the above code it displays nothing.
where 11ce is the script file and 'exercises' is the directory .
Both script and directory(exercises in this case ) is kept in the same folder.

Where to edit so that the above code produces some output?

How about
First, all items specified on the command line are saved into array list. Note that this preserves all file names, including those with whitespace.

If none were specified, . (current directory) is used instead.

The find command will look at all files and directories listed in the list array. For directories, it will check their contents, but will not descend into subdirectories. (-maxdepth 0 would tell find to only look at the parameters specified, and not check any directories at all.)

The find command will output the names of all normal files that are not zero-byte-sized.

A quick note about these:

A for loop will default to the current parameter list, so "in $*" is redundant. Also "$@" should be used instead of "$*" in this kind of situation anyway, as you want a series of individual parameters instead of a single string.

As for the second one, you should almost never need to use ls to process a list of files. Regular shell globbing will do the job better.

Be sure to quote any variable expansions that may contain spaces or other reserved characters in them, to avoid word splitting.

1 members found this post helpful.

How about if the files printed should be of size greater than 1000bytes.
where

indicates those files whose size is greater than zero. But if required files of size greater than 1000bytes ,where to make changes then.?

Also I tried to count the number of files in the directory and for it I did these changes:

But it generates error :
What to do?

Pay attention to the error message in the output. You have a syntax mistake in line 14. There can be no spaces around the equals sign when setting a variable.

And again as I cautioned, quote all variable expansions unless you want word-splitting to occur. This is doubly true inside [..] tests. Consider using bash's more advanced [[..]] test operator instead, which doesn't do word-splitting on variables.

"$@" should almost always be quoted too, which will act as if each expanded element is quoted separately. But as I also pointed out, you don't need to use it at all when feeding a for loop.

When doing purely arithmetical operations and comparisons on integers, don't use expr, use $((..)), or ((..)) when no output is required. Things get more complex if you have floating point numbers, as bash can't handle them internally. Then you have to use an external tool like bc or awk.

Note also the $ isn't needed for variables inside arithmetic fields. All non-integer/non-math strings will be automatically interpreted as variables.

To alter your code, you need to get the file size from somewhere and test that. I recommend stat.

Finally, you should get into the habit of using a clean indentation and formatting style, and use liberal comments. Scripts are much easier to debug when they're easily readable.

Here's an example with my suggested modifications.
Of course I'm really only doing this for educational purposes. For real work, something using find like NA's code above would probably be more useful.

1 members found this post helpful.

What if the file names to printed in ascending order?
What change to make then?

Use the sort command.

1 members found this post helpful.