Check if time legal in tcsh....

DoME69 · 10-07-2019, 07:00 AM

Hi,

I want to verify that time is legal.
For example 23:00 = legal
25:00 = not legal.

When running the below code, of course I don't want to get the error message when time is not legal.

I tried to use the below but need you help since it's failed.

Quote:

if (`/bin/date -d "$arg" >& /dev/null` == "") then
echo "\nError: Time $argv[1] not legal time"
exit
endif

TB0ne · 10-07-2019, 07:33 AM

Quote:

Originally Posted by DoME69

Hi,
I want to verify that time is legal.
For example 23:00 = legal
25:00 = not legal.
When running the below code, of course I don't want to get the error message when time is not legal. I tried to use the below but need you help since it's failed.

Code:

if (`/bin/date -d "$arg" >& /dev/null` == "") then
echo "\nError: Time $argv[1] not legal time"
exit
endif

You've been a member here for ELEVEN YEARS, and have been asking about scripting for many years; you were also asked to use CODE tags and not QUOTE tags on scripts as well. And saying "since it's failed", tells us nothing. What is the message you're getting, and where is the rest of the script?

You're missing a backslash to close a double-quote, you have $arg AND $argv[1] in use. Show us the rest of the script, and give us a real error message. Also, if you really want to validate a user-input time ONLY (that is, just "18:44" or "23:58", vs. "2019-09-29:06:00:00"), you need to split both parts apart and validate them.

DoME69 · 10-07-2019, 07:53 AM

Sorry,

I want to add this section to long script and it independence section from the rest of the script.

While running the below code I always get error message: "/bin/date: invalid date `25:00'"
I tried to send it to /dev/null but the variable don't set with that option.

Code:

set arg = $argv[1]

set check_time_exist = `/bin/date -d $arg`

if ( "$check_time_exist" == "" ) then
echo "\nError: Time $argv[1] not legal time"
exit
endif

TB0ne · 10-07-2019, 08:00 AM

Quote:

Originally Posted by DoME69

Sorry,
I want to add this section to long script and it independence section from the rest of the script.

Then you need to post it when it can run by itself, stand-alone. We can't guess as to the rest of your script, what it feeds in/out, etc., and based on what you posted, it won't work AT ALL.

Quote:

While running the below code I always get error message: "/bin/date: invalid date `25:00'" I tried to send it to /dev/null but the variable don't set with that option.

Code:

set arg = $argv[1]

set check_time_exist = `/bin/date -d $arg`

if ( "$check_time_exist" == "" ) then
echo "\nError: Time $argv[1] not legal time"
exit
endif

Again, what you posted won't work on its own, and doesn't show us how the FIRST piece of code ties in to this one. And what shell are you writing this in? Bash? KSH? CSH???

Ser Olmy · 10-07-2019, 08:02 AM

I'm not a tsch/csh user, but a quick Google search for "tsch if statement" quickly revealed the correct syntax:

Code:

if ! ( { /bin/date -d "$argv[1]" >& /dev/null } ) then
  echo fatal: $argv[1]: invalid time
  exit
endif

Here, the if statement acts on the exit code of date.

You could also simply run date -d first, and then check the $status variable (similar to $? in bash) for the exit code.

(BTW, this isn't really a good way to check whether a string contains a valid time, since date -d will happily accept strings containing a combination of dates and time.)

DoME69 · 10-07-2019, 09:41 AM

Quote:

Originally Posted by Ser Olmy

I'm not a tsch/csh user, but a quick Google search for "tsch if statement" quickly revealed the correct syntax:

Code:

if ! ( { /bin/date -d "$argv[1]" >& /dev/null } ) then
  echo fatal: $argv[1]: invalid time
  exit
endif

Here, the if statement acts on the exit code of date.

You could also simply run date -d first, and then check the $status variable (similar to $? in bash) for the exit code.

(BTW, this isn't really a good way to check whether a string contains a valid time, since date -d will happily accept strings containing a combination of dates and time.)

Thanks for your help...

While running this if I get error when trying to use 25:00

Code:

/bin/date: invalid date `25:00'

Ser Olmy · 10-07-2019, 09:51 AM

Quote:

Originally Posted by DoME69

While running this if I get error when trying to use 25:00

Code:

/bin/date: invalid date `25:00'

Seems there's an issue with using redirection inside an if ( { } ) statement.

It does work if you run the command on its own, so just do that and check $status afterwards.

TB0ne · 10-07-2019, 09:57 AM

Quote:

Originally Posted by DoME69

Thanks for your help...
While running this if I get error when trying to use 25:00

Code:

/bin/date: invalid date `25:00'

For bash:

Code:

#!/bin/bash
TIME="$1"
if 
[[ $TIME != "" ]] && \
[ ${TIME%:*} -le 23 -a ${TIME%:*} -ge 0 -a \
        ${TIME#*:} -le 59 -a ${TIME#*:} -ge 0 ]; then
        echo ok
else 
        echo NOT ok
fi

Validates HH:MM time using regex. Can't have more than 23 for the first two digits, and more than 59 for the second two. Should be easy to follow.

DoME69 · 10-07-2019, 10:04 AM

I wrote it in tcsh as mention in the subject.
can you guide me how to do it in tcsh?

michaelk · 10-07-2019, 10:13 AM

Code:

#!/bin/tcsh

set number=$argv[1]
echo $number
if ( $number =~ [0-2][0-3]:[0-5][0-9] ) then
  echo "time is valid"
else
  echo "not valid"
endif

Lots of ways, it just depends on what you are actually trying to accomplish. In this example hours must be a two digit value.

Ser Olmy · 10-07-2019, 10:18 AM

Quote:

Originally Posted by michaelk

Code:

#!/bin/tcsh

set number=$argv[1]
echo $number
if ( $number =~ [0-2][0-3]:[0-5][0-9] ) then
  echo "time is valid"
else
  echo "not valid"
endif

Not quite:

Code:

~$ ./test 12:00
12:00
time is valid
~$ ./test 23:00
23:00
time is valid
~$ ./test 14:00
not valid
~$

TB0ne · 10-07-2019, 10:32 AM

Quote:

Originally Posted by DoME69

I wrote it in tcsh as mention in the subject. can you guide me how to do it in tcsh?

We are trying to; again, you have been here for ELEVEN YEARS, and have been asking about such things for at least five. Certainly after all this time a simple if/then shouldn't be hard.

The example given in bash, can be easily modified using what michaelk provided, and be used for what you're after. His example should easily be enough to 'guide you'.

michaelk · 10-07-2019, 10:39 AM

Quote:

Originally Posted by Ser Olmy

Not quite:

Code:

~$ ./test 12:00
12:00
time is valid
~$ ./test 23:00
23:00
time is valid
~$ ./test 14:00
not valid
~$

Ouch, nevermind that method...

TB0ne · 10-07-2019, 10:44 AM

Quote:

Originally Posted by michaelk

Ouch, nevermind that method...

Well, that is a 100% valid *EXAMPLE* of how to do this, which should 'guide' the OP. Only needs to modify the test-parameter regex. That's why I split my regex, and test the first two digits separately from the second. Anything less than 23 for the first two is valid...less than 59 for the second is valid. Either test fails, and you have a bad time.

Should be able to split based on the colon, break it into HRS and MIN variables, and do a simple less-than to test.

michaelk · 10-07-2019, 10:49 AM

Quote:

Originally Posted by TB0ne

Well, that is a 100% valid *EXAMPLE* of how to do this, which should 'guide' the OP. Only needs to modify the test-parameter regex.

True, although your example is probably easier to understand...