Can 't compile because long string is involved

Linh · 06-11-2003, 04:43 PM

On Line 29, all actual the codes is on one line, so no carriage return character (\) is there.

On line 30, it ended with a carriage return character (\)
On line 31, it ended with a carriage return character (\)

======================================
root:~# gcc -o test1 test1.c
test1.c: In function `main':
test1.c:30: malformed floating constant
test1.c:30: invalid operands to binary /
test1.c:30: parse error before `suid'

Line 30 is where the problem is

======================================
1#include <stdio.h>
2#include <stdlib.h>
3#include <string.h>
4#include <sys/types.h>
5#include <sys/stat.h>
6#include <unistd.h>

7int main()

8{

9 FILE *file_pointer;
10 int i = 0;
11 char single_char;
12 char word[15];
13 int result = 99;

14 file_pointer = popen("cat /etc/yellowbox/network-config|grep FIREWALLGROUP | awk '{print $1}'", "r");

15 single_char = getc(file_pointer); /* read first character */
16 while(!feof(file_pointer) && single_char != '\n')
17 {
18 word[ i ] = single_char;
19 printf("i = %d %c\n", i, word[ i ]);
20 i++;
21 single_char = getc(file_pointer);
22 }
23 word[ i ] = '\0';

24 printf("word = %s\n", word);
25 result = strcmp (word, "FIREWALLGROUP=0");
26 printf("result = %d\n", result);
27 if (result == 0)
28 {
29 printf("the value of the array word match that of the literal
FIREWALLGROUP=0\n");

30 system("/usr/suid/webofc/getdata | suid-to webofc ssh
`grep /"^10.0.0.1/" \
31 /etc/hosts | head -n 1 | awk '{print $4}`' -C \
32 /"suid putdata update && suid updatefirewall && suid updatemirrorhosts/"");
33 }
34 }
==========================================

kev82 · 06-11-2003, 04:49 PM

the \ character is a line break in a shell, it does not work in c. you can either put the whole string on one line or do it like this:

printf("This s"
"string is spl"
"it over lots "
"of lines.");

Linh · 06-11-2003, 05:17 PM

36) system(""/usr/suid/webofc/getdata | suid-to webofc ssh `grep "^10.0.0.1""
37) "/etc/hosts | head -n 1 | awk '{print $4}`' -C"
38) "suid putdata update && suid updatefirewall && suid updatemirrorhosts");
================================

root:~# gcc -o test1 test1.c
test1.c:38: unterminated string or character constant
test1.c:36: possible real start of unterminated constant

===============================

I even try this too where everything is in one line

36) system("/usr/suid/webofc/getdata | suid-to webofc ssh `grep "^10.0.0.1" /etc/hosts | head -n 1 | awk '{print $4}`' -C suid putdata update && suid updatefirewall && suid updatemirrorhosts");

test1.c: In function `main':
test1.c:36: malformed floating constant
test1.c:36: invalid operands to binary ^
test1.c:36: parse error before string constant

Hko · 06-11-2003, 05:52 PM

You have double quotes ( " ) inside the string (in the grep command). And double quotes are also the delimiters of string (characters arrays) in C.
To have double quotes inside a string you have to use double double quotes. (In this case you could also use single quotes around the regexp in the grep command. single single quotes, or single back quotes are fine)

Summary of your program (also using the other tip kev82 mentioned, and with an error of swapped single quote and back quote fixed that your command has at the end of the awk command):

Code:

#include <stdlib.h>

int main ()
{
        system("/usr/suid/webofc/getdata | suid-to webofc "
               "ssh `grep ""^10.0.0.1"" /etc/hosts | head -n 1"
               "| awk '{print $4}'` -C suid putdata update && "
               "suid updatefirewall && suid updatemirrorhosts");
        return 0;
}