bash simple test with posix character class

osio · 01-21-2006, 05:51 AM

I'd like to echo all files containing capital letters in their file names, but the script below echos all the files in the directory!:

Code:

#!/bin/bash
for i in *
   do
      if [[ "Si" != *[[:upper:]]* ]]
      then
         continue
      else
         echo $i "HAS a Capital letter in its filename!"
      fi
   done

What's wrong with the test?
Thanks!
Osio

druuna · 01-21-2006, 06:07 AM

Hi,

You probably made a typo.

"S1" should be "$i"

Hope this helps.

osio · 01-21-2006, 06:26 AM

druuna, thanks but no, there is no "1" in the script, I checked again.
If the directory has these files
cApItAl
CaPiTaL
lower
when i run the script above I get:
cApItAl HAS a Capital letter in its filename!
CaPiTaL HAS a Capital letter in its filename!
lower HAS a Capital letter in its filename!

druuna · 01-21-2006, 06:30 AM

Hi,

That's my typo, sorry

"Si" should be "$i" (capital S vs dollar sign)

if [[ "Si" != *[[:upper:]]* ]]
should be
if [[ "$i" != *[[:upper:]]* ]]

Sorry for the confusion.

osio · 01-21-2006, 06:57 AM

Ouch, yes, I should have checked that. Thanks!
I've realised that the script overwrites files if used to rename files: 'CaPiTaL' is moved to 'capital' but 'cApItAl' as well, so the first file converted to lower case is lost.
I wrote the pseudo-code below to assign increasing digits to the multiple occurences of the same filename in lower case but I'm getting nowhere. Nested loops are far beyond my reach:

Code:

#!/bin/bash
for i in *do
      if [[ "$i" != *[[:upper:]]* ]]
      then
         continue
      else
         identical=`ls | grep "$i" | wc`
         if [ $identical == 1 ]
         then
             mv $i $(echo $i | tr [:upper:] [:lower:])
         else
             # whatever, I'm lost here
             N=0
             # still lost
             mv $i ${i%%*}(N+1)
         fi
   done

chrism01 · 01-22-2006, 07:23 PM

Actually, wc on it's own rtns 3 nums: lines words chars.
What you need is
wc -l
ie num of filenames that match. (pseudo-code)
If result (ie wc -l) > 1, add 1 to result, append num to old_filename and cvt old_filename to lower (ie new filename). Move old file -> new file