BASH Shell Scripting -- foreach file in folder???

AC97Conquerer · 03-24-2005, 12:47 PM

I've got this:

Code:

#!/bin/bash

foreach file _BadMaps
	echo "$file"
end

But I get this as error

Code:

Shiva:~/.ut2004# ./mapchecker.sh
./mapchecker.sh: line 3: foreach: command not found

./mapchecker.sh: line 5: end: command not found

So how would I make it so that it works lol? Do you recommend tcsh?

95se · 03-24-2005, 12:50 PM

Code:

#!/bin/bash

for file in ${_BadMaps[*]}
do
	echo "$file"
end

AC97Conquerer · 03-24-2005, 01:13 PM

NVM I got it!! yee hah!

Code:

#!/bin/bash

# Make sure the folder exists!
if [ -d _BadMaps ] ; then
	echo "Good!"
else
	echo "JESUS NNOO!!!!!!"
	exit 1
fi

# Make sure there is at least one file in there
if [ -f _BadMaps/DM-MetalHell.ut2 ] ; then
	echo "Good!"
else
	echo "GOD NNOO!!!!!!"
	exit 1
fi

# Echo out all files in directory!
for file in _BadMaps/*.ut2 ; do
	echo "$file"
done

I get this (no files in directory):

Code:

Shiva:~/.ut2004# ./mapchecker.sh
Good!
Good!
_BadMaps/CTF-(2K4)AcidPipeXmas.ut2
_BadMaps/CTF-Philae_Nightfall.ut2
_BadMaps/CTF-Q3dm18[SpaceChamber].ut2

gbonvehi · 03-24-2005, 01:28 PM

Try

Code:

for file in _BadMaps/*; do
	echo "$file"
done

AC97Conquerer · 03-24-2005, 01:33 PM

Oohhh man! How could I convert this string:
"_BadMaps/ONS-Jumpmonkey.ut2" to
"Maps/ONS-Jumpmonkey.ut2"

Because I need to move the file from _BadMaps to Maps!

Code:

# Move all _BadMaps folder files to _GoodMaps directory 
for file in _BadMaps/*.ut2 ; do
	echo "mv $file _GoodMaps/$file"
done

I get this:

Code:

mv _BadMaps/ONS-Eire.ut2 _GoodMaps/_BadMaps/ONS-Eire.ut2

---EDIT---
Thank you gbonvehi

gbonvehi · 03-24-2005, 01:39 PM

When you append a name you're actually "renaming" the file, try: "mv ./_BadMaps/$file ./_GoodMaps/"

AC97Conquerer · 03-24-2005, 02:48 PM

The ./ isn't helping

Code:

# Move all _BadMaps folder files to _GoodMaps directory
for file in _BadMaps/*.ut2 ; do
	echo "mv ./_BadMaps/$file ./_GoodMaps/$file"
done

Code:

mv ./_BadMaps/_BadMaps/ons-Magma1.ut2 ./_GoodMaps/_BadMaps/ons-Magma1.ut2
mv ./_BadMaps/_BadMaps/ons-betamap2.ut2 ./_GoodMaps/_BadMaps/ons-betamap2.ut2

gbonvehi · 03-24-2005, 05:49 PM

I said that you should remove the $file at the end of GoodMaps.. like...
"mv _BadMaps/$file _GoodMaps/"

AC97Conquerer · 03-24-2005, 06:48 PM

Oh doh! Thank you lol

AC97Conquerer · 03-25-2005, 01:35 AM

PERFECT, here's the final script and the part I was working on, I don't need it after I reinstalled UT2004, because all of the maps don't give me the ReadFile EOF lol:

Code:

#!/bin/bash
#
# MAKE SURE THE MAPS GET SENT WHERE THEY SHOULD
# /root/.ut2004/_ProcBad OR /root/.ut2004/_ProcGood
# CREATED BY a Psycho All Rights Reserved
#


#
# TEST MAP
# 
testMap()
{
	#echo "Currently working on $currentMap" 

	UT2004_DATA_PATH='/root/.ut2004/System'
	cd '/root/.ut2004/System/'
	./ut2004-bin > /home/kleid/Programming/Laboratory/loggit.log &
	sleep 11
	killall ut2004-bin
	sleep 2
	
	# Does the map have an error? 
	#cat /home/kleid/Programming/Laboratory/loggit.log | grep -ic 'Error\|EOF'
	if [ `cat /home/kleid/Programming/Laboratory/loggit.log | grep -ic 'EOF\|Error'` = 0 ] ; then
		echo "$currentMap is a good map"
		mv -uf /root/.ut2004/Maps/$currentMap /root/.ut2004/_ProcGood/$currentMap
	else
		echo "$currentMap is a bad map"
		mv -uf /root/.ut2004/Maps/$currentMap /root/.ut2004/_ProcBad/$currentMap
	fi
}



# Make sure the folder exists! 
if [ -d /root/.ut2004/_BadMaps ] ; then
	echo "Good!"
else
	echo "JESUS NNOO!!!!!!"
	exit 1
fi

mfiles=`ls -1 /root/.ut2004/_BadMaps`
counter=1
for i in $mfiles ; do
	echo "Testing map {$i}..."
	mv /root/.ut2004/_BadMaps/$i /root/.ut2004/Maps/$i
	currentMap="$i"
	testMap
	
	counter=$(($counter+1))
	
done

echo 'MAP SYNC COMPLETE'

VectorThorn · 03-18-2009, 02:30 AM

Thanx for the posts guys. You saved me about 2 to 4 hours of work

. I was reading through the BASH manual on gnu.org and the way they put it together made reading it worthless to those who are not already advanced users; it is better suited as a reference manual for experts.

arvind.k · 07-06-2011, 12:25 AM

This script used to move files from one folder to other folder
using shell....

#!/usr/bin/bash

for file in <source folder>* ;
do
mv $file <destination folder>/
done